Solved Problem with List<String>

Hello!

I'm doing a list with spawns but I got errors when I add more than 1 spawn...
I use this:

Code:java

private List<String> spawns = null;
public void addSpawn(String location){
        Bukkit.broadcastMessage("0");
        if(this.spawns != null){
            Bukkit.broadcastMessage("1");
            List<String> spawnList = this.spawns;
            Bukkit.broadcastMessage("2");
            spawnList.add(location);
            Bukkit.broadcastMessage("3");
            this.spawns = spawnList;
            Bukkit.broadcastMessage("4");
        }else{
            Bukkit.broadcastMessage("1.1");
            this.spawns = Arrays.asList(new String[]{location});
            Bukkit.broadcastMessage("2.1");
        }
    }

I did some debug messages, and I saw it goes until 2. The "spawnList.add(location);" doesn't work and I don't understand why.
Can anyone help me? :s

 

ArthurMaker
Does it throw an exception or is it just doing nothing?

 

Because you can do anything with null object?

Code:java

private List<String> spawns =null;

change to

Code:java

private List<String> spawns = new ArrayList<>();

 

It throws an exception.

 

You were catching an exception, and the exception has been thrown right at spawnList.add(location).

Could you change the catch clause in the other part of your code?

Code:

}catch(Exception e){}
 
//to
 
}catch(SpecificException e){}

EDIT: nvm, didnt see your last post.

Is the exception IllegalStateException?

 

Gosh, I forgot the "new ArrayList<String>()".
I'll try it out, ninja.

 

I think Arrays.asList returns an unmodifiable list.

 

Nope, it doesn't work too with "new ArrayList<String>()"...

Not working...

 

ArthurMaker Because your storing a location in a string?

 

Nope, I convert the location to a string before execute the addSpawn().

 

Code:java

List<String> locations = new ArrayList<String>();
public void addLocation(String location) {
locations.add(location);
}

That should work

 

Nope, doesn't work... e-e

 

if it does not work you obviously did something wrong.
post "fixed" code and stacktrace.

 

Did you see the edit?

Whats the exception?

 

}catch (Exception e){

Nope, nothing wrong.
The code in the post is which almost worked. I mean, it added 1 string to the list, but just this. The others code doesn't work.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Don't do that

In general, exceptions aren't a "break" in code, they are just another utility. When a specific exception is thrown, it is thrown so that you can handle the exception the correct way.

There are also Runtime exceptions that, by design, should not be caught (NullPointer, OutOfMemory). RuntimeExceptions represent exceptions that result from an error in the code itself.

If you choose to catch all exceptions and then, say, exit the program. That might be a usable case for this. Otherwise I would recommend against it.

This post has some other general information about the practice: http://stackoverflow.com/a/21950/1786065

As stated before, post your full code, and relevant stack trace.

 

EDIT:
Solved! I just edited some things in the code and now it works perfectly.
Thank you guys, for your help!

 

Remove this:

Code:java

@SuppressWarnings("null")

And you'll likely find your error. You should not be suppressing warnings.