Potion without glow effect?

Is it possible to create colored water in bottle without the potion and the glow effect? (I know I can check for when player get effect)
example : look at the right of the page. http://minecraft.gamepedia.com/Potions

 

Not sure on the glow, but you can deny the effect based on name or lore

 

remove NBT tags from item, it will remove effects and glow.

 

Barinade Really love that cat xD and thanks!, RawCode I havent used NBT tags yet, is there anyway to do it with packets? if no, mind explain more about those NBT tags?

 

Get it's Minecraft ItemStack first

 

Barinade Done, next?.. haha

 

You can try setTag(null), not sure if that will work

 

just perform original research, NBT is very simple to use and understand, some questions about serialization and networking can be ignored at early stages (game will handle it on it's own)

 

RawCode Barinade
After editing the NBT data of the potion, how do I apply it to the itemstack and send it to the player?..

 

some questions about serialization and networking can be ignored at early stages (game will handle it on it's own)

 

RawCode I still dont understand how to use NBT tags ... xD I have been look thru the forums, didnt learn anything tho... can you please explain me on those tags and how to use them? tutorial maybe?

 

http://minecraft.gamepedia.com/NBT_format

 

This glow enchantment code will help:

Code:java

import java.lang.reflect.Field;
 
import org.bukkit.enchantments.Enchantment;
import org.bukkit.enchantments.EnchantmentTarget;
import org.bukkit.enchantments.EnchantmentWrapper;
import org.bukkit.inventory.ItemStack;
 
public class EnchantGlow extends EnchantmentWrapper
{
 
private static Enchantment glow;
 
static String name;
public EnchantGlow(int id)
{
super(id);
}
 
@Override
public boolean canEnchantItem(ItemStack item)
{
return true;
}
 
@Override
public boolean conflictsWith(Enchantment other)
{
return false;
}
 
@Override
public EnchantmentTarget getItemTarget()
{
return null;
}
 
@Override
public int getMaxLevel()
{
return 10;
}
 
@Override
public String getName()
{
return name;
}
 
@Override
public int getStartLevel()
{
return 1;
}
 
public static Enchantment getGlow(String cname)
{
if ( glow != null )
return glow;
 
try
{
Field f = Enchantment.class.getDeclaredField("acceptingNew");
f.setAccessible(true);
f.set(null , true);
}
catch (Exception e)
{
e.printStackTrace();
}
name=cname;
glow = new EnchantGlow(255);
Enchantment.registerEnchantment(glow);
return glow;
}
 
public static void addGlow(ItemStack item, String name)
{
Enchantment glow = getGlow(name);
 
item.addEnchantment(glow , 1);
}
 
}

This should do the work.

 

NonameSL So the glow effect controlled by addGlow(ItemStack, String) and EnchantGold();?
I still cant understand how to remove it, isnt there a way to do it with packets maybe?

 

that method is result of noobish approach to solve issues, IMHO such coding samples not allowed to ever show on bukkit forum. NonameSL

Glow added by:

Code:

	CraftItemStack tz = (CraftItemStack) tt.getPlayer().getItemInHand();
	if (tz == null)return;
	net.minecraft.server.v1_7_R1.ItemStack handle = (net.minecraft.server.v1_7_R1.ItemStack) UnsafeImpl.getObject(tz, "handle");
	handle.setTag(new NBTTagCompound());
	NBTTagList ttz = new NBTTagList();
	ttz.add(new NBTTagCompound());
	handle.tag.set("ench", ttz);

with this code with a bit of skill you can make snippet to remove glow, lore or anything else.

 

RawCode Thanks, but I still cant understand, Il have to set the tag to null? heres ItemPotion class, where do you see the code for making it glow? is it even in that class? also, after Im setting the ItemStack nbt tag to X, can I just give it to players? or Il need like to "update" the ItemStack?

 

what about pressing control+c and control+v and pasting code i posted into your testing plugin (if you have none - bad news for you)?

 

RawCode Dude, Im aint looking for spoon-feed, Im trying to learn... copy paste isnt learning, I would like to know WHY is that remove the glow effect (if it is) and some other questions about NMS itemstack

EDIT: Whats that? UnsafeImpl

 

if you not looking for spoon feeding, ok, i will explain.

1) Items rendered client side.
2) Render class can be reached with some help from MCP and from other sources, just google it.
also you can just decompile minecraft and seek by hardcoded string constants.

3) Render class will render any item with enchantment glow if it have NBT tag "ench" of type 10.

4) About NBT types, refer NBTBase class and all classes that extend it, there are 16 types total.

5) Networking and storage park skipped, game will handle it on it's own, most classes that alter enviroment have buildin packet senders, feel free to read entire class-method chain self to discover them.

6) UnsafeImpl is my own wrapper of reflections\unsafe that allow set\get fields ignoring memory barriers.

 

RawCode Thanks, amazing! and if an item have NBTtag of "ench" 10 it would glow, so if I were to make it 0 instead of 10, its wont glow ? how can I set the number?

 

4) About NBT types, refer NBTBase class and all classes that extend it, there are 16 types total.

 

RawCode You just repeated what you said before didnt ya?... Im asking how would I set the number to not be 10, also, can you post your UnsafeImpl class?

 

You can use this to do that with a copy, what he's doing is using reflection to grab this, which you could use if you had to modify the original stack.

To find all the nbt classes, go here and type in "nbt". You can access that 'File Finder' page by hitting the "t" key on a github repo.

 

https://github.com/RawCode/GPT/blob/master/src/rc/ubt/Tester.java

https://github.com/RawCode/GPT/blob/master/src/rc/ubt/impl/UnsafeImpl.java

if you can't understand for any reason how UnsafeImpl works use standart reflections, in other case pain will follow you.

 

RawCode Garris0n Thank you alot guys! youre amazing

 

How would you get it so that if an itemstack is in a slot then remove the glow effect from it?

somebody?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

care to read thread?
i already posted code sample.

 

I meant when Itemstack is equal to Material.BLOCK

 

Sorry for bumping it, but its kinda poinless to make new theard on same thing... My code have been working for while but now its not, I have no idea why tho... also I still got few questions:
Garris0n RawCode

Code:java

    @EventHandler
    public void onTest(PlayerInteractEvent e){
        if(e.getAction() == Action.RIGHT_CLICK_BLOCK && e.getClickedBlock() != null && e.getClickedBlock().getType()
        == Material.DIAMOND_BLOCK && e.getPlayer().getItemInHand() != null){
            Player p = e.getPlayer();
            CraftItemStack cis = (CraftItemStack) p.getItemInHand();
            try{
                Field hf = CraftItemStack.class.getDeclaredField("handle");
                hf.setAccessible(true);
                net.minecraft.server.v1_7_R1.ItemStack handle = (net.minecraft.server.v1_7_R1.ItemStack)hf.get(cis);
                handle.setTag(new NBTTagCompound()); //why adding new NBTTagCompund?
                NBTTagList ntl = new NBTTagList();
                NBTTagCompound ntc = new NBTTagCompound();
                ntc.setInt("ench", 0); //@RawCode said that if the "ench" tag != 10, then its wont glow, its still glow with protection enchantment level 0...
                ntl.add(ntc);
                handle.tag.set("ench", ntl); //what is this? 
            }catch(Exception exc){
                exc.printStackTrace();
            }
        }
    }

 

3) Render class will render any item with enchantment glow if it have NBT tag "ench" of type 10.
4) About NBT types, refer NBTBase class and all classes that extend it, there are 16 types total.

since you at least did some code, i will spoonfeed you

handle.setTag(null);