Question Post Forwarding problem

I've been doing my minecraft server for 4 hours right now, everything is fine, but my friends can't join it, when they try they get this error:
java.net.connectexception connection timed out no further information

I have added 25565 ports on my router but even I can't join it.

It's a problem in post forwarding but I don't know what.

 

Are you able to join when you type localhost ?

 

Yes I can, and with my local IP. But my friends cannot with my external IP, even I can't join with external IP.

 

*facepalm* You shouldn't use the external ip, you should use the ipv4. Port-forward with that.

 

Also make sure that server-ip= is blank in your server.properties.

 

And one more question, is my external IP what I need to give to my friends so they can join?

 

@TimbeXeite Simple answer: Yes.

 

My friends are still getting java.net.connection timed out no further information

 

Go to http://canyouseeme.org/ and type in your external IP and port. If it says it can't see you, you've set up your port forwarding incorrectly.