Portal Types : How to detect them?

Hello. I'm here asking about portal types. I'm making my own plugin to solve my issue that on my server, my 1.6.4 world has its own Nether and End worlds, but the 1.7.2 world will not generate its own Nether and End worlds; in fact, I've found a stronghold in the 1.7.2 world that doesn't even have an End portal. I hope someone has the answer to this so I can proceed with my development. Thanks!
I have little code written already, as I just started today and encountered this problem. If it helps, here's what I have in my first portal listener class so far.

Code:java

package me.pookeythekid.Portals.Listeners;
 
import me.pookeythekid.Portals.Main;
 
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerPortalEvent;
 
public class NetherPortals implements Listener {
 
    public Main M;
 
    public NetherPortals(Main instance) {
        M = instance;
    }
 
    @EventHandler
    public void onNetherPortalEnter(PlayerPortalEvent e) {
 
    }
 
}

 

pookeythekid
Check if the getCause() equals a PlayerTeleportEvent.TeleportCause NETHER or END portals

 

xTrollxDudex Ah thanks! I was using "PlayerPortalEvent"!!! That must be why I didn't see "e.getCause()" in my list of options (I use Eclipse Kepler). Thanks for clarifying.

xTrollxDudex Hm. I tried these two pieces of code and it didn't work.

Code:java

@EventHandler
public void onPlayerPortal(PlayerTeleportEvent e) {
if (e.getCause() == PortalType.NETHER /*or ENDER*/) {
//code
}
}

Code:java

@EventHandler
public void onPlayerPortal(PlayerTeleportEvent e) {
if (e.getCause() instanceof PortalType.NETHER /*or ENDER*/) {
//code
}
}

xTrollxDudex Oh! Nevermind, it works!

Code:java

e.getCause().NETHER_PORTAL
//or
e.getCause().ENDER_PORTAL

Edit: Okay, this is a little odd and lame at the same time. :/

Code:java

if (e.getCause() == TeleportCause.NETHER_PORTAL) {
//code
}

It corrected me to this, but when I originally used it, it didn't work! >: (

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

This may be old (idk I'm on my phone) but is there anyway to check the type of portal before they teleport? I was thinking possibly check the nearest blocks but that may slow down the plugin.

Edit:
Forgot my portals don't work anyways, so I can't use the teleport event.

 

With the teleport event...

 

Isn't that only called when a player teleports

 

If an event is cancellable that almost always means it's called right before the thing happens so you can stop it. One known exception to this is the PlayerDropItemEvent, which leads to that dreadful error where the item moves to a different slot in the player's inventory.

 

I don't think I'm understanding you correctly. Are you saying that the event, player teleport event, will run when the player wasn't teleported? Well, I'll try it but I'm pretty sure it wont work xD

 

Yes. Not teleported yet.

 

It didn't work, but the event was being fired (just not when I entered the portal). I got the chance to see that PlayerPortalEvent has a getCause() method though.. And honestly I swear that wasnt there before xD
Thanks for your help anyways, Garris0n ^_^

 

I've tried using PlayerPortalEvent, testing the event by sending the player a message when they used the portal. It didn't work... Any idea what you did differently? Here's the code I used.

Code:java

package me.pookeythekid.Portals.Listeners;
 
import me.pookeythekid.Portals.Main;
 
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerPortalEvent;
 
public class NetherPortals implements Listener {
 
    public Main M;
 
    public NetherPortals(Main instance) {
        M = instance;
    }
 
    @EventHandler
    public void onPortalEnter(PlayerPortalEvent e) {
            e.getPlayer().sendMessage("HELLO");
    }
 
}

 

pookeythekid
Did you register the event in your main class?

 

Drew1080 I'm quite sure I did. Let me check. I'm pretty sure it would give me a "Can't pass event" error if I didn't.

Edit: Yeah, I registered the events.

Code:java

package me.pookeythekid.Portals;
 
import java.util.logging.Logger;
 
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
import me.pookeythekid.Portals.Listeners.NetherPortals;
 
public class Main extends JavaPlugin {
 
    public final Logger logger = Logger.getLogger("Minecraft");
    public final PluginDescriptionFile pdf = this.getDescription();
    public final PluginManager pm = this.getServer().getPluginManager();
    public final NetherPortals np = new NetherPortals(this);
 
    @Override
    public void onDisable() {
        logger.info("[" + pdf.getName() + "] Portals v" + pdf.getVersion() + " Is Now Enabled.");
    }
 
    @Override
    public void onEnable() {
        logger.info("[" + pdf.getName() + "] Portals Is Now Disabled.");
 
        pm.registerEvents(np, this);
    }
 
}
 

 

Code:java

 @EventHandler
public void portalEvent(PlayerPortalEvent event){
event.getPlayer().sendMessage(event.getCause().toString());
event.getPlayer().sendMessage("Entering From "+event.getFrom().getWorld().getName().toString());
}

Code:java

Bukkit.getServer().getPluginManager().registerEvents(new Listeners(), this);

 

MrAwellstein So.... it's "playerPortal(blah event name)" instead of "onPlayerPortal"? Or does it matter?

Edit: Also, does "toString()" mean to make an object a string? And if so, then do you need to send the player "getWorld().getName().toString()"? I'm pretty sure "getName()" is already a string by itself.

 

I just get OCD about the .getName(). I dont have to do .toString()
Also I dont think your listener is being called.

 

MrAwellstein Sorry for the late reply. School started again. -_- I had a week off last week. Why don't you think my listener is being called?

 

It just doesn't look like it's being registered. And it's fine, it was the same for me (the school thing)

 

MrAwellstein The way I'm using my listener is the same way I'm doing it with my plugin SecureLogin. You can see it if you click the My Plugins link in my profile summary to the left. SecureLogin is functional with its listeners, and having done just the same in this portals plugin, I don't see why the listener isn't being called. My listener registering is in my main class in the first post of this message, if you want to look at that to see what I'm doing wrong.

 

Try doing thep = new NetherPortals(this); in the on enable, rather than just being there not in a method

Alsop
m.registerEvents(new NetherPortal(this), this);
Will work.

In case you don't know, player portal event only is called when the attempted teleportation happens. Meaning if you are expecting it to happen when you walk into the portal it won't be called instantly unless you are in creative

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

MrAwellstein Creative.... I think I've been in Creative every time I went through the portal... But I do think it's interesting how it only gets called instantly if you're in Creative Mode. I wonder if that's fixable, or if the Bukkit Dev team is already on it. Anyway, thanks, I'll try it in Survival Mode now and see if the listener works.

 

Its fixable with packets.

 

MrAwellstein Ew, packets. Something I will never understand... xD
By the way, it didn't end up working in Survival. At least not with my method of listeners. But oh well, I found a better way to handle the problem on my server anyway.

 

Thats good

 

MrAwellstein Even though I've found a solution anyway... I have discovered something new. In my server console on the startup, it says the plugin simply can't load. "Could not load file "plugins/Portals.jar"" or whatever.

MrAwellstein I also know that my listeners work because I'm making another plugin that uses listeners with the same method and it works.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.