Solved plugin datafolder is null?

Hello, I am trying to initialize my plugin to use in my join event listener. This is my listener so far, but I have narrowed down that plugin itself is not null, but, plugin.getDataFolder is null. Why is this null and how can I fix it?

Code:

package com.kmccmk9.HDSkinner;
 
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.logging.Logger;
 
import lib.PatPeter.SQLibrary.Database;
import lib.PatPeter.SQLibrary.SQLite;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.getspout.spoutapi.SpoutManager;
import org.getspout.spoutapi.player.SpoutPlayer;
 
public class playerListener implements Listener {
    @EventHandler public void onPlayerJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        SpoutPlayer splayer = SpoutManager.getPlayer(player);
        String playername = "\"" + player.getDisplayName() + "\"";
        HDSkinner plugin = new HDSkinner();
        if (plugin.getDataFolder() == null)
            System.out.println("plugin is null");
        else
            System.out.println("plugin is not null");
        Database sql2 = new SQLite(Logger.getLogger("Minecraft"), "[HDSkinner] ", plugin.getDataFolder().getAbsolutePath(), "HDSkinner", ".sqlite");
        sql2.open();
        try {
            System.out.println("playername is " + playername);
            if (sql2 == null)
                System.out.println("sql is null");
            ResultSet results = sql2.query("SELECT skin FROM userdata WHERE user=" + playername);
            if (!results.isBeforeFirst() ) {   
                splayer.sendMessage("Sorry you have no skin/cape data on file");
            }
            else {
                System.out.println("There is data");
            }
        } catch (SQLException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }
    }
}

 

You haven't created the folder.

 

Okay well that is in my playerListener so it was created by my main class. How do I access that?

 

What do you mean? The data folder is just the folder with your plugin's name in the plugins folder in the server's root directory. The only real cause for it to be null would be if it hasn't yet been created.

 

//ninja'd by AngryNerd =P
Is your player listener initialized properly? If you created the file in your player listener and your player listener is null, then your data folder is null.

 

But it has, that's where my db file is that I'm trying to access.

Yes it is, because without the code above it does return true and I can print something out from within my listener. Here is my main class if it helps:

Code:java

package com.kmccmk9.HDSkinner;
 
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.logging.Logger;
 
import lib.PatPeter.SQLibrary.Database;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Server;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
import org.getspout.spoutapi.SpoutManager;
import org.getspout.spoutapi.player.SpoutPlayer;
 
import lib.PatPeter.SQLibrary.*;
import lib.PatPeter.SQLibrary.Builders.MySQL.Table;
 
public class HDSkinner extends JavaPlugin {
    //Variables
    Server server;
    Database sql;
    Table skins;
 
    public void onDisable()
    {
        System.out.print("HDSkinner is disabled");
    }
 
    public void onEnable()
    {
        sql = new SQLite(Logger.getLogger("Minecraft"), "[HDSkinner] ", this.getDataFolder().getAbsolutePath(), "HDSkinner", ".sqlite");
        openDatabase();
        System.out.print("HDSkinner is enabled");
        server = this.getServer();
        playerListener pListener = new playerListener();
        Bukkit.getServer().getPluginManager().registerEvents(pListener , this);
    }
 
    public boolean onCommand(CommandSender sender,Command command, String commandLabel,String args[])
    {
 
        if (sender instanceof Player)
        {
            Player player = (Player) sender;
            SpoutPlayer splayer = SpoutManager.getPlayer(player);
            if(commandLabel.equalsIgnoreCase("skin"))
            {
                if (args.length == 1)
                {
                    if (args[0].equalsIgnoreCase("help"))
                    {
                        player.sendMessage(ChatColor.BLUE + "Type the command skin followed by the url to change your skin to that url.");
                    }
                    else
                    {
                        try {
                            String playername = "\"" + player.getDisplayName() + "\"";
                            String link = "\"" + args[0] + "\"";
                            ResultSet results = sql.query("SELECT user FROM userdata WHERE user=" + playername);
                            if (!results.isBeforeFirst() ) {   
                                String query = "INSERT INTO userdata (user,skin) VALUES (" + playername + "," + link + ")";
                                sql.query(query);
                            }
                            else {
                            String query = "UPDATE userdata SET skin=" + link + " WHERE user=" + playername;
                            sql.query(query);
                            }
                        } catch (SQLException e) {
                            // TODO Auto-generated catch block
                            e.printStackTrace();
                        }
                        splayer.setSkin(args[0]);
                    }
                }
                else
                {
                    player.sendMessage(ChatColor.DARK_RED + "Arguments mismatch. Type the skin command followed by help.");
                }
            }
            if(commandLabel.equalsIgnoreCase("cape"))
            {
                if (args.length == 1)
                {
                    if (args[0].equalsIgnoreCase("help"))
                    {
                        player.sendMessage(ChatColor.BLUE + "Type the command cape followed by the url to change your cape to that url.");
                    }
                    else
                    {
                        try {
                            String playername;
                            String link;
                            playername = "\"" + player.getDisplayName() + "\"";
                            link = "\"" + args[0] + "\"";
                            ResultSet results = sql.query("SELECT user FROM userdata WHERE user=" + playername);
                            if (!results.isBeforeFirst() ) {   
                                String query = "INSERT INTO userdata (user,cape) VALUES (" + playername + "," + link + ")";
                                sql.query(query);
                            }
                            else {
                            String query = "UPDATE userdata SET cape=" + link + " WHERE user=" + playername;
                            sql.query(query);
                            }
                        } catch (SQLException e) {
                            // TODO Auto-generated catch block
                            e.printStackTrace();
                        }
                        splayer.setCape(args[0]);
                    }
                }
                else
                {
                    player.sendMessage(ChatColor.DARK_RED + "Arguments mismatch. Type the cape command followed by help.");
                }
            }
        }
        return true;   
    }
 
    public void openDatabase() {
        if (!sql.open())
            sql.open();
        try {
            sql.query("CREATE TABLE if not exists userdata(user TEXT, skin TEXT, cape TEXT)");
        } catch (SQLException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }
    }
 
    public void closeDatabase() {
        if (sql.open())
            sql.close();
    }
 
    public void setPlayer() {
 
    }
 
}
 

 

So yeah, you haven't created the data folder yet, put something like this on the onEnable()

Code:

File fileinfo = new File(getDataFolder(),"something.yml");
 
        if(!getDataFolder().exists()) getDataFolder().mkdir(); 
                if(!fileinfo.exists()) { 
                    try {
                        fileinfo.createNewFile();
                        getConfig().options().copyDefaults(true);
                        getConfig().save(fileinfo);
                        getConfig().options().copyDefaults(false);
                    } catch (IOException e) {
                        // TODO Auto-generated catch block
                        System.out.println("Uh-Oh, Something happened!");
                    }
                }

This will create a folder with the name of your plugin, and a file in it called "something.yml"

 

Thanks for replying, although I have a question. If I don't have any code that makes the folder, then why on first run does it create the folder and put the database file in it?

 

Then somewhere in your code you're creating the file, but not making it accessible to the other classes. Therefor, it's being created but it's null to the plugin because the plugin can't read / write to it. That's my only guess.

 

Okay I added these lines to my onEnable() but again its still null in the playerlistener.

Code:java

if(!getDataFolder().exists())
            getDataFolder().mkdir();

 

saw this inside your listener:
HDSkinner plugin = new HDSkinner();
if (plugin.getDataFolder() == null)
NEVER create an instance of your main class somewhere, always let bukkit create it, and pass it around in onenable, so your class know how it needs to acces its datafolder

 

Okay so how would I do that then?

 

pass the main instance to your listener when you construct your listener

 

Okay so I changed my listener to this:

Code:java

public class playerListener implements Listener {
    //Global Vars
    Database sql2;
 
    public void playerListener(Database sql) {
        sql2 = sql;
    }
    @EventHandler public void onPlayerJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        SpoutPlayer splayer = SpoutManager.getPlayer(player);
        String playername = "\"" + player.getDisplayName() + "\"";
        try {
            System.out.println("playername is " + playername);
            if (sql2 == null)
                System.out.println("sql is null");
            ResultSet results = sql2.query("SELECT skin FROM userdata WHERE user=" + playername);
            if (!results.isBeforeFirst() ) {   
                splayer.sendMessage("Sorry you have no skin/cape data on file");
            }
            else {
                System.out.println("There is data");
            }
        } catch (SQLException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }
    }
}

So how would I change this?

Code:java

playerListener pListener = new playerListener();
 
I tried doing
playerListener pListener = new playerListener(sql);