Solved PlayerPickupItemEvent

What's wrong with my code? I'm still picking up poisonous potatoes, and my variable in the HashMap isn't being incremented.

Code:java

@EventHandler
public void onPickup(PlayerPickupItemEvent event) {
    Player player = event.getPlayer();
    if (player.getWorld() == Bukkit.getServer().getWorld("battlefield")) {
        if (event.getItem() == new ItemStack(Material.POISONOUS_POTATO)) {
            event.setCancelled(true);
            Coins.addCoins(player.getName(), 1);
            event.getItem().remove();
        }
    }
}

 

KeybordPiano459
Try replacing the if(event.getWorld()) blah blah part to this:

Code:JAVA

 
if(player.getWorld().getName().equalsIgnoreCase("battlefield")) {
// Other stuff
}
 

Also I don't think you have to make a new itemstack, you could just do:

Code:JAVA

 
if(event.getItem().getType() == Material.POISONOUS_POTATO)) {
// Other stuff
}
 

 

First of all, in PlayerPickupItemEvent, event.getItem().getType() returns an EntityType, not a Material. Second of all, that didn't solve it...

 

Do what RealDope suggested for the event.getWorld() part

And it's not working is because getItem() returns an Item, not an ItemStack
To get the ItemStack from an Item, use event.getItem().getItemStack(), then with the ItemStack you can use .getType() to get the Material

Code:

if (event.getItem().getItemStack().getType() == Material.POISONOUS_POTATO) {
    //Do other stuff
}

 

Thanks, that worked. Also, for anyone wondering how to do this with the new items combining into one entity (added in 1.4 or something) do it like this to add the amount of items in the single entity:

Code:java

if (player.getWorld().getName().equalsIgnoreCase("battlefield")) {
    if (event.getItem().getItemStack().getType() == Material.POISONOUS_POTATO) {
        event.setCancelled(true);
        Coins.addCoins(player.getName(), event.getItem().getItemStack().getAmount());
        event.getItem().remove();
    }
}

 

Note that

Code:java

if(player.getWorld() == Bukkit.getWorld("someworld"))

is just perfectly fine, as player.getWorld() and Bukkit.getWorld("someworld") are references of the same object (if they are in the same world)