Solved PlayerDrinkEvent workaround does not work as required

Hey there


So for the minigame I'm currently working on i need to check for a player drinking. Unfortunately i could not find a PlayerDrinkEvent or so, so i googled and found this thread.
According to it, i wrote the following code:

Code:java

@EventHandler
public void onConsumeItem(PlayerInteractEvent pie) {
    if (!(pie.getAction() == Action.RIGHT_CLICK_AIR || pie.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
 
    final Player p = pie.getPlayer();
 
    if (p.getItemInHand() == null) return;
    if (!(p.getItemInHand().getType() == Material.MILK_BUCKET)) return;
 
 
    Bukkit.getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
        @Override
        public void run() {
            if (p.getItemInHand() != null && p.getItemInHand().getType() == Material.MILK_BUCKET) {
                p.getInventory().remove(p.getItemInHand());
                System.out.println("Success");
            }
        }
    }, 28);
}

My delay is 28 ticks because i figured out that drinking takes a bit more than 1:38 seconds what is 27,6 ticks.

The Syso is a feedback for me so i know that the player did not just consume the milk.

And it almost works fine! Yeah, it might take a lot of ressources when many players drink a bucket of milk, but let's overlook this. My problem is that i cannot test for the player still _drinking_. If the player was only right clicking with the milk in his hand and then released the mouse button, the milk will be removed even though he actually is not drinking anymore.


I hope someone has an idea on how to fix this :3
~Robin Bi

 

Robin Bi
Why are you using a PlayerInteractEvent? Use a PlayerItemConsumeEvent

 

JustinsCool15 mhmm, did not know this was implemented, thought the thread would still be up to date... Thanks

 

Robin Bi Just a tip
http://jd.bukkit.org/beta/apidocs/ + CTRL & F (or CMD & F in macs) = Solution 99% of the times