Player can join for a time (in area)

I´m creating a plugin for the player join in a specific area for a time and back in the hub, i tried to make a scheduler but it doesn´t work, cause i need make 1 for each player and the server gets lag. How can i make it?

 

@PlayerNerd When they join save them in a Map with the current time. Then create a repeating task and compare the time.

 

@Skionz I need make for the players join in different time, not for a group of players, when i make it with scheduler the first player that joined stay getting messages and teleport and the others don´t go.

 

What? Please use google translate it is hard for me to understand you.

 

@Skionz I'm doing a safari plugin for pixelmon server, and I need the players to join at any time of day. When i use shceduler to teleport the player that ends the he is getting a message infinite and infinitely teleporting and the other players do not.

 

@PlayerNerd What do you mean join at any time of the day? Post your code so far.

 

@Skionz

Code:

@EventHandler
    public void onRightSign(PlayerInteractEvent e)
    {
        final Player p = e.getPlayer();
       
        Block b = e.getClickedBlock();
       
        if(e.getAction().equals(Action.RIGHT_CLICK_BLOCK) && (b.getType() == Material.SIGN_POST || b.getType() == Material.WALL_SIGN))
        {
            Sign s = (Sign) b.getState();
           
            Location safari = new Location(Bukkit.getWorld(plugin.getConfig().getString("safari.safari.world")), plugin.getConfig().getDouble("safari.safari.x"), plugin.getConfig().getDouble("safari.safari.y"), plugin.getConfig().getDouble("safari.safari.z"));
   
            if(s.getLine(0).equalsIgnoreCase(ChatColor.DARK_GREEN + "[" + ChatColor.GREEN + "Safari" + ChatColor.DARK_GREEN + "]") && s.getLine(1).equalsIgnoreCase(ChatColor.DARK_GREEN + "10 Min") &&
                    s.getLine(2).equalsIgnoreCase(ChatColor.DARK_GREEN + "$750"))
            {
               
                    if(Main.econ.getBalance(p.getName()) >= 750)
                    {
                       
                        if(p.hasPermission("playernerd.safari.entrar.10"))
                        {
                           
                        Main.econ.withdrawPlayer(p.getName(), 750);
                        p.teleport(safari);
                        p.sendMessage(Main.nserv + "Você tem " + ChatColor.DARK_GREEN + "$" + Main.econ.getBalance(p.getName()) + ChatColor.GREEN + " agora.");
                        p.sendMessage(Main.nserv + "Você está no safari por 10 Minutos.");
                        Main.nosafari10.add(p);
//I stop here for make the loop
                       
                       
                        }else {
                            p.sendMessage(Main.nserv + ChatColor.RED + "Nop!");
                        }
                       
                    } else {
                        p.sendMessage(Main.nserv + ChatColor.RED + "Ei! " + ChatColor.GREEN + p.getName() + ChatColor.RED +
                                " para entrar no Safari você deve ter no minimo " + ChatColor.DARK_GREEN + "$750" + ChatColor.RED + "");
                           }
                   
                   
            }
           
            if(s.getLine(0).equalsIgnoreCase(ChatColor.DARK_GREEN + "[" + ChatColor.GREEN + "Safari" + ChatColor.DARK_GREEN + "]") && s.getLine(1).equalsIgnoreCase(ChatColor.DARK_GREEN + "30 Min") &&
                    s.getLine(2).equalsIgnoreCase(ChatColor.DARK_GREEN + "$1200"))
            {
               
            }
        }
    }

 

Man use a Map:

Code:java

 
Map<UUID, Integer> players = new HashMap<UUID, Integer>();
 
//Ad the player to the map
Player player = event.getPlayer();
UUID uuid = player.getUniqueId();
players.put(uuid, time); //Replace time for how much seconds you wanna keep the player inside the arena
 
//Runnable at 20 ticks
private BukkitTask task;
public void runnable()
{
    this.task = new BukkitRunnable()
    {
      @Override
      public void run() {
//Loop to get all online players
for(Player online : Bukkit.getOnlinePlayers()) {
//Get the uuid from the player
UUID uuid = online.getUniqueId();
//Check if the players is inside the map
if(!players.containsKey(uuid)) { return; }
//Get the seconds
   int time = online.get(uuid);
//If seconds >= 1
       if(time >= 1) {
              //Remove 1 second
                  players.put(uuid, time-1);
//If seconds = 0
         } else {
           map.remove(uuid);
          //Tp player
                }
            }
      }
     }.runTaskTimer(plugin, 10, 10);
}
 
 
//After on the void "onEnable" do this
@Overrde
public void onEnable() {
//Initialize the runnable
runnable();
//Or
classInstance().runnable();
}
 

 

@MaTaMoR_
1. Spoonfeeding is not good, people usually copy and paste without understanding it.
2. Why are you getting all players then not using them?
3. You are putting the player in the list then you are checking they are in and reputting them in -1 from time? Why?

 

1) I did put some explation messages
2) That's a mistake i already changed player for online
3) I'm checking if the player is in the inside the map to don't get a null pointer exception
4) Yes i did put a player inside the hashmap but im checking all players, im reputting it in with -1 what i mean time-1 (60 , 59 , 58 , 57 every second) a count down

 

@MaTaMoR_ People will still copy and paste without reading. I am not talking about the check I just don't really get the point of your code.

Just make a timer to run every second, no need to add players every second...

 

If the player isn't in the map and ill do int time = players.get(uuid) what will happen ?

 

@MaTaMoR_ I have said, I am not talking about the check. You just don't need to add a player to a map every second, just make an int and take one every second.

 

That will return the same time every second .

 

@MaTaMoR_ it doesn´t work

 

Post your code ...

 

@PlayerNerd Of course it doesn't work. His code is inefficient, useless, redundant (in a bad way), and in all ways bad.

 

No it wouldnt...

So if I had the number 20 every second I took one of so I would say 19, 18 ect. It is the same in code, you take one off every second and it takes one off every second.

@PlayerNerd Make an integer then in the timer do variable--;

 

Yeah but how you make that for every player ?

 

@MaTaMoR_ Why are you trying to make it for every player? That included players not in the area.

 

For every player in the arena ...

 

@MaTaMoR_ But you are getting ALL online players, not players in an arena.

 

Yeah but i'm checking if the players is inside the map(arena), you can also just set the keys and check if the player is online or just remove him on quit.

 

@MaTaMoR_ You have no map there with Arena?

 

I don't know if is this what you mean .

Code:java

 
Map<UUID, Integer> players = new HashMap<UUID, Integer>();
 

 

@MaTaMoR_ Where is the arena there? You are getting the player UUID and an integer for time.

 

There should be the players from the arena...

 

Code:

    @EventHandler
    public void onRightSign(final PlayerInteractEvent e)
    {
        final Player p = e.getPlayer();
       
        Block b = e.getClickedBlock();
       
        if(e.getAction().equals(Action.RIGHT_CLICK_BLOCK) && (b.getType() == Material.SIGN_POST || b.getType() == Material.WALL_SIGN))
        {
            Sign s = (Sign) b.getState();
           
            Location safari = new Location(Bukkit.getWorld(plugin.getConfig().getString("safari.safari.world")), plugin.getConfig().getDouble("safari.safari.x"), plugin.getConfig().getDouble("safari.safari.y"), plugin.getConfig().getDouble("safari.safari.z"));
   
            if(s.getLine(0).equalsIgnoreCase(ChatColor.DARK_GREEN + "[" + ChatColor.GREEN + "Safari" + ChatColor.DARK_GREEN + "]") && s.getLine(1).equalsIgnoreCase(ChatColor.DARK_GREEN + "10 Min") &&
                    s.getLine(2).equalsIgnoreCase(ChatColor.DARK_GREEN + "$750"))
            {
               
                    if(Main.econ.getBalance(p.getName()) >= 750)
                    {
                       
                        if(p.hasPermission("playernerd.safari.entrar.10"))
                        {
                           
                        Main.econ.withdrawPlayer(p.getName(), 750);
                        p.teleport(safari);
                        p.sendMessage(Main.nserv + "Você tem " + ChatColor.DARK_GREEN + "$" + Main.econ.getBalance(p.getName()) + ChatColor.GREEN + " agora.");
                        p.sendMessage(Main.nserv + "Você está no safari por 10 Minutos.");
                        Main.nosafari10.add(p);
                       
                        Bukkit.getScheduler().scheduleSyncRepeatingTask(plugin, new Runnable ()
                        {
                           
                            int number = 30;
                           
                            public void run()
                            {
                               
                                Player player = e.getPlayer();
                                UUID uuid = p.getUniqueId();
                                players.put(uuid, number); //Replace time for how much seconds you wanna keep the player inside the arena
                                
                                for(@SuppressWarnings("unused") Player online : Bukkit.getOnlinePlayers()) {
                                if(!players.containsKey(uuid)) { return; }
                                   int time = players.get(uuid);
                                       if(time >= 1) {
                                                  time--;
                                                  players.put(uuid, time);
                                                  player.sendMessage("a");
                                         } else {
                                          player.sendMessage(Main.nserv);
                                          players.put(uuid, 0);
                                }
                                }
                                 
                            }
                                                                }, 0L, 1*20L);
                        }else {
                            p.sendMessage(Main.nserv + ChatColor.RED + "Nop!");
                        }
                       
                    } else {
                        p.sendMessage(Main.nserv + ChatColor.RED + "Ei! " + ChatColor.GREEN + p.getName() + ChatColor.RED +
                                " para entrar no Safari você deve ter no minimo " + ChatColor.DARK_GREEN + "$750" + ChatColor.RED + "");
                           }
                   
                   
            }
           
            if(s.getLine(0).equalsIgnoreCase(ChatColor.DARK_GREEN + "[" + ChatColor.GREEN + "Safari" + ChatColor.DARK_GREEN + "]") && s.getLine(1).equalsIgnoreCase(ChatColor.DARK_GREEN + "30 Min") &&
                    s.getLine(2).equalsIgnoreCase(ChatColor.DARK_GREEN + "$1200"))
            {
               
            }
        }
    }

@MaTaMoR_

 

I really don't know why my post get removed but ok.
You have to put the runnable out of the event .
Just put this inside the event

Code:java

 
Player player = event.getPlayer();
UUID uuid = player.getUniqueId();
players.put(uuid, time);
 

 

@MaTaMoR_ Where do i put it??