'placing' blocks on glass

Hi!

I was working on my plugin, and I want to make it so I can place a pressure plate on glass. I get this error though:

error (open) error (close)

11.12 13:52:15 [Server] INFO ... 15 more
11.12 13:52:15 [Server] INFO at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425) ~[craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_21]
11.12 13:52:15 [Server] INFO at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_21]
11.12 13:52:15 [Server] INFO at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_21]
11.12 13:52:15 [Server] INFO at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_21]
11.12 13:52:15 [Server] INFO at me.sgavster.MyPlugin.kits.KitDemo.onInteract(KitDemo.java:74) ~[?:?]
11.12 13:52:15 [Server] INFO Caused by: java.lang.NullPointerException
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:453) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:541) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:250) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:651) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.handle(SourceFile:9) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.a(SourceFile:60) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:603) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:161) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:191) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477) [craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427) ~[craftbukkit_dev_2938.jar:git-Bukkit-1.6.4-R2.0-28-g373cbb7-b2945jnks]
11.12 13:52:15 [Server] INFO org.bukkit.event.EventException
11.12 13:52:15 [Server] INFO [13:52:15 ERROR]: Could not pass event PlayerInteractEvent to MyPlugin v0.0.1

My code:

Code:java

else if(p.getItemInHand().getType().equals(Material.STONE_PLATE))
            {
                if(plugin.getDemo().contains(p.getName()))
                {
                    plate.add(new Location(e.getClickedBlock().getWorld(), e.getClickedBlock().getLocation().getX(), e.getClickedBlock().getLocation().getY() + 1, e.getClickedBlock().getLocation().getZ()));//ERROR ON THIS LINE
                    e.getClickedBlock().getRelative(BlockFace.UP).setType(Material.STONE_PLATE);
                    if(p.getItemInHand().getAmount() == 1)
                    {
                        p.setItemInHand(null);
                    }
                    else
                    {
                        p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                    }
                    p.sendMessage("You create a land mine! Punch it to remove it!");
                }
            }

Thanks for any help!

 

Code:

11.12 13:52:15 [Server] INFO at me.sgavster.MyPlugin.kits.KitDemo.onInteract(KitDemo.java:74) ~[?:?]
11.12 13:52:15 [Server] INFO Caused by: java.lang.NullPointerException

Whats line 74 in your code?

 

Try setting the itemInHand to Material.AIR and see if that helps.

Otherwise, there isn't enough information to go off of here.

 

L33m4n123 It's commented in the code..

Code:java

 plate.add(new Location(e.getClickedBlock().getWorld(), e.getClickedBlock().getLocation().getX(), e.getClickedBlock().getLocation().getY() + 1, e.getClickedBlock().getLocation().getZ()));//ERROR ON THIS LINE

zeeveener The error is commented in the code.. It should be plenty of information.

 

my bad didn't see that

You're sure that plugin.getDemo() returns a list/Set/Map that actually contains anything?

And check with something (be it debug messages) if the getClickedBlock returns a value and not null

 

sgavster

Check to make sure "e" isn't null.
Check to make sure "e.getClickedBlock()" isn't null
Check to make sure "e.getClickedBlock().getLocation()" isn't null

Follow that system for every variable in that line. Simple debugging process and you should be able to narrow down your search field.

 

L33m4n123 Everything should work. I have this code:

Code:java

    @EventHandler
    public void onPlace(BlockPlaceEvent e)
    {
        Player p = e.getPlayer();
        Block b = e.getBlock();
        if(b.getType().equals(Material.STONE_PLATE))
        {
            if(plugin.getDemo().contains(p.getName()))
            {
                plate.add(b.getLocation());
                p.sendMessage("You create a land mine! Punch it to remove it!");
            }
        }
    }

And it works great. The error isn't on the plugin.getDemo(...).

zeeveener Why would I check if e isn't null? It's the event

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

sgavster

Check everything that is referenced. Even if it seems redundant.

 

To see what exactly is null. And in this case maybe not if e.. but for the future if you are unsure

So if the error is not in plugin.getDemo() it is in e.getClickedBlock().. you are most likely interacting with air. Which is handeled as null.. and get the location from that = NPE

 

L33m4n123 I'm getting a NPE on this now:

Code:java

if(e.getClickedBlock().getType() != null && e.getClickedBlock() != null)

 

Yes because e.getClickedBlock is already null.. so if you try to get the type you get an NPE

Edit: So you need to switch it arround.. check first if e.getClickedBlock != null and then && e.getClickedBlock.getType()!=null

 

L33m4n123 That fixed the error but the block doesn't place :/

Code:java

                    if(e.getClickedBlock() != null && e.getClickedBlock().getType() != null)
                    {
                        Location u = new Location(e.getClickedBlock().getWorld(), e.getClickedBlock().getLocation().getX(), e.getClickedBlock().getLocation().getY() + 1, e.getClickedBlock().getLocation().getZ());
                        plate.add(u);
                        u.getBlock().setType(Material.STONE_PLATE);
                        if(p.getItemInHand().getAmount() == 1)
                        {
                            p.setItemInHand(null);
                        }
                        else
                        {
                            p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                        }
                    }

 

Well. Now you do not get the NPE.. But since e.getClickedBlock IS null [otherwise you would have not gotten the error] the code never reaches anything inside the if-clause

 

L33m4n123 Alright, how could I fix that?

 

You are certain that you are rightclicking a glass block?

 

L33m4n123 Yes, I am positive (well, it's stained, but I never added a check for what block it is.)

 

Hmm thats weird. Maybe just to be sure add an

Code:java

if(e.getAction == RIGHT_CLICK_BLOCK) {
// your code
}

arround it. Since this is working for me without any issues

Code:java

@EventHandler
public void interact(PlayerInteractEvent e) {
if (e.getAction() == Action.RIGHT_CLICK_BLOCK) {
e.getPlayer().sendMessage(e.getClickedBlock().toString());
}
}

so it gets the clickedBlock without any issues

 

L33m4n123 That's basicly what I have:

Code:java

@EventHandler
    public void onInteract(PlayerInteractEvent e)
    {
        Player p = e.getPlayer();
        if(e.getAction().equals(Action.RIGHT_CLICK_AIR) || e.getAction().equals(Action.RIGHT_CLICK_BLOCK))
        {
            if(p.getItemInHand().getType().equals(Material.FIREBALL))
            {
                if(plugin.getDemo().contains(p.getName()))
                {
                    e.setCancelled(true);
                    final Item i = p.getLocation().getWorld().dropItemNaturally(p.getLocation(), new ItemStack(Material.FIREBALL));
                    i.setVelocity(new Vector(p.getVelocity().getX(), p.getVelocity().getY() + 4, p.getVelocity().getZ()));
                    i.setVelocity(p.getLocation().getDirection());
                    i.setPickupDelay(100000);
                    if(p.getItemInHand().getAmount() == 1)
                    {
                        p.setItemInHand(null);
                    }
                    else
                    {
                        p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                    }
                    Bukkit.getScheduler().runTaskLater(plugin, new Runnable()
                    {
                        public void run()
                        {
                            i.getWorld().createExplosion(i.getLocation(), 2, false);
                            i.remove();
                        }
                    }, 100L);
                }
            }
        }
        else if(e.getAction().equals(Action.RIGHT_CLICK_BLOCK))
        {
            if(p.getItemInHand().getType().equals(Material.STONE_PLATE))
            {
                if(plugin.getDemo().contains(p.getName()))
                {
                    if(e.getClickedBlock() != null && e.getClickedBlock().getType() != null)
                    {
                        Location u = new Location(e.getClickedBlock().getWorld(), e.getClickedBlock().getLocation().getX(), e.getClickedBlock().getLocation().getY() + 1, e.getClickedBlock().getLocation().getZ());
                        plate.add(u);
                        u.getBlock().setType(Material.STONE_PLATE);
                        if(p.getItemInHand().getAmount() == 1)
                        {
                            p.setItemInHand(null);
                        }
                        else
                        {
                            p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                        }
                        p.sendMessage("You create a land mine! Punch it to remove it!");
                    }
                }
            }
        }
        else if(e.getAction().equals(Action.PHYSICAL))
        {
            if(e.getClickedBlock().getType().equals(Material.STONE_PLATE))
            {
                if(plate.contains(e.getClickedBlock().getLocation()))
                {
                    if(!(plugin.getDemo().contains(p.getName())))
                    {
                        e.getClickedBlock().setType(Material.AIR);
                        plate.remove(e.getClickedBlock().getLocation());
                        e.getClickedBlock().getWorld().createExplosion(e.getClickedBlock().getLocation(), 2, false);
                    }
                }
            }
        }
    }

 

sgavster

Remove the "e.getAction().equals(Action.RIGHT_CLICK_AIR) || "

 

zeeveener .. I need that?....
If you look at the code, the code that I need help with has

Code:java

else if(e.getAction().equals(Action.RIGHT_CLICK_BLOCK))

 

Why? If you are placing a block on grass, you aren't clicking air.

Edit: Nevermind...

 

zeeveener look at the edited post.. And actually look at the code

 

sgavster

Oh I see. You aren't getting called because it's already been called for the fireball method.
The fact that you use an OR means that if ANY of the two are true, enter, otherwise don't. When you click the ground OR air, you are entering the fireball section. You never touch the "else if" for the problem code.

 

zeeveener It should be

Code:java

if(air || block) {
do my fireball
} else if(block) {
dont do fireball do bomb
}

But, why is it not doing that? Is there a fix?
EDIT: I see what you mean.. I'll just make a new event?

 

sgavster

As soon as the program enters the if statement, which is always in this case, it skips the else's. You can try merging the two blocks of code.

Code:java

if(air || block){
if(fireball){}
else if(other){}
}

You should check the Item in hand first, THEN check if it's via block or air or both. That is what I would do.

 

Just simply because it cannot be done the way you did it

Because if you click Air OR a block it will do your fireball but under no circumstance goes in your else if statement. [Look at else-if statements and bollean logics if you don't get it].

So you would need to check somewhere in your first if-statement if you rightclicked a block and that block is a glass block and you got a pressureplate in the hand do not do fireball but do your pressureplate

 

L33m4n123 zeeveener I made a new event, and it still doesn't work. I have no idea why..

Code:java

    @EventHandler
    public void onCreate(PlayerInteractEvent e)
    {
        Player p = e.getPlayer();
        if(e.getAction().equals(Action.RIGHT_CLICK_BLOCK))
        {
            if(p.getItemInHand().getType().equals(Material.STONE_PLATE))
            {
                if(plugin.getDemo().contains(p.getName()))
                {
                    if(e.getClickedBlock() != null && e.getClickedBlock().getType() != null)
                    {
                        Location u = new Location(e.getClickedBlock().getWorld(), e.getClickedBlock().getLocation().getX(), e.getClickedBlock().getLocation().getY() + 1, e.getClickedBlock().getLocation().getZ());
                        plate.add(u);
                        u.getBlock().setType(Material.STONE_PLATE);
                        if(p.getItemInHand().getAmount() == 1)
                        {
                            p.setItemInHand(null);
                        }
                        else
                        {
                            p.getItemInHand().setAmount(p.getItemInHand().getAmount() - 1);
                        }
                        p.sendMessage("You create a land mine! Punch it to remove it!");
                    }
                }
            }
        }
    }

 

sgavster

Set a test print at the beginning of each if() block. That will let you know where it stops.
Example: Increment the value for each statement but use "System.out.println("TEST1");"

 

zeeveener For some reason, it doesn't trigger.. At all.. It doesn't even say "1" which is after if(e.getAction() blah blag)
Yes, events are registered AND there is @EventHandler :/

 

sgavster

Can you show me where you registered the event?
Also, try putting one of the test prints above the Player p line. See if the event is getting fired at all and it's not something with the getAction() method.