Solved Performance/RAM cost while searching blocks

Some of my plugin users are getting a lot of outOfMemoryMessages even with 3gb RAM being used (I think) @ 333x333 area.

My block search code is:

Code:java

 int blockxmin = Math.min(corner1.getBlockX(), corner2.getBlockX()),
blockxmax = Math.max(corner1.getBlockX(), corner2.getBlockX()),
blockymin = Math.min(corner1.getBlockY(), corner2.getBlockY()),
blockymax = Math.max(corner1.getBlockY(), corner2.getBlockY()),
blockzmin = Math.min(corner1.getBlockZ(), corner2.getBlockZ()),
blockzmax = Math.max(corner1.getBlockZ(), corner2.getBlockZ());
for (int x = blockxmin; x <= blockxmax; x++) {
for (int y = blockymin; y <= blockymax; y++) {
for (int z = blockzmin; z <= blockzmax; z++) {
Block b = corner1.getWorld().getBlockAt(x, y, z);
chunks.add(corner1.getWorld().getChunkAt(x, z)); // Yep, I noticed now that this is wrong
if ((b.getState() instanceof Chest || b.getState() instanceof DoubleChest)) {
if (!chests.containsKey(b.getLocation())) {
chests.put(b.getLocation(), pl.defaultTier.getTier());
}
}
}
}
}

Do anyone know if theres a more effective way to do this?

Also, can someone answer if doing this is more RAM efficient?

Code:java

 int xmin = Math.min(corner1.getChunk().getX(), corner2.getChunk().getX()),
xmax = Math.max(corner1.getChunk().getX(), corner2.getChunk().getX()),
zmin = Math.min(corner1.getChunk().getZ(), corner2.getChunk().getZ()),
zmax = Math.max(corner1.getChunk().getZ(), corner2.getChunk().getZ());
for (int x = xmin; x <= xmax; x++) {
for (int z = zmin; z <= zmax; z++) {
chunks.add(corner1.getWorld().getChunkAt(x, z));
// Search all chunk blocks here and check if block state is chest/doublechest
}
}

 

rfsantos1996
A chest is a tile entity. So instead of iterating over all blocks just iterate over all tile entities for the chunk.

 

Wow, I didnt saw "getTileEntities" ;O

Thank you so much!

@EDIT: I used to use Regios from you, I remember fixing a bug that I needed to get fixed fast on GitHub but I never knew how to Pull request so I sent what you should add on your code to fix the issue xD One of my first Java work on Bukkit.