Solved OnPlayerJoin double..

Hello,

I made a code that sends a message to the player when they join, but it is sent 2 times.. I don't know how:

My code:

Code:java

//*Join-Leave Messages*\\
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){
        Player p = event.getPlayer();
        event.setJoinMessage(ChatColor.GOLD + p.getPlayerListName() + ChatColor.GRAY + " has joined the game!");
        p.sendMessage(ChatColor.DARK_GREEN + "" + ChatColor.STRIKETHROUGH + "----------------------------------------------------");
        p.sendMessage(ChatColor.AQUA + "Welcome to the Castle Crystals server!");
        Integer amount = Bukkit.getOnlinePlayers().length;
        p.sendMessage(ChatColor.BLUE + "There are now " + ChatColor.YELLOW + amount + ChatColor.BLUE + " player(s) online!");
        p.sendMessage(ChatColor.DARK_GREEN + "" + ChatColor.STRIKETHROUGH + "----------------------------------------------------");
        if(!p.getPlayer().hasPlayedBefore()){
            Bukkit.broadcastMessage(ChatColor.GREEN + "Welcome to the server " + ChatColor.YELLOW + p.getPlayerListName() + ChatColor.GREEN + "!");
            Firework(event.getPlayer());
        }
    }

Screenshot:

 

AppleMen You have to either create a new if statement if the player has played before, or add a return statement before the if !player.hasPlayedBefore()

 

Can you show me how? I got some errors while trying it :/

 

Add a 10 tick delay to the message. See what happens.

 

Did you register it twice?

 

you run the code one time for every time a player logs in. and then if you add if(!(player.hasPlayedBefore())){
if that is true, it will send the message that you first sent, and then if its true, it will send the other.

Code:java

    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){
 
        Player p = event.getPlayer();
        if(p.hasPlayedBefore()){
          event.setJoinMessage(ChatColor.GOLD + p.getPlayerListName() + ChatColor.GRAY + " has joined the game!");
          p.sendMessage(ChatColor.DARK_GREEN + "" + ChatColor.STRIKETHROUGH + "----------------------------------------------------");
          p.sendMessage(ChatColor.AQUA + "Welcome to the Castle Crystals server!");
          Integer amount = Bukkit.getOnlinePlayers().length;
          p.sendMessage(ChatColor.BLUE + "There are now " + ChatColor.YELLOW + amount + ChatColor.BLUE + " player(s) online!");
          p.sendMessage(ChatColor.DARK_GREEN + "" + ChatColor.STRIKETHROUGH + "----------------------------------------------------");
        } else {
            Bukkit.broadcastMessage(ChatColor.GREEN + "Welcome to the server " + ChatColor.YELLOW + p.getPlayerListName() + ChatColor.GREEN + "!");
            Firework(event.getPlayer());
        }
    }

 

Try out other events and see if they run twice. If so, you must've registered events twice.

 

Nop

Its still duplicating :/

 

Does your plugin have a reload function?

 

No. Do I have to add one?

 

Nope, just reminiscing on a bug I had before. Can you show your main class?

 

Im like 99% sure you registered it twice.
Have you tried (if youre using eclipse) searching for constructor calls? (Select constructor method name with cursor, press Ctrl+Shift+G)

Edit: The other 1% is you have loaded the plugin twice (maybe under a different name? check your plugin folder)

 

AppleMen
Try what I said.. that would answer a lot of things.

 

Code:java

package me.matthijs110.CustomTeleport;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Color;
import org.bukkit.FireworkEffect;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Firework;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.inventory.meta.FireworkMeta;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionEffect;
 
public class Main extends JavaPlugin implements Listener {
 
    public void onEnable(){
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(new Main(), this);
        pm.registerEvents(new ColoredSigns(), this);
        pm.registerEvents(new AutoMessage(), this);
        saveDefaultConfig();
    }
 
    public void Firework(Player player){
        Firework fw = (Firework) player.getWorld().spawnEntity(player.getLocation(), EntityType.FIREWORK);
        FireworkMeta fwmeta = fw.getFireworkMeta();
        FireworkEffect.Builder builder = FireworkEffect.builder();
        builder.withTrail();
        builder.withFlicker();
        builder.withFade(Color.RED);
        builder.withColor(Color.ORANGE);
        builder.withColor(Color.YELLOW);
        builder.withColor(Color.LIME);
        builder.withColor(Color.TEAL);
        builder.withColor(Color.PURPLE);
        builder.withColor(Color.FUCHSIA);
        builder.with(FireworkEffect.Type.BALL);
        fwmeta.addEffects(builder.build());
        fwmeta.setPower(1);
        fw.setFireworkMeta(fwmeta);
    }
 
    ArrayList <String> afkList = new ArrayList <String> ();
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        Player player = (Player) sender;
        Location helploc = new Location(Bukkit.getServer().getWorld("World"), 120, 54, 365);
        Location spawnloc = new Location(Bukkit.getServer().getWorld("World"), 346, 84, 336);
 
        //*Help teleport*\\
        if (sender.hasPermission("server.teleport.help")) {
            if(cmd.getName().equalsIgnoreCase("help")){
                player.teleport(helploc);
                player.sendMessage(ChatColor.AQUA + "Teleported to the Info Wall");
            } else {
                player.sendMessage(ChatColor.WHITE + "Unknown command. Type \"help\" for help");
            }
        }
 
        //*Spawn Location*\\
        if (sender.hasPermission("server.teleport.spawn")) {
            if(cmd.getName().equalsIgnoreCase("spawn")){
                player.sendMessage(ChatColor.GREEN + "Teleporting to spawn..");
                player.teleport(spawnloc);
            }
        }
 
        //*Heal Command*\\
        if (sender.hasPermission("server.heal")) {
            if(cmd.getName().equalsIgnoreCase("heal"))    {
                player.setHealth(20.0);
                player.setFoodLevel(20);
                sender.sendMessage(ChatColor.GREEN + "You have been healted!");
            }
            for (PotionEffect effect : player.getActivePotionEffects())
            {
                player.removePotionEffect(effect.getType());
            }
            if (sender.hasPermission("server.heal.other")) {
                Player target = Bukkit.getServer().getPlayer(args[0]);
                if (target != null) {
                    target.setHealth(20.0);
                } else {
                    sender.sendMessage(ChatColor.WHITE + "Unknown command. Type \"help\" for help");
                }
 
                //*Suicide Command*\\
                if (sender.hasPermission("server.suicide")) {
                    if(cmd.getName().equalsIgnoreCase("kill")) {
                        player.setHealth(0.0);
                        sender.sendMessage(ChatColor.DARK_RED + "You committed suicide!");
                        Bukkit.broadcastMessage(ChatColor.GOLD + player.getName() + ChatColor.DARK_AQUA + " Committed suicide");
                    }
                }
 
                //*AFK Command*\\
                if (sender.hasPermission("server.afk"))
                    if (cmd.getName().equalsIgnoreCase("afk")) {
                        if (!afkList.contains(player.getName())) {
                            afkList.add(player.getName());
                            Bukkit.getServer().broadcastMessage(ChatColor.GOLD + player.getName() + ChatColor.GRAY + " is now AFK");
                        } else {
                            afkList.remove(player.getName());
                            Bukkit.getServer().broadcastMessage(ChatColor.GOLD + player.getName() + ChatColor.GRAY + " is no longer AFK");
                        }
                    }
 
                //*Broadcasting*\\
                if(cmd.getName().equalsIgnoreCase("broadcast"))
                {
                    if(sender.isOp() || sender.hasPermission("server.broadcast"))
                    {
                        if(args.length == 0)
                        {
                            sender.sendMessage(ChatColor.YELLOW + "Usage: " + ChatColor.GOLD + "/broadcast" + ChatColor.GREEN + "<message>");
                        }
                        else
                        {
                            String msg = "";
                            for (int i = 0; i < args.length; i++)
                            {
                                msg = msg + args[i] + " ";
                            }
                            {
                                Bukkit.broadcastMessage(ChatColor.translateAlternateColorCodes('&',  msg));
                            }
                        }
                    }
                    else
                    {
                        sender.sendMessage(ChatColor.WHITE + "Unknown command. Type \"help\" for help");
                    }
                }
            }
        }
        return false;
    }
    //*Join-Leave Messages*\\
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){
        Player p = event.getPlayer();
        if(p.hasPlayedBefore()){
            event.setJoinMessage(ChatColor.GOLD + p.getPlayerListName() + ChatColor.GRAY + " has joined the game!");
            p.sendMessage(ChatColor.DARK_GREEN + "" + ChatColor.STRIKETHROUGH + "----------------------------------------------------");
            p.sendMessage(ChatColor.AQUA + "Welcome to the Castle Crystals server!");
            Integer amount = Bukkit.getOnlinePlayers().length;
            p.sendMessage(ChatColor.BLUE + "There are now " + ChatColor.YELLOW + amount + ChatColor.BLUE + " player(s) online!");
            p.sendMessage(ChatColor.DARK_GREEN + "" + ChatColor.STRIKETHROUGH + "----------------------------------------------------");
        } else {
            Bukkit.broadcastMessage(ChatColor.GREEN + "Welcome to the server " + ChatColor.YELLOW + p.getPlayerListName() + ChatColor.GREEN + "!");
            Firework(event.getPlayer());
        }
    }
    @EventHandler
    public void onPlayerQuit(PlayerQuitEvent event){
        Player p = event.getPlayer();
        event.setQuitMessage(ChatColor.GOLD + p.getPlayerListName() + ChatColor.GRAY + " has left the game!");
    }
}[/i]

 

Replace Line 28 with:
pm.registerEvents(this, this);

Dunno if it will solve the problem, but do it anyway...

 

AppleMen
Huge issue there.. You're creating a secondary instance of your plugin class which causes trouble. Do what hellboyPS said.

 

Didn't fixed it :/
https://gist.github.com/matthijs110/aeb7c54af9ac474ad83e

 

AppleMen
Like I asked earlier, do all events in your Main class run twice or just the one listening for the PlayerJoinEvent?

 

one listening for the PlayerJoinEvent

 

What are your other listeners?

 

How you mean?

 

So the PlayerQuitEvent doesn't execute twice as well? Possibly you made a duplicate in your other Listeners?

 

Should I try to make a separate class? For the Message on Join

 

AppleMen
Please read the questions I asked you.

 

Like I asked earlier, do all events in your Main class run twice or just the one listening for the PlayerJoinEvent?

I don't know

 

AppleMen
They do if you register them twice.. Please answer my questions, they're not that hard.

I'm asking you to test out ANY other event besides the PlayerJoinEvent and see if it runs twice just like your PlayerJoinEvent. I'm also asking if you possibly have a duplicate method in another one of your Listeners(and show us the code for those classes).

 

I decided to start over.. So this is my class now: Only the Firwork and Join event!

Code:java

public void Firework(Player player){
        Firework fw = (Firework) player.getWorld().spawnEntity(player.getLocation(), EntityType.FIREWORK);
        FireworkMeta fwmeta = fw.getFireworkMeta();
        FireworkEffect.Builder builder = FireworkEffect.builder();
        builder.withTrail();
        builder.withFlicker();
        builder.withFade(Color.RED);
        builder.withColor(Color.ORANGE);
        builder.withColor(Color.YELLOW);
        builder.withColor(Color.LIME);
        builder.withColor(Color.TEAL);
        builder.withColor(Color.PURPLE);
        builder.withColor(Color.FUCHSIA);
        builder.with(FireworkEffect.Type.BALL);
        fwmeta.addEffects(builder.build());
        fwmeta.setPower(1);
        fw.setFireworkMeta(fwmeta);
    }
 
}

That one doesn't work at all :/

 

AppleMen
What are you doing..?

I'm sorry, but if you can't answer a couple simple questions, we cannot help you.

 

Its just easier for myself. So I have more overview.. So my question now is, how can i get this class to work? Its the only and Main class.

 

AppleMen
I can't answer you until you answer me! Do you think I'm asking questions for the fun of it? Be thankful that I've put up with you not listening this far.