Solved OnJoinEvent spamming 2 messages when i join.

Discussion in 'Plugin Development' started by kayc01, Nov 15, 2015.

Thread Status:
Not open for further replies.
  1. I have no idea why this would spam two times, it never used to and i am starting to think its something not in the onJoinEvent class, like a for loop but how is that possible if the {'s are closed off before the onJoinEvent even starts.

    Here is the code of the onJoin:
    I know, its messy.

    Code:
    @EventHandler
          public void onJoin(PlayerJoinEvent e) {
             
             
                String enablegym1 = getConfig().getString("config.gym1enabled");
                String enable2 = getConfig().getString("config.gym2enabled");
                String enable3 = getConfig().getString("config.gym3enabled");
                String enable4 = getConfig().getString("config.gym4enabled");
                String enable5 = getConfig().getString("config.gym5enabled");
                String enable6 = getConfig().getString("config.gym6enabled");
                String enable7 = getConfig().getString("config.gym7enabled");
                String enable8 = getConfig().getString("config.gym8enabled");
                String enable9 = getConfig().getString("config.gym9enabled");
                String enablegym10 = getConfig().getString("config.gym10enabled");
                String enablegym11 = getConfig().getString("config.gym11enabled");
                String enablegym12 = getConfig().getString("config.gym12enabled");
                String enablegym13 = getConfig().getString("config.gym13enabled");
                String enablegym14 = getConfig().getString("config.gym14enabled");
                String enablegym15 = getConfig().getString("config.gym15enabled");
                String enablegym16 = getConfig().getString("config.gym16enabled");
                String enablegym17 = getConfig().getString("config.gym17enabled");
                String enablegym18 = getConfig().getString("config.gym18enabled");
                String enablegym19 = getConfig().getString("config.gym19enabled");
                String enable20 = getConfig().getString("config.gym20enabled");
                String enable21 = getConfig().getString("config.gym21enabled");
                String enable22 = getConfig().getString("config.gym22enabled");
                String enable23 = getConfig().getString("config.gym23enabled");
                String enable24 = getConfig().getString("config.gym24enabled");
                String enable25 = getConfig().getString("config.gym25enabled");
                String enable26 = getConfig().getString("config.gym26enabled");
                String enable27 = getConfig().getString("config.gym27enabled");
                String enable28 = getConfig().getString("config.gym28enabled");
                String enable29 = getConfig().getString("config.gym29enabled");
                String enable30 = getConfig().getString("config.gym30enabled");
                String enable31 = getConfig().getString("config.gym31enabled");
                String enable32 = getConfig().getString("config.gym32enabled");
                String enablee4 = getConfig().getString("config.e4enabled");
             
            Player p = e.getPlayer();
           
            if (getConfig().getString("config.joinmessage").equals("True")){
                p.sendMessage(ChatColor.GREEN + getConfig().getString("config.joinmessage1"));
                p.sendMessage(ChatColor.BLUE+ getConfig().getString("config.joinmessage2"));
                p.sendMessage(ChatColor.GOLD + getConfig().getString("config.joinmessage3"));
           
            }
         
            if (getConfig().getString("config.scoreboard").equals("True")) {
                p.sendMessage(ChatColor.BLUE + "To disable your Scoreboard, type /gym scoreboard.");
                p.setScoreboard(this.board);
                hashmap.put(p, null);
               
                for (Player online : Bukkit.getOnlinePlayers()) {
                    online.setScoreboard(this.board);
                  }
                if ((getConfig().getString("config.e41stat").equals("Open")) &&
                        (enablee4.equalsIgnoreCase("true"))) {
                        this.e41.setScore(101);
                  }
                if ((getConfig().getString("config.e42stat").equals("Open")) &&
                        (enablee4.equalsIgnoreCase("true"))) {
                        this.e42.setScore(102);
                  }
                if ((getConfig().getString("config.e43stat").equals("Open")) &&
                        (enablee4.equalsIgnoreCase("true"))) {
                        this.e43.setScore(103);
                  }
                if ((getConfig().getString("config.e44stat").equals("Open")) &&
                        (enablee4.equalsIgnoreCase("true"))) {
                        this.e44.setScore(104);
                  }
                if ((getConfig().getString("config.gym1stat").equals("Open")) &&
                  (enablegym1.equalsIgnoreCase("true"))) {
                  this.gym1.setScore(1);
                }
                if ((getConfig().getString("config.gym2stat").equals("Open")) &&
                  (enable2.equalsIgnoreCase("true"))) {
                  this.gym2.setScore(2);
                }
                if ((getConfig().getString("config.gym3stat").equals("Open")) &&
                  (enable3.equalsIgnoreCase("true"))) {
                  this.gym3.setScore(3);
                }
                if ((getConfig().getString("config.gym4stat").equals("Open")) &&
                  (enable4.equalsIgnoreCase("true"))) {
                  this.gym4.setScore(4);
                }
                if ((getConfig().getString("config.gym5stat").equals("Open")) &&
                  (enable5.equalsIgnoreCase("true"))) {
                  this.gym5.setScore(5);
                }
                if ((getConfig().getString("config.gym6stat").equals("Open")) &&
                  (enable6.equalsIgnoreCase("true"))) {
                  this.gym6.setScore(6);
                }
                if ((getConfig().getString("config.gym7stat").equals("Open")) &&
                  (enable7.equalsIgnoreCase("true"))) {
                  this.gym7.setScore(7);
                }
                if ((getConfig().getString("config.gym8stat").equals("Open")) &&
                  (enable8.equalsIgnoreCase("true"))) {
                  this.gym8.setScore(8);
                }
            }
            else {
                //do nothing
            }
           
            if (p.getPlayer().getName().equals("ABkayCkay")) {
                   Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "The PixelmonGym Plugin Dev, " + ChatColor.AQUA + ChatColor.BOLD + "ABkayCkay"+ ChatColor.RESET + ChatColor.GRAY +" has come online!");
                }
               
                for (int i = 1; i <= 32; i++) {
                  if (getConfig().getString("config.gym"+i+"enabled").equalsIgnoreCase("True")) {
                    if (p.hasPermission("gym"+i)) {
                     if (queues.get(i).size() != 0) {
                        p.sendMessage(ChatColor.BLUE + "There are " +queues.get(i).size() + " players in the queue for the " + getConfig().getString("config.gym"+i) + " Gym");
                        p.sendMessage(ChatColor.BLUE + "Type /gym next gym"+i + " when you are ready to start taking battle's.");
                     }
                    }
                  }
                }
               
                if (p.isOp() == true) {
                    //do nothing
                }
                else if (p.getName().equalsIgnoreCase("ABkayCkay")) {
                    //do nothing
                }
                else {
                    if (p.hasPermission("pixelgym.gym1")) {
                        if (enablegym1.equalsIgnoreCase("true")) {
                            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.translateAlternateColorCodes('&', getConfig().getString("config.gym1colour")) + "A " + getConfig().getString("config.gym1") + " Gym Leader has come online!" + " (" + p.getDisplayName() + ")");
                          }
                        }
                        else if (p.hasPermission("pixelgym.gym2"))
                        {
                          if (enable2.equalsIgnoreCase("true")) {
                            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.translateAlternateColorCodes('&', getConfig().getString("config.gym2colour")) + "A " + getConfig().getString("config.gym2") + " Gym Leader has come online!" + " (" + p.getDisplayName() + ")");
                          }
                        }
                        else if (p.hasPermission("pixelgym.gym3"))
                        {
                          if (enable3.equalsIgnoreCase("true")) {
                            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.translateAlternateColorCodes('&', getConfig().getString("config.gym3colour")) + "A " + getConfig().getString("config.gym3") + " Gym Leader has come online!" + " (" + p.getDisplayName() + ")");
                          }
                        }
                        else if (p.hasPermission("pixelgym.gym4"))
                        {
                          if (enable4.equalsIgnoreCase("true")) {
                            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.translateAlternateColorCodes('&', getConfig().getString("config.gym4colour")) + "A " + getConfig().getString("config.gym4") + " Gym Leader has come online!" + " (" + p.getDisplayName() + ")");
                          }
                        }
                        else if (p.hasPermission("pixelgym.gym5"))
                        {
                          if (enable5.equalsIgnoreCase("true")) {
                            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.translateAlternateColorCodes('&', getConfig().getString("config.gym5colour")) + "A " + getConfig().getString("config.gym5") + " Gym Leader has come online!" + " (" + p.getDisplayName() + ")");
                          }
                        }
                        else if (p.hasPermission("pixelgym.gym6"))
                        {
                          if (enable6.equalsIgnoreCase("true")) {
                            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.translateAlternateColorCodes('&', getConfig().getString("config.gym6colour")) + "A " + getConfig().getString("config.gym6") + " Gym Leader has come online!" + " (" + p.getDisplayName() + ")");
                          }
                        }
                        else if (p.hasPermission("pixelgym.gym7"))
                        {
                          if (enable7.equalsIgnoreCase("true")) {
                            Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.translateAlternateColorCodes('&', getConfig().getString("config.gym7colour")) + "A " + getConfig().getString("config.gym7") + " Gym Leader has come online!" + " (" + p.getDisplayName() + ")");
                          }
                        }
                        else if (p.hasPermission("pixelgym.gym8"))
                        {
                          if (enable8.equalsIgnoreCase("true")) {
                          Bukkit.broadcastMessage(ChatColor.DARK_GRAY + "[" + ChatColor.AQUA + getConfig().getString("config.title") + ChatColor.DARK_GRAY + "] " + ChatColor.translateAlternateColorCodes('&', getConfig().getString("config.gym8colour")) + "A " + getConfig().getString("config.gym8") + " Gym Leader has come online!" + " (" + p.getDisplayName() + ")");
                          }
                        }
    
                   
                }
           
        
          }
    My most recent additions or changes that could of caused it?


    Code:
     @EventHandler
          public void onInventoryClick(InventoryClickEvent event) {
             
              if (event.getInventory().getName().equalsIgnoreCase(myInventory.getName())) {
                  event.setCancelled(true);
              }
          }
         
          @EventHandler
            public void onInventoryCloseEvent(InventoryCloseEvent e) {
              if (e.getInventory().getName().equalsIgnoreCase(myInventory.getName())) {
                myInventory.clear();
              }
            }
    In my onCommand:
    Code:
    if ((args[0].equalsIgnoreCase("see") || args[0].equalsIgnoreCase("check")
                            || args[0].equalsIgnoreCase("s"))) {
                       
    
                            if (Bukkit.getPlayer(args[1]) != null) {
                                Player playerBadges = Bukkit.getPlayer(args[1]);
    
                                for (int i = 1; i <= 32; i++) {
                                   
                                    int u = i -1;
                                   
                                if ((settings.getBadge().get("Players." + playerBadges.getUniqueId() + ".Badges.gym"+i) != null)) {
                                    if (settings.getBadge().getString("Players." + playerBadges.getUniqueId() + ".Badges.gym"+i)
                                            .equalsIgnoreCase("Won")) {
                                        if (getConfig().getString("config.gym"+i+"badge") != null) {
                                            myInventory.setItem(u, new ItemStack(Material.getMaterial(getConfig().getInt("config.gym"+i+"badge"))));
                                        }
                                    }
                                }
                            }
                                p.openInventory(myInventory);
                                p.sendMessage(ChatColor.GREEN + "Opening " + playerBadges.getName() + "'s badge showcase!");
                         }
                       
                       
    
                    }
    But i don't see how any of these could affect it as there in totally different methods.
    This is what it looks like when i join a game:

    [​IMG]
     
  2. Offline

    Lounterr

    You can use e.setJoinMessage("message");, but I think you can't use a multiline message then. Otherwise you can use a HashMap to put the online players in and check if the player is in it.
     
  3. Well, i never had an issue before. But now it spams it 2 times for no reason.
    :/

    I'm not sure what made the change because it used to work fine.
     
  4. Offline

    Xerox262

    Show us where you register the event? It looks like it was double registered.
    That means constructors of both classes and all of your onEnable method or where ever you registered them
     
  5. You sir are a savior.

    I had two of these:
    getServer().getPluginManager().registerEvents(this, this);

    Don't know why, must of been whilst i was coding half asleep.
    Note to self: Never code when half asleep. Lol

    Ill test it when i get the chance, should of fixed it :)
     
    Xerox262 likes this.
Thread Status:
Not open for further replies.

Share This Page