Null pointer exception

Can you provide your full class as it is right now?

 

1Rogue yes here you go for the third time.

Code:java

package me.connor.scoreboard;
 
import java.util.ArrayList;
import java.util.HashMap;
 
import net.milkbowl.vault.economy.Economy;
import net.milkbowl.vault.economy.EconomyResponse;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
 
 
public class KD extends JavaPlugin implements Listener {
public HashMap<String, Scoreboard> UsedScoreboard = new HashMap<String, Scoreboard>();
public HashMap<String, Integer> kills = new HashMap<String, Integer>();
public HashMap<String, Integer> deaths = new HashMap<String, Integer>();
public ArrayList<String> show = new ArrayList<String>();
public Economy econ = null;
 
 
public void onEnable() {
Bukkit.getServer().getPluginManager().registerEvents(this, this);
this.saveConfig();
 
if (!setupEconomy()) {
getLogger().severe(ChatColor.RED + "Economy disabled due to no Vault dependency found!");
return;
}
 
for(Player p : Bukkit.getServer().getOnlinePlayers()) {
serverReload(p);
}
}
 
public void onDisable() {
for(Player p : this.getServer().getOnlinePlayers()) {
this.getConfig().set(p.getName() + ".kills", kills.get(p.getName()));
this.getConfig().set(p.getName() + ".deaths", deaths.get(p.getName()));
}
this.saveConfig();
}
 
private boolean setupEconomy() {
if (getServer().getPluginManager().getPlugin("Vault") == null) {
return false;
}
RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
if (rsp == null) {
return false;
}
econ = rsp.getProvider();
return econ != null;
}
 
public void serverReload(Player p) {
//recreate hashmaps
 
getKills(p);
getDeaths(p);
setScoreboard(p);
show.add(p.getName());
}
 
public void setScoreboard(Player p) {
ScoreboardManager manager = Bukkit.getScoreboardManager();
Scoreboard board = manager.getNewScoreboard();
//economy enabled from config
boolean EconomyEnabled = this.getConfig().getBoolean("Economy.enabled");
 
Objective objective = board.registerNewObjective("score", "dummy");
objective.setDisplayName(this.getConfig().getString("ScoreboardName"));
objective.setDisplaySlot(DisplaySlot.SIDEBAR);
 
Score killsScore = objective.getScore(Bukkit.getOfflinePlayer(ChatColor.BLUE + "Kills:")); //Get a fake offline player
Score deathsScore = objective.getScore(Bukkit.getOfflinePlayer(ChatColor.RED + "Deaths:")); //Get a fake offline player
 
killsScore.setScore(kills.get(p.getName()));
deathsScore.setScore(deaths.get(p.getName()));
 
if(EconomyEnabled == true) {
try{
Score moneyScore = objective.getScore(Bukkit.getOfflinePlayer(ChatColor.GREEN + "Balance:"));
moneyScore.setScore((int) getMoney(p));
} catch(Exception ex) {
getLogger().severe("Economy disabled due to no Vault dependency found!");
this.getConfig().set("Economy.enabled", false);
setScoreboard(p);
}
}
 
p.setScoreboard(board);
}
 
public void resetScoreboard(Player p) {
ScoreboardManager manager = Bukkit.getScoreboardManager();
 
p.setScoreboard(manager.getNewScoreboard());
}
 
public HashMap<String, Integer> getKills(Player p) {
try {
kills.put(p.getName(), this.getConfig().getInt(p.getName() + ".kills"));
}
catch (Exception ex) {
kills.put(p.getName(), 0);
this.getConfig().set(p.getName() + ".kills", kills.get(p.getName()));
this.saveConfig();
return kills;
}
 
return kills;
}
 
public HashMap<String, Integer> getDeaths(Player p) {
try {
deaths.put(p.getName(), this.getConfig().getInt(p.getName() + ".deaths"));
}
catch (Exception ex) {
deaths.put(p.getName(), 0);
this.getConfig().set(p.getName() + ".deaths", deaths.get(p.getName()));
this.saveConfig();
return deaths;
}
 
return deaths;
}
 
public double getMoney(Player p) {
Double money = this.econ.getBalance(p.getName());
return money;
}
 
@EventHandler
public void onJoin(PlayerJoinEvent e) {
Player p = e.getPlayer();
getKills(p);
getDeaths(p);
setScoreboard(p);
show.add(p.getName());
}
 
@EventHandler
public void onPlayerDeath(PlayerDeathEvent e) {
Player p = e.getEntity();
 
if(p.getKiller() instanceof Player){
Player k = p.getKiller();
 
int currentKills = kills.get(k.getName());
currentKills++;
 
kills.put(k.getName(), currentKills);
 
this.getConfig().set(k.getName() + ".kills", kills.get(k.getName()));
 
try {
double reward = this.getConfig().getDouble("Economy.reward");
EconomyResponse r = this.econ.depositPlayer(k.getName(), reward);
if(r.transactionSuccess()) {
k.sendMessage(ChatColor.AQUA + "You got $" + reward + " for killing " + p.getName());
}
} catch(Exception ex) {
 
} finally {
 
if(show.contains(k.getName())) {
setScoreboard(k);
}
}
}
 
int currentDeaths = deaths.get(p.getName());
currentDeaths++;
 
deaths.put(p.getName(), currentDeaths);
 
setScoreboard(p);
 
this.getConfig().set(p.getName() + ".deaths", deaths.get(p.getName()));
this.saveConfig();
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
if(cmd.getName().equalsIgnoreCase("sb")) {
if(!(sender instanceof Player)) {
sender.sendMessage(ChatColor.RED + "Only players can use scoreboard!");
return true;
}
 
if(args.length == 0) {
sender.sendMessage(ChatColor.RED + "Usage: /sb hide/show");
return true;
}
 
//define player
Player p = (Player) sender;
 
if(args[0].equalsIgnoreCase("hide")) {
show.remove(p.getName());
resetScoreboard(p);
return true;
}
 
if(args[0].equalsIgnoreCase("show")) {
show.add(p.getName());
setScoreboard(p);
return true;
}
 
}
 
 
return true;
}
}
 

Errors

Code:

Could not pass PlayerDeathEvent...
 
Null Pointer Exception on line 188

edit- sorry accidently posted old version. New one is here.

 

Code:java

public void serverReload(Player p) {
//recreate hashmaps
kills = new HashMap<String, Integer>();
deaths = new HashMap<String, Integer>();
 
getKills(p);
getDeaths(p);
setScoreboard(p);
show.add(p.getName());
}

Code:java

kills = new HashMap<String, Integer>();
deaths = new HashMap<String, Integer>();

Here you go for the sixth time:

 

1Rogue still doesn't work and i changed the code that i posted i accidently posted old code.

 

Alright then, can I have your current code?

 

1Rogue yes i edited the post it has the new code. BTW thanks for sticking through this with me.

 

In your serverReload() method, verify the players in them:

Code:java

Integer death = deaths.get(p.getName());
if (death == null) {
    deaths.put(p.getName(), 0);
}

Do the same for kills.

 

Solved?

 

1Rogue still not working

 

Then what is your current .serverReload() method as it is written right now?

Edit: and your onEnable.

 

1Rogue
onEnable

Code:java

public void onEnable() {
Bukkit.getServer().getPluginManager().registerEvents(this, this);
this.saveConfig();
 
if (!setupEconomy()) {
getLogger().severe(ChatColor.RED + "Economy disabled due to no Vault dependency found!");
return;
}
 
for(Player p : Bukkit.getServer().getOnlinePlayers()) {
serverReload(p);
}
}

serverReload

Code:java

public void serverReload(Player p) {
getKills(p);
getDeaths(p);
 
if(kills.get(p.getName()) == null) {
kills.put(p.getName(), 0);
}
 
if(deaths.get(p.getName()) == null) {
deaths.put(p.getName(), 0);
}
 
setScoreboard(p);
show.add(p.getName());
}

 

Your .getDeaths() and .getKills() method is a bit incorrect as well:

Before:

Show Spoiler Hide Spoiler

Code:java

public HashMap<String, Integer> getDeaths(Player p) {
try {
deaths.put(p.getName(), this.getConfig().getInt(p.getName() + ".deaths"));
}
catch (Exception ex) {
deaths.put(p.getName(), 0);
this.getConfig().set(p.getName() + ".deaths", deaths.get(p.getName()));
this.saveConfig();
return deaths;
}
 
return deaths;
}

After:

Code:java

public int getDeaths(Player p) {
    Integer deaths = this.deaths.get(p.getName());
    if (deaths == null) {
        Integer newDeaths = this.getConfig().getInt(p.getName() + ".deaths");
        if (deaths == null || deaths == 0) {
            deaths.put(p.getName(), 0);
            this.getConfig().set(p.getName() + ".deaths", 0);
            this.saveConfig();
            return 0;
        } else {
            deaths.put(p.getName(), deaths);
        }
        return newDeaths;
    }
    return deaths;
}

Same idea for kills as well. From there, you can simply call:

Code:java

int deaths = getDeaths(p.getName());

 

Use this code:

Code:

package me.connor.scoreboard;
 
import java.util.ArrayList;
import java.util.HashMap;
 
import net.milkbowl.vault.economy.Economy;
import net.milkbowl.vault.economy.EconomyResponse;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.Configuration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerKickEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
 
public class KD extends JavaPlugin implements Listener {
   
    public HashMap<String, Scoreboard> UsedScoreboard = new HashMap<String, Scoreboard>();
    public HashMap<String, Integer> kills = new HashMap<String, Integer>();
    public HashMap<String, Integer> deaths = new HashMap<String, Integer>();
    public ArrayList<String> show = new ArrayList<String>();
    public Economy econ = null;
    Configuration config;
 
    ///////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
   
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(this, this);
        this.saveConfig();
        config = getConfig();
 
        if (!setupEconomy()) {
            getLogger().severe(ChatColor.RED + "Economy disabled due to no Vault dependency found!");
            return;
        }
 
        for (Player p : Bukkit.getOnlinePlayers()){
            loadPlayerStats(p);
            setScoreboard(p);
            show.add(p.getName());
        }
    }
   
    ///////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    private void loadPlayerStats(Player p) {
        String pname = p.getName();
       
        if (config.contains(pname + ".kills")){
            kills.put(pname, config.getInt(pname + ".kills"));
        }
        if (config.contains(pname + ".deaths")){
            deaths.put(pname, config.getInt(pname + ".deaths"));
        }
       
    }
 
    //////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
   
    public void onDisable() {
        for (Player p : Bukkit.getOnlinePlayers()){
            savePlayerStats(p);
        }
    }
   
    ///////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    private void savePlayerStats(Player p) {
        String pname = p.getName();
       
        if (kills.containsKey(pname)){
            config.set(pname + ".kills", getKills(p));
            saveConfig();
            kills.remove(pname);
        }
        if (deaths.containsKey(pname)){
            config.set(pname + ".deaths", getDeaths(p));
            saveConfig();
            deaths.remove(pname);
        }
    }
 
    /////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
   
    private boolean setupEconomy() {
        if (getServer().getPluginManager().getPlugin("Vault") == null) {
            return false;
        }
        RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
        if (rsp == null) {
            return false;
        }
        econ = rsp.getProvider();
        return econ != null;
    }
 
    /////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
   
    public void setScoreboard(Player p) {
        ScoreboardManager manager = Bukkit.getScoreboardManager();
        Scoreboard board = manager.getNewScoreboard();
        // economy enabled from config
        boolean EconomyEnabled = this.getConfig().getBoolean("Economy.enabled");
 
        Objective objective = board.registerNewObjective("score", "dummy");
        objective.setDisplayName(this.getConfig().getString("ScoreboardName"));
        objective.setDisplaySlot(DisplaySlot.SIDEBAR);
 
        Score killsScore = objective.getScore(Bukkit.getOfflinePlayer(ChatColor.BLUE + "Kills:")); // Get a fake offline player
        Score deathsScore = objective.getScore(Bukkit.getOfflinePlayer(ChatColor.RED + "Deaths:")); // Get a fake offline player
 
        killsScore.setScore(getKills(p));
        deathsScore.setScore(getDeaths(p));
 
        if (EconomyEnabled == true) {
            try {
                Score moneyScore = objective.getScore(Bukkit.getOfflinePlayer(ChatColor.GREEN + "Balance:"));
                moneyScore.setScore((int) getMoney(p));
            } catch (Exception ex) {
                getLogger().severe("Economy disabled due to no Vault dependency found!");
                this.getConfig().set("Economy.enabled", false);
                setScoreboard(p);
            }
        }
 
        p.setScoreboard(board);
    }
   
    ///////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    public void resetScoreboard(Player p) {
        ScoreboardManager manager = Bukkit.getScoreboardManager();
        p.setScoreboard(manager.getNewScoreboard());
    }
   
    /////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    public int getDeaths(Player p) {
       
        if (deaths.containsKey(p.getName())){
            return deaths.get(p.getName());
        }else{
            return 0;
        }
       
    }
   
    /////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    public int setDeaths(Player p, int amount) {
        deaths.put(p.getName(), amount);
    }
   
    /////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    public int getKills(Player p) {
       
        if (kills.containsKey(p.getName())){
            return kills.get(p.getName());
        }else{
            return 0;
        }
       
    }
   
    /////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    public int setKills(Player p, int amount) {
        kills.put(p.getName(), amount);
    }
   
    ////////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    public double getMoney(Player p) {
        Double money = this.econ.getBalance(p.getName());
        return money;
    }
 
    ///////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
   
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        loadPlayerStats(p);
        setScoreboard(p);
        show.add(p.getName());
    }
   
    ///////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
   
    @EventHandler
    public void onQuit(PlayerQuitEvent e) {
        Player p = e.getPlayer();
        savePlayerStats(p);
    }
   
    ///////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
   
    @EventHandler
    public void onKick(PlayerKickEvent e) {
        Player p = e.getPlayer();
        savePlayerStats(p);
    }
   
    ///////////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent e) {
        Player p = e.getEntity();
 
        if (p.getKiller() instanceof Player) {
            Player k = p.getKiller();
 
            setKills(k, getKills(k) + 1);
 
            try {
                double reward = this.getConfig().getDouble("Economy.reward");
                EconomyResponse r = this.econ.depositPlayer(k.getName(), reward);
                if (r.transactionSuccess()) {
                    k.sendMessage(ChatColor.AQUA + "You got $" + reward + " for killing " + p.getName());
                }
            } catch (Exception ex) {
 
            } finally {
 
                if (show.contains(k.getName())) {
                    setScoreboard(k);
                }
            }
        }
 
        setDeaths(p, getDeaths(p));
 
        setScoreboard(p);
    }
   
    ///////////////////////////////////////////////////////////////////////////////////////
    ///////////////////////////////////////////////////////////////////////////////////////
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        if (cmd.getName().equalsIgnoreCase("sb")) {
            if (!(sender instanceof Player)) {
                sender.sendMessage(ChatColor.RED + "Only players can use scoreboard!");
                return true;
            }
 
            if (args.length == 0) {
                sender.sendMessage(ChatColor.RED + "Usage: /sb hide/show");
                return true;
            }
 
            // define player
            Player p = (Player) sender;
 
            if (args[0].equalsIgnoreCase("hide")) {
                show.remove(p.getName());
                resetScoreboard(p);
                return true;
            }
 
            if (args[0].equalsIgnoreCase("show")) {
                show.add(p.getName());
                setScoreboard(p);
                return true;
            }
 
        }
 
        return true;
    }
}

 

the_merciless doesn't work just sets everything to 0

1Rogue This doesn't work because you are trying to input into an Integer not a hashmap which isn't possible and im a little confused about it. It seems like it will prevent errors, but i don't think it will get the correct deathes of the player. Correct me if i'm wrong.

 

It will get the deaths of the player from the hashmap. If hashmap has no entry / a null entry, then it will get it from the config. If the config's entry is null / non-existant, it will set it as 0 and return 0.

I don't know what you mean by "putting into an integer, not a hashmap". If you mean the return value, it has nothing to do with the hashmap you use.

 

There's no reason that my code should not work as intended. (As far as I can see) perhaps your death event is being cancelled by another plugin. Try setting the event priority higher

@EventHandler(priority = EventPriority.HIGH)
Public void onPlayerDeath.....

(Ignore what's in the config during gameplay. It will only update the config when you log out or shut down the server)

 

the_merciless it kinda works except when the server is reloaded every time a player dies it is returning null so it always sets the kills and deaths to 0. I just wanna know why it is returning null when there is a valid value available.

 

When you say its returning null do you mean your getting an npe? if so show us it.

 

the_merciless No it doesn't throw an NPE but it is returning null and when the code receives null it sets kills or deaths to 0.