Solved [Now found a possible bug] Removing only 1 consumable item out of a itemstack

lewysryan The exact code i pasted into the forums should work. And i see that you are using == (which can get mistaken sometimes)

On line 12 change ">=" to ">"

 

Goblom still get stuck on one :/

Code:java

@EventHandler
    public void onPlayerInteractCookie(PlayerInteractEvent event) {
        if ((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK)) {
            Player player = event.getPlayer();
            ItemStack handItem = player.getItemInHand();
 
            if (handItem.getType().equals(Material.COOKIE)) {
                if (player.hasPermission("arrow.powerup")) {
                    player.setFoodLevel(20);
                    player.sendMessage(ChatColor.GRAY+" ["+ ChatColor.AQUA + "Explosive PvP" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You used InstantFood power up!");
 
                    if (handItem.getAmount() > 2) handItem.setAmount(handItem.getAmount() - 1);
                    else player.getInventory().remove(handItem);
 
                    player.updateInventory();
                }
            }
        }
    }

 

line 2 & 13 change to this...

Code:java

if (handItem.getAmount() == 1) player.getInventory.remove(handItem);
else if (handItem.getAmount() > 2) handItem.setAmount(handItem.getAmount() - 1);
else player.getInventory().remove(handItem);

If that doesnt work, replace every "handItem" in this code from this post to "player.getItemInHand()"

 

Goblom

now it dont remove the last two. code:

Code:java

@EventHandler
    public void onPlayerInteractCookie(PlayerInteractEvent event) {
        if ((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK)) {
            Player player = event.getPlayer();
            ItemStack handItem = player.getItemInHand();
 
            if (handItem.getType().equals(Material.COOKIE)) {
                if (player.hasPermission("arrow.powerup")) {
                    player.setFoodLevel(20);
                    player.sendMessage(ChatColor.GRAY+" ["+ ChatColor.AQUA + "Explosive PvP" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You used InstantFood power up!");
 
                    if (handItem.getAmount() == 1) player.getInventory().remove(handItem);
                    else if (handItem.getAmount() > 2) handItem.setAmount(handItem.getAmount() - 1);
                    else player.getInventory().remove(handItem);
 
                    player.updateInventory();
                }
            }
        }
    }

 

lewysryan

 

Goblom did that to: Sorry was updating my post as u posted that lol

Code:java

@EventHandler
    public void onPlayerInteractCookie(PlayerInteractEvent event) {
        if ((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK)) {
            Player player = event.getPlayer();   
            if (player.getItemInHand().getType().equals(Material.COOKIE)) {
                if (player.hasPermission("arrow.powerup")) {
                    player.setFoodLevel(20);
                    player.sendMessage(ChatColor.GRAY+" ["+ ChatColor.AQUA + "Explosive PvP" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You used InstantFood power up!");
 
                    if (player.getItemInHand().getAmount() == 1) player.getInventory().remove(player.getItemInHand());
                    else if (player.getItemInHand().getAmount() > 2) player.getItemInHand().setAmount(player.getItemInHand().getAmount() - 1);
                    else player.getInventory().remove(player.getItemInHand());
 
                    player.updateInventory();
                }
            }
        }
    }

 

lewysryan :/ I'm sorry, i am drawing a blank. If it doesn't work yet then i don't know what to do. My best suggestion is to keep playing around with it and see if something works

 

God dam Bukkit is it really this hard to just remove one item from a itemstack? Thanks Goblom anyway Anyone Else got a answer for this?

 

After some debugging, I discovered that there is literally no way to remove just the singular cookie from the hand. It fails the if statement in all the ways, shapes, or forms I have tried:

Code:

if(handItem.getAmount == 1): false;
if(handItem.getAmount <= 1): false;
if(handItem.equals(new ItemStack(Material.COOKIE, 1)): false;

Though, strangely enough, it somehow passes the if statement. I added a return statement after all of these and it never got to the message, which I put after this code. So, I don't know. This is impossible.

 

Drkmaster83

really. it works with balzerods and paper but not cookies :/

i used this for paper and it worked but not for cookies:

Code:

@EventHandler(priority = EventPriority.NORMAL)
    public void onPlayerInteractBandage(PlayerInteractEvent event) {
        if ((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK)) {
        Player p = event.getPlayer();
        if(p.getItemInHand().getType() == Material.PAPER) {
            if(p.hasPermission("arrow.powerup"));
            p.setHealth(20);
            p.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION,120,1));
            p.sendMessage(ChatColor.GRAY+" ["+ ChatColor.AQUA + "Explosive PvP" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You used the Bandage power up!");
            PlayerInventory pi = p.getInventory();
            ItemStack Paper = new ItemStack(Material.PAPER, 1);
            pi.removeItem(Paper);
            pi.remove(new ItemStack(Material.PAPER, 1));
        }
    }
}

Well this sucks ;( Thanks all

 

Drkmaster83 It looks like you might have found a bug... post it on http://leaky.bukkit.org

 

I hope it is a bug and it does get sorted. guess instant food power up is going to have to be a bone. this works with a bone:

Code:

@EventHandler
    public void onPlayerInteractCookie(PlayerInteractEvent event) {
        if ((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK)) {
            Player player = event.getPlayer(); 
            if (player.getItemInHand().getType().equals(Material.BONE)) {
                if (player.hasPermission("arrow.powerup")) {
                    player.setFoodLevel(20);
                    player.sendMessage(ChatColor.GRAY+" ["+ ChatColor.AQUA + "Explosive PvP" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You used InstantFood power up!");
                    PlayerInventory pi = player.getInventory();
                 
                    ItemStack bone = new ItemStack(Material.BONE, 1);
                    pi.removeItem(bone);
                 
                }
            }
        }
    }

 

Make it bacon!

 

Drkmaster83 dont work with any food ......... well bones are better than nothing wanted cookies though, taste better.

 

Try potions? I'm interested if it's only consumables.

 

Drkmaster83 i will tomorrow i gtg now. ill tag u again on this thread on the outcome. i personally believe its only consumables but not tried that yet so not 100% sure.

 

Atlassian Bukkit Bug Report posted.

 

You have not registered the event try adding Bukkit.getServer().getPluginManager().registerEvents(this, this); under your onEnable
Example.

Code:java

 public void onEnable(){
Bukkit.getServer().getPluginManager().registerEvents(this, this);
 
}

Example

 

I don't think that's the problem...

 

Drkmaster83
This varies I know in my code when I do not register the event it does not work. However I am still fairly new to this, simply attempting to help lewysryan This could be the problem, it might not be, but could.

 

PHP:

    @EventHandler
    public void onInteract(PlayerInteractEvent e)
    {
        Player p = e.getPlayer();
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK)
        {
            if(p.getInventory().contains(Material.COOKIE))
            {
                p.getInventory().removeItem(new ItemStack(Material.COOKIE, 1));
            }
        }
    }

...?

 

I can confirm this bug. It occasionally works with another plugin of mine, and never works in another.
I've received countless complaints by owners I've programmed for and I'm glad its a bukkit problem and not something with my programming

 

And while I recognize that you're fairly new to this (and do respect it as so), I was simply stating that I don't think that's the problem because (if you read all of the posts), the event was being listened to, but it's supposed functions were being improperly performed.

EDIT: Glad to hear it, number1_Master Now I know that I'm not going crazy!

 

I see, lol I did not see it was being listened to. Sorry mate, I was not trying to say that you did not know what you were doing I was also stating what I thought could be the problem. Maybe I will have to attempt to fix the code myself (just to see if I can). Anyway Sorry for the inconvenience.

 

achap1989 if you can that will be great but i think its impossible // bug pointed out by Drkmaster83 And yes i did register the events. Thanks for your help though!

 

lewysryan Drkmaster83 it appears it is only when you are removing the item in hand. If for instance, I use the cookie to remove a bone each time I right click with a cookie it will remove every single bone and change the last bone to air. However if I change the if player is holding a cookie statement back to bone it will not remove all of the bones.

So for some reason you may only remove an item that you are not holding, otherwise it will not remove the last item.
Code that removes all of the bones.

Code:java

    @EventHandler
    public void onPlayerInteractCookie(PlayerInteractEvent event) {
        if ((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK)) {
            Player player = event.getPlayer();
            if (player.getItemInHand().getType().equals(Material.COOKIE)) {
                if (player.hasPermission("arrow.powerup")) {
                    player.setFoodLevel(20);
                    player.sendMessage(ChatColor.GRAY+" ["+ ChatColor.AQUA + "Explosive PvP" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You used InstantFood power up!");
                    PlayerInventory pi = player.getInventory();
 
                    ItemStack bone = new ItemStack(Material.BONE, 1);
                    pi.removeItem(bone);
 
                }
            }
        }
}

Code the will keep the last bone

Code:java

    @EventHandler
    public void onPlayerInteractCookie(PlayerInteractEvent event) {
        if ((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK)) {
            Player player = event.getPlayer();
            if (player.getItemInHand().getType().equals(Material.BONE)) {
                if (player.hasPermission("arrow.powerup")) {
                    player.setFoodLevel(20);
                    player.sendMessage(ChatColor.GRAY+" ["+ ChatColor.AQUA + "Explosive PvP" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You used InstantFood power up!");
                    PlayerInventory pi = player.getInventory();
 
                    ItemStack bone = new ItemStack(Material.BONE, 1);
                    pi.removeItem(bone);
 
                }
            }
        }
}

 

achap1989 its the same ....

 

Code:java

//First code
 
if (player.getItemInHand().getType().equals(Material.COOKIE)) {
 
//second code
 
if player.getItemInHand().getType().equals(Material.BONE)) {

 

achap1989 now i feel stupid i use this now.

Code:java

public ItemStack getInstantFood() {
        ItemStack Ifood = new ItemStack(Material.BONE, 1);
        ItemMeta meta = Ifood.getItemMeta();
        meta.setDisplayName(ChatColor.AQUA + "Instant Food");
        List<String> lore = new ArrayList<String>();
        lore.add(ChatColor.GREEN + "Description:");
        lore.add(ChatColor.LIGHT_PURPLE + "Instantly eat the Bone");
        lore.add(ChatColor.LIGHT_PURPLE + "Fills your food bar completely");
        lore.add(ChatColor.GREEN + "Price:");
        lore.add(ChatColor.LIGHT_PURPLE + "$10");
        meta.setLore(lore);
        Ifood.setItemMeta(meta);
        return Ifood;
    }
 
@EventHandler
public void onPlayerInteractBone(PlayerInteractEvent event) {
if ((event.getAction() == Action.RIGHT_CLICK_AIR) || (event.getAction() == Action.RIGHT_CLICK_BLOCK)) {
        Player player = event.getPlayer(); 
        if (player.getItemInHand().getType().equals(Material.BONE)) {
            if (player.hasPermission("arrow.powerup")) {
                player.setFoodLevel(20);
                player.sendMessage(ChatColor.GRAY+" ["+ ChatColor.AQUA + "Explosive PvP" + ChatColor.GRAY + "]" + ChatColor.GREEN + " You used InstantFood power up!");
                PlayerInventory pi = player.getInventory();
     pi.removeItem(getInstantFood());
            } 
        }
    }
 
}
 
 

would not remove the bone if i gave them the instant food item stack and removed the material.bone // item stack bone though. same material?

 

lewysryan um, what? Haha, well I still went ahead and make you a power up if you want to use it.

You of course would still need to add the permission if statement, but this is just a solution I came up with until the bug was fixed.

Code:java

 @EventHandler
public void onFoodLevelChange(PlayerItemConsumeEvent event) {
Player p = event.getPlayer();
if (p.getItemInHand().getType() == Material.COOKIE) {
p.setFoodLevel(20);
p.sendMessage(ChatColor.GREEN + "Powered up!");
}
}
 
//This portion can be removed this only uses a stick to set hunger to 0 to test program
@EventHandler
public void onPlayerInteract(PlayerInteractEvent event) {
Player p = event.getPlayer();
if (p.getItemInHand().getType() == Material.STICK) {
if (event.getAction() == Action.RIGHT_CLICK_BLOCK) {
p.setFoodLevel(0);
}
}
}