Solved Need help with saving Locations.

So I made a plugin, where you would type a command, right click on a block, and the block that I clicked on gets added to a Location ArrayList.
Ok cool, everything works, but i need a way to save those locations to a file, for an example .dat file.
I have this:

Code:java

public ArrayList<Location> blockloc = new ArrayList<Location>();

Is there a way i can save blockloc to a .dat file, and then load it again? If so, please help!

 

You can use a custom .yml file. Here is an explanation on how to create and use a custom .yml file to store data.
Especially have a look at the section "Arbitrary Configurations".

 

CubieX
Did you even read my post?
I'm trying to save a bunch of locations in an ArrayList into a .dat or .data file, so that users wont be able to mess up the locations.
And I also need a way to load location data from a .dat/.data file and set them to an ArrayList.

 

Why are you so stuck on .dat files? YAML is built into the API for us to save our plugin's data to..

 

@BillyGalbreath
1. If I were to use YAML, then users would be able to mess with the coords (not a big problem).
2. I believe Location can't be serialized, which I probably have to do.
How would I save all the locations from an ArrayList to a file then? Help.

 

ItsOneAndTwo
...
1.Users can mess around all they want with the file but if you don't save it, you're good.
2. Yes they can:

PHP:

public String locToString(Location l) {
    return l.getWorld().getName + ":" + l.getBlockX() + ":" + l.getBlockY() + ":" + l.getBlockZ();
}

public Location stringToLoc(String s) {
    String[] st = s.split(":");
    return new Location(Bukkit.getServer().getWorld(st[0]), Integer.parseInt(st[1]), Integer.parseInt(st[2]), Integer.parseInt(st[3]));
}

 

xTrollxDudex
Ok, awesome.
But how am I going to save and load my current ArrayList, which is:

Code:java

public ArrayList<Location> blockloc = new ArrayList<Location>();

?

 

By iterating over your list.

 

ItsOneAndTwo That's how you would do it with the methods xTrollxDudex provided:

Code:java

    public String listToString(List<Location> list) {
        StringBuilder s = new StringBuilder();
        for(Location l : list) {
            if(s.length() > 0)
                s.append("#");
            s.append(locToString(l));
        }
        return s.toString();
    }
 
    public List<Location> stringToList(String s) {
        List<Location> list = new ArrayList<Location>();
        for(String p : s.split("#"))
            list.add(stringToLoc(p));
        return list;
    }

 

DarkBladee12
Gonna give it a try. By the looks of the code it seems to work

DarkBladee12
How can i call the save and load?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ItsOneAndTwo
What save and load?

 

xTrollxDudex
Read DarkBladee12 's post, how can i save and load that serialized location?

 

ItsOneAndTwo You could utilize a BufferedWriter/BufferedReader to save/load the string from file.

 

DarkBladee12 I can't save the string, because i can't access it.
I tried putting this code into a onDisable() method, and got an error, so i had to put this into the main class, and now i cant access the string from onDisable() method.

 

You can access a file from every class and method... Please google how to save and load strings to/from file, I think this well help you.

 

I know how to save strings to a file, i just cant access the string itself.

 

ItsOneAndTwo
Your onDisable is supposed to be in the main class... Show the code.

 

xTrollxDudex
Here's my main class:

Code:java

public class InfiniteBlocks extends JavaPlugin {
 
public Logger logger = Logger.getLogger("Mineraft");
//public ArrayList<Location> blockloc = new ArrayList<Location>();
public ArrayList<String> cansetblockloc = new ArrayList<String>();
 
public String locToString(Location l) {
return l.getWorld().getName() + ":" + l.getBlockX() + ":" + l.getBlockY() + ":" + l.getBlockZ();
}
 
public Location stringToLoc(String s) {
String[] st = s.split(":");
return new Location(Bukkit.getServer().getWorld(st[0]), Integer.parseInt(st[1]), Integer.parseInt(st[2]), Integer.parseInt(st[3]));
}
 
public String listToString(List<Location> blockloc) {
StringBuilder s = new StringBuilder();
for(Location l : blockloc) {
if(s.length() > 0)
s.append("#");
s.append(locToString(l));
}
return s.toString();
}
 
public List<Location> stringToList(String s) {
List<Location> blockloc = new ArrayList<Location>();
for(String p : s.split("#"))
blockloc.add(stringToLoc(p));
return blockloc;
}
 
public void onEnable() {
PluginManager pm = getServer().getPluginManager();
pm.registerEvents(new InfiniteBlocksListener(this), this);
PluginDescriptionFile pdfFile = getDescription();
this.logger.info("[" + pdfFile.getName() + "] v" + pdfFile.getVersion() + " has been Enabled!");
}
 
public void onDisable() {
PluginDescriptionFile pdfFile = getDescription();
this.logger.info("[" + pdfFile.getName() + "] v" + pdfFile.getVersion() + " has been Disabled!");
}
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
if(cmd.getName().equalsIgnoreCase("infblock")){
Player player = (Player) sender;
if(sender.hasPermission("infiniteblocks.set")) {
if(!cansetblockloc.contains(sender.getName())) {
cansetblockloc.add(sender.getName());
sender.sendMessage("§ePlease click on the block you wish to make infinite.");
}
}
return true;
}
return false;
}
}
 

 

ItsOneAndTwo
So where are your locations?

 

xTrollxDudex
Locations are stored in

Code:java

public ArrayList<Location> blockloc = new ArrayList<Location>();

Whenever i type /infblock, i'm added to

Code:

public ArrayList<String> cansetblockloc = new ArrayList<String>();

And then im clicking on a block, which removes me from cansetblockloc, and the block i clicked on gets added to blockloc.
everything works, except whenever i reload/restart the server, blockloc resets.
I just need to save and load blockloc.

 

ItsOneAndTwo
Well then use a static method to get the blockloc

 

xTrollxDudex
How?

 

ItsOneAndTwo

PHP:

public static ArrayList<String> getList() { return blockloc; }

 

xTrollxDudex
How would i implement that into my current code?
btw, blockloc is ArrayList<Location>, not ArrayList<String>.

 

ItsOneAndTwo
Sorry, change that to Location...

Note to self: don't multitask if you have a difficult problem and an easy problem, you'll obviously get the easy one wrong.

 

xTrollxDudex
I'm new to Java, I can do basic things with it, but where on earth am I going to put the code U gave me?

I tried putting this into onDisable/Enable, and I tried to put this to main class, but I'm getting an error.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ItsOneAndTwo
Well, you can't put methods into another method. You would put that code I gave you in your listener class or whatever class that has your ArrayList in it.

Then, onEnable, you would do:

PHP:

saveDefaultConfig();
<Listener class name>.getList().addAll(0, stringToList(getConfig().getString("Locations")));

And in your onDisable, do

PHP:

getConfig.set("Locations", listToString(<Your listener class name>.getList()));
saveConfig()

 

xTrollxDudex
Now i have this:

Code:java

 public void onEnable() {
saveDefaultConfig();
<InfiniteBlocks>.getList().addAll(0, stringToList(getConfig().getString("Locations")));
PluginManager pm = getServer().getPluginManager();
pm.registerEvents(new InfiniteBlocksListener(this), this);
PluginDescriptionFile pdfFile = getDescription();
this.logger.info("[" + pdfFile.getName() + "] v" + pdfFile.getVersion() + " has been Enabled!");
}
 
//onDisable
public void onDisable() {
getConfig().set("Locations", listToString(InfiniteBlocks.getList()));
saveConfig();
PluginDescriptionFile pdfFile = getDescription();
this.logger.info("[" + pdfFile.getName() + "] v" + pdfFile.getVersion() + " has been Disabled!");
}

And i'm getting error on these two:

Code:java

getConfig().set("Locations", listToString(InfiniteBlocks.getList()));

Error: "The method listToString(List<Location>) in the type InfiniteBlocks is not applicable for the arguments (ArrayList<String>)"
And on this one:

Code:java

<InfiniteBlocks>.getList().addAll(0, stringToList(getConfig().getString("Locations")));

I'm getting this error: "Multiple markers at this line
- The method addAll(int, Collection<? extends String>) in the type ArrayList<String> is not applicable for the arguments (int,
List<Location>)
- Syntax error on token ">", delete this token
- Syntax error on token(s), misplaced construct(s)"

//EDIT:
onEnable i fixed the code and i got this error:
The method addAll(int, Collection<? extends String>) in the type ArrayList<String> is not applicable for the arguments (int, List<Location>)

Nvm i got it fixed, gonna try the plugin now.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ItsOneAndTwo
Ah, now we're getting somewhere.
1. Use rhis instead:

PHP:

public String listToString(ArrayList<Location> list) {
    StringBuilder s = new StringBuilder($;
    for(Location loc : list) 
        s.append("#").append(locToString(loc));
    return s.toString();
}

2/3. Use this instead:

PHP:

public ArrayList<Location> stringToList(String s) {
    ArrayList<Location> blockloc = new ArrayList<Location>();
    for(String p : s.split("#"))
        blockloc.add(stringToLoc(p));
    return blockloc;
}

4. Remove all the < and the > from your code

5. Profit.

Wait, show me your listener class please.

 

xTrollxDudex
I removed all the code you guys gave me, now the plugin is working, but without the saving and loading feature.
If i ever decide to reload/restart the server then all of my locations in the arraylist will be gone.
Ok, here i have my main class:

Code:java

package com.gmail.nyyd.ronn.ib;
 
import java.util.ArrayList;
import java.util.logging.Logger;
 
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class InfiniteBlocks extends JavaPlugin {
 
//Logger
public Logger logger = Logger.getLogger("Mineraft");
 
//ArrayList stuff
public ArrayList<Location> blockloc = new ArrayList<Location>();
public ArrayList<String> cansetblockloc = new ArrayList<String>();
 
//onEnable
public void onEnable() {
PluginManager pm = getServer().getPluginManager();
pm.registerEvents(new InfiniteBlocksListener(this), this);
PluginDescriptionFile pdfFile = getDescription();
this.logger.info("[" + pdfFile.getName() + "] v" + pdfFile.getVersion() + " has been Enabled!");
}
 
//onDisable
public void onDisable() {
PluginDescriptionFile pdfFile = getDescription();
this.logger.info("[" + pdfFile.getName() + "] v" + pdfFile.getVersion() + " has been Disabled!");
}
 
//Command
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
if(cmd.getName().equalsIgnoreCase("infblock")){
Player player = (Player) sender;
if(sender.hasPermission("infiniteblocks.set")) {
if(!cansetblockloc.contains(sender.getName())) {
cansetblockloc.add(sender.getName());
sender.sendMessage("§ePlease click on the block you wish to make infinite.");
}
}
return true;
}
return false;
}
}
 

And here i have my Listener class:

Code:java

package com.gmail.nyyd.ronn.ib;
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.block.BlockBreakEvent;
import org.bukkit.event.player.PlayerInteractEvent;
 
public class InfiniteBlocksListener implements Listener {
    public static InfiniteBlocks plugin;
    public InfiniteBlocksListener(InfiniteBlocks instance) {
        plugin = instance;
    }
 
    //Add to blockloc
    @EventHandler
    public void onPlayerInteractEvent(PlayerInteractEvent event) {
        Block block = event.getClickedBlock();
        if(event.getAction() == Action.RIGHT_CLICK_BLOCK) {
            event.getPlayer().sendMessage("§eBlock ID: " + block.getTypeId() + ":" + block.getData() + " (" + block.getType() + ")");
            if(plugin.cansetblockloc.contains(event.getPlayer().getName())) {
                event.setCancelled(true);
                if(block.getType() == Material.ANVIL) {
                    if(!plugin.blockloc.contains(block.getLocation())) {
                plugin.blockloc.add(block.getLocation());
                plugin.cansetblockloc.remove(event.getPlayer().getName());
                event.getPlayer().sendMessage("§aThis " + block.getType().toString().toLowerCase() + " §ais now infinite!");
                    }else{
                        event.getPlayer().sendMessage("§eThis " + block.getType().toString().toLowerCase() + " is no longer infinite!");
                        plugin.cansetblockloc.remove(event.getPlayer().getName());
                        plugin.blockloc.remove(block.getLocation());
                    }
                    }else{
                event.getPlayer().sendMessage("§4This " + block.getType().toString().toLowerCase() + " can't be set as infinite!");
                plugin.cansetblockloc.remove(event.getPlayer().getName());
            }
            }
 
            if(plugin.blockloc.contains(block.getLocation())) {
            if(block.getType() == Material.ANVIL) {
            if(block.getData() == (byte) 4 || block.getData() == (byte) 8) {
                block.setData((byte) 0);
            }
            if(block.getData() == (byte) 7 || block.getData() == (byte) 11) {
                block.setData((byte) 3);
            }
            if(block.getData() == (byte) 6 || block.getData() == (byte) 10) {
                block.setData((byte) 2);
            }
            if(block.getData() == (byte) 5 || block.getData() == (byte) 9) {
                block.setData((byte) 1);
            }
            }
            }
        }
    }
 
    //Remove from blockloc
    @EventHandler
    public void onBlockBreakEvent(BlockBreakEvent event) {
        Block block = event.getBlock();
        if(plugin.blockloc.contains(block.getLocation())) {
            plugin.blockloc.remove(block.getLocation());
            event.getPlayer().sendMessage("§eThis " + block.getType().toString().toLowerCase() + " is no longer infinite!");
        }
    }
 
}