Need Help with PlayerItemPickupEvent

Hello,

Basically I am trying to make a simple plugin that makes it so if you pick up an item (in this case, a sword), and if that sword has a specific enchantment on it (in this case, an unsafe enchantment, power), you will be sent a message.

I know the error is somewhere in this onPlayerPickupItemEvent method because all my other methods work just fine.

Here is my code:

Code:java

 
@EventHandler
public void onPlayerPickupItem(PlayerPickupItemEvent event) {
Player p = event.getPlayer();
 
if(p.getItemInHand() != null){
 
//If the item is a sword
if(p.getItemInHand().getTypeId() == 267
|| p.getItemInHand().getTypeId() == 268
|| p.getItemInHand().getTypeId() == 276
|| p.getItemInHand().getTypeId() == 272
|| p.getItemInHand().getTypeId() == 283){
 
Map<Enchantment, Integer> Enchants = p.getItemInHand().getEnchantments();
Integer level = Enchants.get(Enchantment.ARROW_DAMAGE);
 
//If the enchantment is power
if (Enchants.containsKey(Enchantment.ARROW_DAMAGE)) {
 
//Send player a message
p.sendMessage("Yay, there you go");
}
}

I am not getting the message sent to me--is it because it is trying to get the item in the player's hand before the item is actually picked up? Help would be appreciated, thanks!

Oh, also: I know there aren't a correct amount of curly braces and all--I have more code under that.

 

Okay, after looking through it I found the problem. PlayerItemPickupEvent is called before the item is actually picked up. So, you can't use:

Code:

p.getItemInHand();

I believe you have to use:

Code:

event.getItem();

I hope this helps; glad to help you anytime !!

 

Thanks, but I've already tried this as well, and got the same result. What I did was:

Player p = event.getPlayer();
Item i = event.getItem();

And then checked if the player's iteminhand was equal to i.

 

I have code for something like this somewhere, but i cant access my files atm.
Probably not the right code, but try

Code:

 if(event.getEntity().getItem( == Item.SOMETHING){ 

or

Code:

 if(event.getEntity() instanceof Diamond_sword){

 

The getEntity method does not apply to this event. I have tried

Code:

if(event.getItem() == p.getItemInHand()

and stuff like that, but nothing has worked.

 

The p.getItemInHand() doesn't go into effect until the event is fired, then ended... Only event.getItem() will work.

 

Ah thanks, that makes sense. I wonder how I will go about doing this then...

 

just use e.getItem() instead of p.getItemInHand()......

 

I'm not sure why you assumed that the picked-up item will automatically go into the player's hand. Why not just do something along these lines:

Code:

ItemStack i = event.getItem().getItemStack();
int id = i.getTypeId();
Player p = event.getPlayer();
if (id == 268 || id == 272 || id == 276 || id == 283 || id == 267){
p.sendMessage("You have picked up a " + i.getType());
}

 

I tried that and it didn't work. Ultimately I do want to find the item in the player's hand as well, so somewhere along the line I would have to check whether e.getItem() is equal to p.getItemInHand() which obviously wont work... I think o.0

Yes, thank you, but I do want to find if the item ends up in the player's hand on pickup.

 

You need to make sure the item in hand isnt null..

 

I'm using the same system in my code. Here you go:

Code:

@EventHandler
public void onPlayerPickupItem(PlayerPickupItemEvent e) {
    ItemStack item = e.getItem().getItemStack();
    if(item != null) {
        // I gave the items I wanted to check for a durability of at least 9000
        if(item.getEnchantmentLevel(Enchantment.DURABILITY) > 8999) {
            // Send message
        }
    }
}