Need Help! Fly Errors!

Hello, ok so I am trying to make a heal plugin that lets donators fly in the hub. But it works it just sends too many messages and errors so if you could help me. Heres my code.

Code:java

package me.chibbey.fly;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Fly extends JavaPlugin {
 
    public void onEnable() {
        Bukkit.getServer().getLogger().info("Fly Plugin Has Been Enabled!");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        if (!(sender instanceof Player)) {
            sender.sendMessage(ChatColor.RED + "Only players may fly! Sorry!");
            return true;
        }
        Player p = (Player) sender;
 
        if (label.equalsIgnoreCase("fly")) {
            p.sendMessage(ChatColor.GREEN + "/fly on - Turn fly mode on!");
            p.sendMessage(ChatColor.GREEN + "/fly off - Turn fly mode off!");
            }
            if (args[0].equalsIgnoreCase("on")) {
                p.setAllowFlight(true);
                return true;
                }
                if (args[0].equalsIgnoreCase("off")) {
                    p.setAllowFlight(false);
                    return true;
                }
        return true;
    }
}

What happens is when people type /fly it sends them the messages then one extra message in red saying "An internal error occurred while attempting to perform this command" . And in the console it says

Code:general

[SEVERE] null
org.bukkit.command.CommandException: Unhandled exception executing command 'fly' in plugin Fly v1.0
 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
 at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:192)
 at org.bukkit.craftbukkit.v1_6_R3.CraftServer.dispatchCommand(CraftServer.java:532)
 at net.minecraft.server.v1_6_R3.PlayerConnection.handleCommand(PlayerConnection.java:986)
 at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.java:897)
 at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:838)
 at net.minecraft.server.v1_6_R3.Packet3Chat.handle(Packet3Chat.java:47)
 at org.spigotmc.netty.NettyNetworkManager.b(NettyNetworkManager.java:237)
 at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:117)
 at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
 at org.spigotmc.netty.NettyServerConnection.b(NettyServerConnection.java:131)
 at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:604)
 at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:240)
 at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:493)
 at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:425)
 at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
 at me.chibbey.fly.Fly.onCommand(Fly.java:31)
 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
 ... 15 more

PLEASE HELP ME! also one more problem is when I type /fly on|off it will send them the same messages as if you were typing /fly but not the internal error just the two specified one but it does allow me to fly but im guessing if I fix the /fly one that will fix.

 

You have if(label.equalsIgnoreCase(..){

When it should be if(cmd.equalsIgnoreCase(..){

 

thepaperboy99
Lol, no it would have to be if(cmd.getName().equalsIgnoreCase(..){
and its label because if you look at the public Boolean onCommand it says String label, not commandLabel, so I would use label.equals but anyways that isn't a problem I use label for most my plugins and don't have issues.

 

Chibbey thepaperboy99 The proper usage is

Code:

if(cmd.getName().equalsIgnoreCase("")){

Also , the plugin failed to get the argument in the args list at position 0. That means there isnt actually an argument provided. You should always use if checks to check the length of the arguments before you assume there is such an argument.

Code:

if(args.length == 1){
if (args[0].equalsIgnoreCase("on")) {
                p.setAllowFlight(true);
                return true;
                }
                if (args[0].equalsIgnoreCase("off")) {
                    p.setAllowFlight(false);
                    return true;
                }
 
}

 

Developing
Thank you that helped but now could you help me when I type /fly on|off it sends the messages as if you were typing /fly itself. so when u type /fly on it will turn on flight and send messages "/fly on - Turn fly mode on!" and "/fly off - Turn fly mode off!"

 

Chibbey You mean using /fly as a toggle to on or off?