Filled multiShots

Discussion in 'Plugin Requests' started by madtomic, Aug 10, 2019.

  1. Offline

    madtomic

    Plugin category: Mechnical

    Minecraft version: 1.12.2

    Suggested name:
    multiShots

    What I want: I would like a plugin that would let player shot multiple arrows with corresponded permission. Shift+Right click to perform multiArrows skill shots.

    config.yml
    #Skill shot names
    double: "double shots"
    triple: "triple shots"

    skillShots: "&cYou have performed {skillshot}."
    notEnoughArrows: "&cYou don't have enough arrows to perform this skill."

    Requirements:
    -player must have enough arrows to perform MultiArrows skill.
    -when player don't enough arrows, only 1 arrow will be use and consumed. notEnoughArrows would be sent.

    Commands/Permissions:
    ms.skills.double - shots 2 arrows
    ms.skills.triple - shots 3 arrows

    Thank you for reading.
     
    Last edited: Aug 11, 2019
  2. Offline

    xX4w3s0m3Xx

  3. Offline

    madtomic

    @xX4w3s0m3Xx

    I've been testing and I haven't been able to perform triple shots. give myself double and it work fine. then remove double and give myself triple and it still shoots double.
     
  4. Offline

    xX4w3s0m3Xx

    @madtomic If you want to change from double to triple shots you can use the command /ms triple
     
  5. Offline

    madtomic

    @xX4w3s0m3Xx

    I see now, can you add a message then for notMetSkill: "&cYou haven't unlock Triple Shot skill." When someone tries to switch to a skill they don't have access. And it would still default player MultiShot skill to double.

    Thanks
     
    Last edited: Aug 11, 2019
  6. Offline

    xX4w3s0m3Xx

  7. Offline

    madtomic

    @xX4w3s0m3Xx

    Slight bug, can you add a slight delay shooting the other arrows. It seems like when shooting two arrows. When first one impacted the entity the follow up arrow would bounce and hit the ground.

    Can you also add this message when toggle between skills. Thanks
    switchSkill: "&eYou have switch to {skillshot} skill."

    EDIT: Perhaps a half tick delay for the follow up arrow so it would do damage on impact?

    For balancing, I think there should be a chance that when shooting multi arrows. it would reduce the impact damage of the follow up arrows.

    reduceImpactChance: 0.5
    reduceImpactDamage: 0.5
     
    Last edited: Aug 11, 2019
  8. Offline

    xX4w3s0m3Xx

    @madtomic I checked for the bouncing issue, but for some reason I can't get it fixed. It looks like you can't hit an npc with an arrow when it is getting hit, so it just bounces the arrow off. I've added the switch message and I added a delay setting, so you can test some delays for yourself. I also tried spreading the arrows a bit so it doesn't land on the same spot as the one before, without luck :( https://github.com/xX4m4zingXx/MultiShot

    EDIT:
    I haven't looked at the hit chances, because we can't really test this if we can't hit npcs 2 times in a row, so maybe we have to wait for someone that maybe has an idea to fix that
     
    madtomic likes this.
  9. Offline

    madtomic

    @xX4w3s0m3Xx

    Ok, hit chance is tricky and I hope someone here have an idea. I also wrote a few other issues. Whenever you have time to look at it. It would be great. I am thinking of anything that could improve this request. So far, it turns out what I wanted and more. Thank you again.

    EDIT: the delay is nice addition. I am testing and it might just do the job and I like the idea of spreading the arrow out a bit and this might be enough for balancing issue. As for reduce the following arrows on impact. I don't know what can be done.
     
  10. Offline

    xX4w3s0m3Xx

    @madtomic I looked at the issues you put in github. I fixed the first 3. I'll take a look at the fourth one later. The bouncing off issue is quite a weird one indeed.
     
  11. Offline

    madtomic

    @xX4w3s0m3Xx

    The bouncing off issue might be fine as it is. I don't expect all the arrows hit the target.

    I did some more survival testing and having the arrows slightly spread would make it a bit balanced. After all, we do miss with arrows sometimes. The bouncing off only happens when it hits the ground from some 2 block that the entity is hiding behind a double_grass from what I could see. As for all the arrows hitting the target. I wonder if the following arrows damage can be reduce a bit.

    EDIT: I do see some bouncing here and there when an entity can't take another hit while it is struck.
     
  12. Online

    KarimAKL

    @xX4w3s0m3Xx The bouncing off is probably caused by a damage cooldown.
    Have you tried adding a higher delay between the arrows?
     
  13. Offline

    madtomic

    @KarimAKL

    Good point, testing now.

    EDIT: Anything more than a tick or 20 make the follow up arrow shot looks out of place.
    The idea is to have the arrows follow out in almost same session.

    I finally got it at 10 tick, this is enough so the arrow don't bounce off.
     
    Last edited: Aug 11, 2019
    KarimAKL likes this.
  14. Offline

    xX4w3s0m3Xx

    @madtomic I've added 3 of your issues again. For the debug info I probably need to track the arrows and then get the damage done within another event. I'm not sure about this yet, so I'll take a look at that later. The trigger bow animation can probably be done by modifying a packet, I have to do some more research and testing to see if that'll work out
     
    madtomic likes this.
  15. Offline

    madtomic

    @xX4w3s0m3Xx

    Gotcha! I will do some more testings. I think, it's pretty close to wrap up.
     
  16. Offline

    xX4w3s0m3Xx

    Aright, sounds good!
     
  17. Offline

    madtomic

    @xX4w3s0m3Xx

    All added features are working as intended. I did add one more feature request to make it friendly to toggle between skill shots.

    EDIT: I had mark this request filled as it had already met all the initial plugin request. Thanks
     
    Last edited: Aug 11, 2019
  18. Offline

    xX4w3s0m3Xx

    @madtomic Going to take a look at it now
    EDIT: I just realised that you want the cooldown to be seperate, so if you have a cooldown on one ability, then you can still use the other ability (unless that one has a cooldown too ofcourse), right?
     
    Last edited: Aug 12, 2019
  19. Offline

    madtomic

    @xX4w3s0m3Xx

    The cool down is for all skill shots. It would be OP if one can switch skill shot after using it.

    EDIT: I just pastebin the server crashes. I hope you can look at it later. Thanks again.
     
    Last edited: Aug 12, 2019
  20. Offline

    xX4w3s0m3Xx

    @madtomic
    Alright, then I don’t have to change too much. I’ll try to find why you get that error this evening.
     
  21. Offline

    xX4w3s0m3Xx

    madtomic likes this.
  22. Offline

    madtomic

    @xX4w3s0m3Xx

    Thank you so much again! I will report if I come across any issue. So far, it is pretty stable.
     

Share This Page