Solved Moving GUI [Timing]

Hey.. I hate having to post here but I'm definitely stuck

I have a custom inventory that opens 9 slots, I have an array list filled with itemstacks. I know how to loop over the arraylist, I know how to add them items to the inventory. My problem is, is that I want one item to loop over each slot (1-9), I want all of them to do it and each time I want the time it takes one item to cross all 9 slots to decrease. Does that make sense? :3

EDIT: Ok I removed some of the old text and that (^) small text is my original description. I'm really having no luck, either it's not possible or I'm derping really hard.

To hopefully help, I've created this short gif which I hope explains what I want to do. I'm not asking to be spoon fed code, I just need someone to push me in the right direction



^ Hehe, it looks silly but it explains my idea pretty well. I can get the items in the GUI and I remove them but I have no clue how to loop them over like the gif shows with a small wait in-between. When I first had this idea, I thought it'll be easy, now I'm thinking it's not possible? If so please say D: Otherwise I welcome you to try it yourself.

Thank you very much!
~Luke

 

I really suggest using BukkitScheduler, repeating task.

 

There is almost always 20 ticks per second on a non-lagging server. Why do you need extreme accuracy? There's no way to get around a little server lag anyway, even at packet level if it's connection lag.

 

Because to achieve the effect I want, I assume I'd have to have 2 schedulers running one inside the other which will undoubtedly ruin the effect and cause tick lag.

 

Why would it cause lag? Surely moving items around in inventories each tick is not an expensive process?

 

Can anyone help me with this? I'm almost certain that I cannot use Schedulers because I need to keep track of the inv number but it needs to be final within a Scheduler...

I just have no clue how to time it all. It needs to set it, 5 seconds later change to the next one and remove the one before it all while looping over the inventory.

 

You can use an asynchronous timer, so even when the server is lagging, the timer of this inventory won't be laggin

 

I'm still having no luck with this. I just need to add a wait within each iteration. I can't use a delayed task inside the loop as the loop will carry on and the task will literally just run later (new thread) and I can't use a repeating task because my methods of counting each iteration do not work as the variables need to be final within the task. The only thing I could think of it getting the start time (System.mili...) and each iteration, add 4 seconds on to the time and check if the current time is equal or greater than that time, if it is, loop the next and add +4. However I have no clue how I'd do that.

 

Create a class implementing Runnable, maybe?

 

Just a small bump, I've edited the question and hopefully it'll explain what I want :s I hope it's possible

 

I still don't see why you can't just use a repeating task

 

I can't get it working using repeating tasks. Feel free to try yourself, if you can then I'd be shocked

 

Luke_Lax
This looks like. is not what your looking for but if you are creative you will be able to serve

Code:java

inv = Bukkit.createInventory(null, 9, "Menu");
 
        Bukkit.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
                    public void run() {
 
                                                if (num == 1) {
                            nv.setItem(0, createItem(Material.TNT, 1, (short) 0, "Arcade", "Lore));
                                                        num++;
 
                                                } else if (num == 2){
                                                        inv.setItem(0, createItem(Material.ARROW, 1, (short) 0, "Arcade", "Lore"));
                                                        num++;
 
                                                        } else if (num == 3){
                                                        inv.setItem(0, createItem(Material.BOOK, 1, (short) 0, "Arcade", "Lore"));
                                                        num++;                                   
 
                                                        } else if (num == 4){
                                                        inv.setItem(0, createItem(Material.COOKIE, 1, (short) 0, "Arcade", "Lore"));                                                                           
                                                        num++;                                   
 
                                                        }
 
                            num = 1;
 
                                }       
            }, 0, 1 * 4); //Time to update the item
      }
        public ItemStack createItem(Material material, int amount, short shrt, String displayname, String lore) {
                ItemStack i = new ItemStack(material, amount, (short) shrt);
                ItemMeta im = i.getItemMeta();
                im.setDisplayName(displayname);
 
                ArrayList<String> loreList = new ArrayList<String>();
                String[] lores = lore.split("/");
                loreList.addAll(Arrays.asList(lores));
 
                im.setLore(loreList);
                i.setItemMeta(im);
                return i;
 
 
        }

 

I just did. Here's the code:

Code:java

final Inventory inv = Bukkit.createInventory(null, 9);
inv.setItem(0, new ItemStack(Material.DIAMOND));
((Player) sender).openInventory(inv);
 
new BukkitRunnable() {
@Override
public void run() {
ItemStack temp = inv.getItem(inv.getSize() - 1);
for (int i = inv.getSize(); i > 0; i--) {
if (i > 1) {
inv.setItem(i - 1, inv.getItem(i - 2));
} else {
inv.setItem(i - 1, temp);
}
}
 
((Player) sender).updateInventory();
}
}.runTaskTimer(this, 10, 10);

Just stop the timer on invclose and logout and it should be good to go

Oh, and to swap the items, just check if slot 8 is the item, and if so, replace it with the other item, and do this right before the for loop

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

chikenlitle99 hintss

Thank you both very much! I think I just needed to see a way and that it was possible, it got it to work flawlessly!
You were right hintss, I think it frustrated me and I convinced myself it wasn't going to work
For anyone wondering how I personally did it (before I saw hintss code), here, roughly:

Code:java

        Bukkit.getServer().getScheduler().scheduleSyncRepeatingTask(main, new Runnable() {
            public void run() {
                count++;
                ItemStack i = YourItemStack;
                if(count >= 9){
                    count = 0;
                }
                Inv.setItem(count, air);
                Inv.setItem(count, i);
 
                Bukkit.getServer().getScheduler().scheduleSyncRepeatingTask(main, new Runnable() {
                    public void run() {
                        if(count != 0){
                            Inv.setItem((count - 1), air);
                        } else {
                            Inv.setItem(8, air);
                        }
                    }
                }, 5, 0);
 
      }
}, 20, 10);

 

inventory editing with a async task is a no no

 

what's more, async task timers will still slow down if tps goes down

 

hintss they run in a separate Thread, so tps lag shouldn't slow it down unless the CPU cannot handle it (which is hardly the cause)

 

Never had and still don't have any problems with it, its working perfectly for me

 

EcMiner until one day you will have an unexplainable problem in the code caused by disregarding thread safety :3. Asynchronous API usage is extremely unpredictable, and if I change your inventory at exactly the same time, you won't be able to predict what happens.

 

I'll take my chances

 

EcMiner the previous argument aside, for what purpose? In general you won't need async execution for performance.

 

fireblast709 It does help me in performance, causw when there's like 200 players on the server and then I would do the effect synchronously it would lagg and that would basically make it look ugly, and I'm not the best coder out there so my code is not fully optimized for performance cause I find that pretty hard to do with some of the things so I really need the asynchronous tasks. I appreciate the tip about it being unsafe but its just necessary in my case

 

EcMiner wouldn't it be better to learn new ways to optimise your code . You can pm me or create a new thread if you need help with it :3

 

fireblast709 Thanks I'll see what I can do first