Solved Method not running when called

Hi there,

I've been coding a plugin where you can shoot fireworks such that they explode on impact and deal damage, however, I seem to have hit a wall as to why the following code is not running when there are no entities near the impact point. The debug messages tell me that it runs once I get close enough that it damages me. The same goes for the explosion bit, it only ever runs when it hits an entity, or I get near it.

Here's my code:

Code:Java

        new BukkitRunnable(){
            @Override
            public void run(){
                // The block at the firework's location
                Material block = firework.getWorld().getBlockAt(firework.getLocation()).getType();
 
                // Check whether the block is solid
                if (block != Material.AIR && block != Material.WATER && block != Material.STATIONARY_WATER && !block.isTransparent()){
                    explodeFireworks(firework);
                    cancel();
                    return;
                }
                // Check whether the firework hit an entity
                if (firework.getNearbyEntities(0.5,0.5,0.5).size() > 0){
                    explodeFireworks(firework);
                    cancel();
                    return;
                }
                // If the firework didn't hit something, just reset its direction
                firework.setVelocity(vector);
 
            }
        }.runTaskTimer(main, 0L, 1L);
 
    }
 
    private void explodeFireworks(Firework firework){
        // Detonate the firework (this is the only bit that triggers on impact)
        firework.detonate();
        // If enabled, create an explosion (does not run when no nearby entities)
        if (main.getConfig().getBoolean("do-hand-explosions"))
            firework.getWorld().createExplosion(firework.getLocation(), main.getConfig().getInt("hand-explosion-size"));
        // If enabled, deal damage to nearby entities
        if (main.getConfig().getBoolean("do-hand-extra-damage"))
            damageNearbyEntities(firework);
    }
 
    private void damageNearbyEntities(Entity source){
        Bukkit.broadcastMessage("Started!");
        // Get the radius for damage
        double radius = main.getConfig().getDouble("hand-damage-radius");
        // Get the damage to be dealt
        double damage = main.getConfig().getDouble("hand-extra-damage");
        // Iterate over all nearby entities and kill them
        for (Entity hurt: source.getNearbyEntities(radius, radius, radius)){
            if (hurt instanceof Damageable) {
                try{
                    if (true)
                    ((Damageable) hurt).setHealth(((Damageable) hurt).getHealth() - damage);
                }catch (IllegalArgumentException e){((Damageable) hurt).setHealth(0);}
            }
            else hurt.remove();
        }
        Bukkit.broadcastMessage("Ended!");
    }

So, to sum up, the firework detonates, but there is no explosion or damage dealt till I get near it, at which point it hurts me.
Hopefully you guys can shed some light on why it doesn't work

 

@Horsey
If you want it to trigger only if it hit solid blocks, why not use if Material#isSolid()?

Are you sure the is solid block ever returns true? Have you tried printing out the block's type?

 

That's a good idea lol, but yeah, it does return true and the firework does explode (only the firework, not the explosion I created).

 

@Horsey
What would be the explosion you created? What that be the explodeFireworks() method? If so, can you post that method?

 

Scroll down, I have included that method in the code.

 

@Horsey

1. What happens if you hard code the values from the config?
2. Since the config values should not change while the server is one, move them outside of the methods.
3. Use Math.max(((Damageable)hurt).getHealth-damage,0.0); so you don't need to use the try/catch statement.
4. You say it only sends the messages when you get close. Does that happen in the ExploseFireworks method? What about in the runnable?

 

@Zombie_Striker
Thanks for your help, but I solved the problem