Message doesn't stop sending

sum_17427 · Dec 11, 2014

My code:
[java]Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
public void run(){
cooldown.remove(player);
player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
}
}, 3600);[/java]
Why that message doesn't stop sending?

teej107 · Dec 11, 2014

@sum_17427 Your shown code tells us that it only runs once.

Monkey_Swag · Dec 11, 2014

@sum_17427 post your full class please

sum_17427 · Dec 11, 2014

@teej107 @Monkey_Swag

Code:

public void onInventoryClick(PlayerInteractEvent e){
        final Player player = e.getPlayer();
        if (player.hasPermission("mycraft.use.normal")){
            if (player.getItemInHand().getType().equals(Material.STONE_AXE)
                    || player.getItemInHand().getType().equals(Material.STONE_PICKAXE)){
                if (e.getAction() == Action.RIGHT_CLICK_BLOCK){
                    if (player.getFoodLevel() >= 5){
                        if (cooldown.contains(player)){
                            e.setCancelled(false);
                        } else {
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.EXTINGUISH, 5);
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.ENDER_SIGNAL, 5);
                            player.addPotionEffect(new PotionEffect(PotionEffectType.FAST_DIGGING, 300, 1));
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN+ "Sử dụng!");
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "1 phút hồi.");
                            player.setFoodLevel(player.getFoodLevel() - 5);
                            cooldown.add(player);
                        }
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                            }
                        }, 1200);
                    }
                }
            }
}

Monkey_Swag · Dec 11, 2014

@sum_17427 not exactly sure why it's running multiple times, but what I do know is that instead of usin .equals, you need to use '=='. This is a more correct way of comparing Enums. That might be the problem.

sum_17427 · Dec 11, 2014

@Monkey_Swag
This Message

Code:

Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                            }
                        }, 1200);

It's don't stop sending message while im not do action

teej107 · Dec 11, 2014

@Monkey_Swag I doubt it. @sum_17427 on another note, it is advised that you don't un-cancel an event unless you have an intention of changing the outcome of other plugins (it might even break them). Right now, this
Code:
e.setCancelled(false);
is doing nothing in relation to your plugin. Also your method name is a bit misleading. How many times does it send the message? Is it consistent every time?

sum_17427 · Dec 11, 2014

@teej107
Its sendmessage after im do the action rightclick and its don't stop
Could i add "return" to

Code:

Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                            }
                        }, 1200);
return;

teej107 · Dec 11, 2014

@sum_17427 Show me the code where you register your event.

sum_17427 · Dec 11, 2014

@teej107
Here full code:

Code:

package me.summc.mycraft;

import java.util.HashSet;
import java.util.logging.Logger;

import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Effect;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;

public class Main extends JavaPlugin implements Listener{
    public final Logger log = Logger.getLogger("Minecraft");
    HashSet<Player> cooldown = new HashSet<Player>();
   
    public void onEnable(){
        getServer().getPluginManager().registerEvents(this, this);
      }
   
    @EventHandler(priority=EventPriority.NORMAL)
    public void onInventoryClick(PlayerInteractEvent e){
        final Player player = e.getPlayer();
        if (player.hasPermission("mycraft.use.normal")){
            if (player.getItemInHand().getType().equals(Material.STONE_AXE)
                    || player.getItemInHand().getType().equals(Material.STONE_PICKAXE)){
                if (e.getAction() == Action.RIGHT_CLICK_BLOCK){
                    if (player.getFoodLevel() >= 5){
                        if (cooldown.contains(player)){
                            e.setCancelled(false);
                        } else {
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.EXTINGUISH, 5);
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.ENDER_SIGNAL, 5);
                            player.addPotionEffect(new PotionEffect(PotionEffectType.FAST_DIGGING, 300, 1));
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN+ "Sử dụng!");
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "1 phút hồi.");
                            player.setFoodLevel(player.getFoodLevel() - 5);
                            cooldown.add(player);
                        }
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                            }
                        }, 1200);
                    }
                }
            }
            if (player.getItemInHand().getType().equals(Material.IRON_AXE)
                    || player.getItemInHand().getType().equals(Material.IRON_PICKAXE)){
                if (e.getAction() == Action.RIGHT_CLICK_BLOCK){
                    if (player.getFoodLevel() >= 10){
                        if (cooldown.contains(player)){
                            e.setCancelled(false);
                        } else {
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.EXTINGUISH, 5);
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.ENDER_SIGNAL, 5);
                            player.addPotionEffect(new PotionEffect(PotionEffectType.FAST_DIGGING, 300, 1));
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN+ "Sử dụng!");
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "2 phút hồi.");
                            player.setFoodLevel(player.getFoodLevel() - 10);
                            cooldown.add(player);
                        }
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                            }
                        }, 2400);
                    }
                }
            }
            if (player.getItemInHand().getType().equals(Material.DIAMOND_AXE)
                    || player.getItemInHand().getType().equals(Material.DIAMOND_PICKAXE)){
                if (e.getAction() == Action.RIGHT_CLICK_BLOCK){
                    if (player.getFoodLevel() >= 15){
                        if (cooldown.contains(player)){
                            e.setCancelled(false);
                        } else {
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.EXTINGUISH, 5);
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.ENDER_SIGNAL, 5);
                            player.addPotionEffect(new PotionEffect(PotionEffectType.FAST_DIGGING, 300, 1));
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN+ " Bạn đã sử dụng skill!");
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Thời gian hồi skill: 3 phút.");
                            player.setFoodLevel(player.getFoodLevel() - 15);
                            cooldown.add(player);
                        }
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                            }
                        }, 3600);
                    }
                }
            }
        }
        if (player.hasPermission("mycraft.use.vip")){
            if (player.getItemInHand().getType().equals(Material.STONE_AXE)
                    || player.getItemInHand().getType().equals(Material.STONE_PICKAXE)){
                if (e.getAction() == Action.RIGHT_CLICK_BLOCK){
                    if (player.getFoodLevel() >= 5){
                        if (cooldown.contains(player)){
                            e.setCancelled(false);
                        } else {
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.EXTINGUISH, 5);
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.ENDER_SIGNAL, 5);
                            player.addPotionEffect(new PotionEffect(PotionEffectType.FAST_DIGGING, 200, 1));
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN+ "Sử dụng!");
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "30 giây hồi.");
                            player.setFoodLevel(player.getFoodLevel() - 5);
                            cooldown.add(player);
                        }
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                            }
                        }, 600);
                    }
                }
            }
            if (player.getItemInHand().getType().equals(Material.DIAMOND_AXE)
                    || player.getItemInHand().getType().equals(Material.DIAMOND_PICKAXE)){
                if (e.getAction() == Action.RIGHT_CLICK_BLOCK){
                    if (player.getFoodLevel() >= 10){
                        if (cooldown.contains(player)){
                            e.setCancelled(false);
                        } else {
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.EXTINGUISH, 5);
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.ENDER_SIGNAL, 5);
                            player.addPotionEffect(new PotionEffect(PotionEffectType.FAST_DIGGING, 300, 1));
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN+ "Sử dụng!");
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "1 phút 30 giây hồi.");
                            player.setFoodLevel(player.getFoodLevel() - 10);
                            cooldown.add(player);
                        }
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                            }
                        }, 1800);
                    }
                }
            }
            if (player.getItemInHand().getType().equals(Material.DIAMOND_AXE)
                    || player.getItemInHand().getType().equals(Material.DIAMOND_PICKAXE)){
                if (e.getAction() == Action.RIGHT_CLICK_BLOCK){
                    if (player.getFoodLevel() >= 15){
                        if (cooldown.contains(player)){
                            e.setCancelled(false);
                        } else {
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.EXTINGUISH, 5);
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.ENDER_SIGNAL, 5);
                            player.addPotionEffect(new PotionEffect(PotionEffectType.FAST_DIGGING, 600, 1));
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN+ "Sử dụng!");
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "2 phút 30 giây hồi.");
                            player.setFoodLevel(player.getFoodLevel() - 15);
                            cooldown.add(player);
                        }
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                            public void run(){
                                cooldown.remove(player);
                                player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");   
                            }
                        }, 3000);
                    }
                }
            }
        }
    }   
}

Avygeil · Dec 11, 2014

@sum_17427 The part where you schedule is not in your else { }.

EDIT :
Also :
1. Don't use the Minecraft logger
2. getItemInHand() can return null
3. The first 'if' part where you cancel the event is not necessary, remove it and make the check !contains
4. You just broke whole OOP with a single class
5. Use a Set of UUID

teej107 · Dec 11, 2014

Your code if very repetitive. That's why they invented methods!

sum_17427 · Dec 11, 2014

@Avygeil
1. How would i change Minecraft logger to ?
3 + 5. Could i have an example?

Avygeil · Dec 11, 2014

@sum_17427
1. Use this.getServer().getLogger()
5. Set<UUID> = new HashSet<UUID>(), and then you add/check against it with player.getUniqueId()
3. What I meant is right now you have :

if (contains) { // Unnecessary code) }
else { // interesting code }
Schedule

Change to :
if (!contains) { // interesting code + Schedule }

Forge_User_60359873 · Dec 11, 2014

Avygeil said: ↑

Use this.getServer().getLogger()
Click to expand...

@sum_17427 Sans the getServer() - that will just end up returning Minecraft's Logger anyway. JavaPlugin#getLogger() returns the Logger specifically for that plugin

sum_17427 · Dec 11, 2014

@Avygeil
Im did right?

Code:

if (player.getItemInHand().getType().equals(Material.IRON_AXE)
                    || player.getItemInHand().getType().equals(Material.IRON_PICKAXE)){
                if (e.getAction() == Action.RIGHT_CLICK_BLOCK){
                    if (player.getFoodLevel() >= 10){
                        if (!(cooldown.contains(player))){
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.EXTINGUISH, 5);
                            player.getLocation().getWorld().playEffect(player.getLocation(), Effect.ENDER_SIGNAL, 5);
                            player.addPotionEffect(new PotionEffect(PotionEffectType.FAST_DIGGING, 300, 1));
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN+ "Sử dụng!");
                            player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "2 phút hồi.");
                            player.setFoodLevel(player.getFoodLevel() - 10);
                            cooldown.add(player);
                            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                                public void run(){
                                    cooldown.remove(player);
                                    player.sendMessage(ChatColor.DARK_RED + "[" + ChatColor.RED + "Skill" + ChatColor.DARK_RED + "] " + ChatColor.DARK_GREEN + "Hồi!");
                                }
                            }, 2400);
                        }
                    }
                }
            }

Code:

public void onEnable(){
        getServer().getPluginManager().registerEvents(this, this);
        this.getServer().getLogger();
    }

Avygeil · Dec 11, 2014

@AdamQpzm Yeah I messed up, typed too fast

@sum_17427 If you do the null check, then yes. But only you can tell me, does it work now?

EDIT : Actually, if you did change to Set<UUID>, you have to check for contains(player.getUniqueId()), not contains(player). Same for remove and add.

sum_17427 · Dec 11, 2014

@Avygeil
Thanks. It's work smoothly!
Change to this? "HashSet<UUID> cooldown = new HashSet<UUID>();"

Avygeil · Dec 11, 2014

@sum_17427 Yes, this will prevent memory leaks since you don't remove the player on leave. But if you do it, also change :
cooldown.contains(player) => cooldown.contains(player.getUniqueId())
cooldown.add(player) => cooldown.add(player.getUniqueId())
cooldown.remove(player) => cooldown.remove(player.getUniqueId())
But you get the logic.

Forge_User_60359873 · Dec 11, 2014

@sum_17427 Actually it should be "Set<UUID> cooldown = new HashSet<UUID>();". I'll insert a snippet of one of garbagemule's long posts to try and explain why

garbagemule said: ↑

Program to an interface, not an implementation

A clear favorite of mine when it comes to object-oriented programming principles. Unless you need specific ArrayList-only methods, you should be declaring variables of type List (or Collection), rather than variables of type ArrayList. The reason for this is abstraction. Consider this method signature:
Looks innocent, right? It's not. Let's say that this method returns an ArrayList of names of players that are currently online. Then for some reason, you decide that you want to return a LinkedList instead (unlikely, as LinkedList is less efficient for all list operations in practice), so now you have to change the method signature:
In the meantime, some other developer has hooked into your plugin and is now using this method in his own plugin. When you change the method signature of a public facing method, you risk breaking anything that depends on that method (this is what happened when health changed from ints to doubles in Minecraft, and the only reason this didn't break Bukkit plugins was due to a clever hack by the Bukkit team to ensure backwards compatibility), so there are reasons beyond "it's annoying to have to change all my methods" when you decide to use a different implementation for something. Had you instead started out with this signature:
You would have absolutely no problem changing to a different implementation of the List interface, because you would still be returning a compatible object. This could also be problematic, though, because is it actually necessary to return a List, or would a Collection suffice? If add, remove and contains are the only required operations, then this signature would be even better, because it would allow you to change the implementation to e.g. a HashSet (or a TreeSet, if you wanted to return an ordered collection):
So, program to an interface, not an implementation, because abstraction is one of the fundamental principles of object-oriented programming, and ignoring them creates tightly coupled, inflexible code that is more prone to breaking stuff when things are shifted around.
Click to expand...

mythbusterma · Dec 11, 2014

@sum_17427

Don't use Runnables to create cooldowns, associate a time with the player and then check it when you try to perform the action, using Runnables to do this is just lazy.

Forge_User_60359873 · Dec 11, 2014

@mythbusterma Although admittedly it's the only way to do it and send them a message that they can use it again.

@Avygeil Your liking of my post helped me to ninja you here

Avygeil · Dec 11, 2014

@mythbusterma I think he wants to notify the player when the cooldown finishes, judging by the code. I can't think of how to do it without Runnables, but maybe you know?

EDIT : Dat ninja

Log in or Sign up

Message doesn't stop sending

sum_17427

teej107

Monkey_Swag

sum_17427

Monkey_Swag

sum_17427

teej107

sum_17427

teej107

sum_17427

Avygeil

teej107

sum_17427

Avygeil

Forge_User_60359873

sum_17427

Avygeil

sum_17427

Avygeil

Forge_User_60359873

mythbusterma

Forge_User_60359873

Avygeil

Share This Page

Message doesn't stop sending

Share This Page

Useful Searches