Solved Make water wave

It isn't like that at all...

Has nobody noticed that he DIDN'T ACTUALLY GET ANY CODE FROM THIS THREAD?

It's one thing if he took code from this thread, changed it a bit to make it work, then refused to release it, but that's not the case at all. He took PRIVATE code and used it, and if it is under license is is probably illegal for him to release it on here.

 

.... What don't you get about that...

 

ty bby

 

PandazNWafflez The arguments used to not display the source code are invalid though. (referring to the possibility of his 'boss' not allowing him/firing him) His 'boss' doesn't have anything to do with this. Also, as far as I know, receiving help never implies being obliged to return something. That, however, doesn't mean you should keep solutions to yourself, but instead share it, to help others. This would be a horrible place if people helped each other solely if they owe them something.

 

It's more the principle, he expected help but if I asked him how silky did it, would he help me (in 3rd person since he won't reply)? Of course not. Wow meepcraft and hypixle, so important. Many players. Such fame.

 

Okay.. I didn't read all the hate here, but you win. Here have the source: Compatible to EffectLib

Code:java

package de.slikey.effectlib.effect;
 
import de.slikey.effectlib.EffectManager;
import de.slikey.effectlib.EffectType;
import de.slikey.effectlib.util.MathUtils;
import de.slikey.effectlib.util.ParticleEffect;
import de.slikey.effectlib.util.VectorUtils;
import org.bukkit.Location;
import org.bukkit.util.Vector;
 
import java.util.Collection;
import java.util.HashSet;
 
public class WaveLocationEffect2 extends LocationEffect {
 
    public final Vector velocity = new Vector();
 
    protected boolean firstStep = true;
    protected final Collection<Vector> waterCache, cloudCache;
 
    public WaveLocationEffect2(EffectManager effectManager, Location location) {
        super(effectManager, location);
 
        type = EffectType.REPEATING;
        period = 5;
        iterations = 50;
        velocity.copy(location.getDirection().multiply(0.2));
        waterCache = new HashSet<Vector>();
        cloudCache = new HashSet<Vector>();
    }
 
    public void invalidate() {
        firstStep = false;
        Vector s1 = new Vector(-1.5f, 0, 0), s2 = new Vector(3, 0, 0), h = new Vector(-0.5 * 1.5f, 2, 0);
        Vector n1, n2, n1h, n2h, c1, c2, s1h, h2;
        float l1h, l2h, yaw;
        s1h = h.clone().subtract(s1);
        c1 = s1.clone().add(s1h.clone().multiply(0.5));
        l1h = (float) s1h.length();
        n1h = s1h.clone().multiply(1f / l1h);
        n1 = new Vector(s1h.getY(), -s1h.getX(), 0).normalize();
        if (n1.getX() < 0) n1.multiply(-1);
        h2 = h.clone().subtract(s2);
        c2 = s2.clone().add(h2.clone().multiply(0.5));
        l2h = (float) h2.length();
        n2h = h2.clone().multiply(1f / l2h);
        n2 = new Vector(h2.getY(), -h2.getX(), 0).normalize();
        if (n2.getX() < 0) n2.multiply(-1);
        yaw = (-location.getYaw() + 90) * MathUtils.degreesToRadians;
        for (int i = 0; i < 10; i++) {
            float ratio = (float) i / 10;
            float x = (ratio - .5f) * l1h;
            float y = (float) (-1 / Math.pow((l1h / 2), 2) * Math.pow(x, 2) + 1);
            Vector v = c1.clone();
            v.add(n1h.clone().multiply(x));
            v.add(n1.clone().multiply(y));
            for (int j = 0; j < 20; j++) {
                float z = ((float) j / 20 - .5f) * 5;
                Vector vec = v.clone().setZ(v.getZ() + z);
                VectorUtils.rotateAroundAxisY(vec, yaw);
                if (i == 0 || i == 10 - 1) cloudCache.add(vec);
                else waterCache.add(vec);
            }
        }
        for (int i = 0; i < 10; i++) {
            float ratio = (float) i / 10;
            float x = (ratio - .5f) * l2h;
            float y = (float) (-.5f / Math.pow((l2h / 2), 2) * Math.pow(x, 2) + .5f);
            Vector v = c2.clone();
            v.add(n2h.clone().multiply(x));
            v.add(n2.clone().multiply(y));
            for (int j = 0; j < 20; j++) {
                float z = ((float) j / 20 - .5f) * 5;
                Vector vec = v.clone().setZ(v.getZ() + z);
                VectorUtils.rotateAroundAxisY(vec, yaw);
                if (i == 10 - 1) cloudCache.add(vec);
                else waterCache.add(vec);
            }
        }
    }
 
    @Override
    public void onRun() {
        if (firstStep) invalidate();
        location.add(velocity);
        for (Vector v : cloudCache) {
            location.add(v);
            ParticleEffect.CLOUD.display(location, visibleRange, 0, 0, 0, 0, 1);
            location.subtract(v);
        }
        for (Vector v : waterCache) {
            location.add(v);
            ParticleEffect.DRIP_WATER.display(location, visibleRange, 0, 0, 0, 0, 1);
            location.subtract(v);
        }
    }
}
 

And now, please close this thread.

 

Luke_Lax Your signature confused me greatly.

 

Traks

Your arguments kinda outlines my point. While there are positives in sharing it, they are outweighed by his trust with his 'boss'. I don't think he actually mentioned a 'boss' - that was his friend.

 

OMG

This discussion is so poorly.

negative_codezZ had a nice idea, but not the knowledge how to code it. Then a community member (@Slikey) grab his idea for Hypixel.
But Silkey was so nice, to share his code with negative_codezZ, because it was his idea. Silkey has 100% of rights for his code, he did NOT need to give negative_codezZ his code, but he did. That was nice and helpful, but not necessary.

So if negative_codezZ would show us the code, this would be very wrong, since it is NOT HIS code. He'd release someone else's code (which would be against bukkit dev EULA btw.). Not a good idea, since he has 0% of any rights for it.

So you want to force @Silkey to open-sources his code? Why? Only because he grab the idea from negative_codezZ and was so fair to give him the source?

I thought this was a place, where people are FREE to help other ones, not a place where you will be FORCED to give YOUR WORK to everyone. Do you know how much these two people helped or will help the community? Only because he doesn't want everyone profit from his code he made THIS TIME, you attack them?

I hope this thread get closed soon, as it is totally OT now, and people get abused here for no valid reason.

 

Slikey Cool code. Very amaze. Big fan.

 

If it was Slikey's code, I certainly understand why he wouldn't post it.

However,
1. He didn't say that at first, so there was backlash there.
2. If he's doing a job, he shouldn't be outsourcing the development to a Bukkit Forums post...

 

The Point is that if you are going to ask the public for help, you should share the solution with the public. Its not morally right to cover the solution and hover it right in front of everyone's faces.

PandazNWafflez No one may have posted code directly on this thread, but there were people who took their own time to direct him to the proper person for the problem.

 

As it isn't his code, he would violate other one's rights, if he would release it.

 

This thread is still going on?

Alright let me straighten some things out here. If Slikey didn't want his code to be made public he shouldn't have offered it to someone asking for it on a public forum, and request not to have it made public. That's like giving candy to a baby and telling him not to share it with the other kids in the yard. It's dumb. If you want to avoid an "if I give you candy then everyone else will want some" situation, don't give the candy.

But it's done now, he shared the code, and it's over. Can this thread now be locked?

 

Both sides of the debate raise valid points.

• You have rights to the code you have written; you choose whether to release it or not, you are not forced to either BUT...
• It is good forum etiquette, if you have found a solution on your own, to:
  1. Publicly release it, else...
  2. Allow discussion to continue, don't post how you have found it on your own, as this is no help to anyone and just begs questions, let others find a solution so if anyone looks back at this thread in the future they will know what to do
• The code has now been posted here

There is no longer reason for discussion on the ethics of releasing the code.

 

My god, just finished my version and bam, the source is released. I just got ninja'd.

 

JBoss925 You can release it anyway I am always happy to see other ways of doing it^^ (maybe more efficient ways)

 

Slikey So much for that NDA

 

The thing is, AdamQpzm, I think he's saying he wrote it but he thought that since he gave it to Hypixel (or Mineplex or Minetime or whatever, lost track) that means he couldn't give it to us.

 

Yeah, it's no problem since I gave out the first version of it. I have a more advanced one (not compatible to EffectLib) for Hypixel. So there is no conflict.

 

so you gave us the crappy one? :l
Lol, jk but this is so cool.
Is there a surfing game coming?

 

Slikey Thank you for releasing your code, but I totally agree with your "I don't want to share the code since it's for Hypixel". You wrote the code, you own it and you do whatever you want to with it.

Thanks a lot,
~DevilMental (I can't believe I'm talking to Hypixel's developer \o/)

 

The novelty quickly wares off (hint: they're normal people too )

 

AdamQpzm I've always been fan of famous developers and I sort of admire them, for they do. So I tend to be egocentric too (you know why )

~DevilMental (god damnit, I love myself!)

 

Hey, thank you, but I am a normal person too with normal problems. I started in Bukkit lik everyone else..^^

 

What? I thought you were a robot! No way!

 

They're all front end developers...