Magic Clock Code?

what exactly is not working?

The item does not show in the inventory? - You give it nowhere in your code to the player in the first place
The Players do not get hidden? - Insert a debug message to see if it gets into the if-clause
The Item does not get switched - Insert a debug message

 

Essentially, I join the server, spawned myself the dye, add the required lore to it, right click with it and nothing happened.

I did just add this:

Code:java

    @EventHandler
    public void OnJoin(PlayerJoinEvent event) {
 
        ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
        ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
        enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
        List<String> enableList = new ArrayList<String>();
        enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
        enableMeta.setLore(enableList);
        enable.setItemMeta(enableMeta);
 
        Player player = event.getPlayer();
        PlayerInventory inv = player.getInventory();
 
        players.add(player.getName());
 
        if(player.hasPlayedBefore() == false) {
            inv.setItem(9, enable);
        }
 
    }

Still didn't work

 

Code:java

if(!this.players.contains(event.getPlayer().getName())){

Makes no sense. You add them to the players-list upon joining, yet you check if they are NOT in there

 

Sorry, but what could like do I check if they haven't been added them?

 

No idea what you even want to achieve here.

What you do right now is

OnPlayerJoin -> They get added into this list

OnPlayerInteract -> Only works if they are not in the list

==> It cannot work the way you have it right now, because they are ALWAYS in the list as you add them as soon as they join

 

Basically, I want to make players invisible when the person right clicks with the dye. What I am trying to do is when a player joins the server it add them to the list of people its going to make invisible, then when a person right clicks with dye everyone on that list will disappear for them.

 

If you want a custom item, and do not know java simply make a plugin request. The bukkit community is full of people who would love to help you. infopaste

 

infopaste

OMG OMG OMG! (Sorry, got a little excited XD) I just found your problem! If the code you posted here is 100% accurate, then on line 41, you are executing

Code:java

enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");

but on Line 55, you are executing

Code:java

        if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN+"Player >> Enabled")

You are setting the display name to Players >> Enabled but checking for Player >> Enabled (Without the "s"). You can either add the "s" or you can simply do

Code:java

if(player.getItemInHand().equals(<Your Control Item>){
// Do your stuff
}

 

@mrkirby153 , that is a step in the right direction (dumb on me). Thank you!

buutt.....

The plugins still doesn't work.

I would do that, but I do know the basic's of java and do enjoy coding and learning more.
If I/people can't help me figure what I'm doing wrong with my code, I will request for one.

RizzelDazz, you seem well rounded in java, could you look at my plugin and see what I doing wrong?

Here's the code with mrkirby153 modification:

Code:java

import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
//Register plugins
public void onEnable() {
getServer().getPluginManager().registerEvents(this, this);
}
 
//List for hiding players
ArrayList<String> players = new ArrayList<String>();
 
public void onInventoryClick(InventoryClickEvent event) {
event.setCancelled(true);
}
 
//Removing player from list
public void onQuitEvent(PlayerQuitEvent event) {
Player player = event.getPlayer();
players.remove(player.getName());
}
 
//Adding people to the list and giving them spawn items
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event) {
 
Player player = event.getPlayer();
 
players.add(player.getName());
 
ItemStack compass = new ItemStack(Material.COMPASS);
ItemMeta compassMeta = (ItemMeta) compass.getItemMeta();
compassMeta.setDisplayName(ChatColor.GOLD + "Quick Tranist");
List<String> compassList = new ArrayList<String>();
compassList.add(ChatColor.GRAY + "Right click to open meanu");
compassMeta.setLore(compassList);
compass.setItemMeta(compassMeta);
 
ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
List<String> enableList = new ArrayList<String>();
enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
enableMeta.setLore(enableList);
enable.setItemMeta(enableMeta);
 
PlayerInventory inv = player.getInventory();
 
inv.setItem(9, enable);
 
if(player.hasPlayedBefore() == false) {
inv.setItem(9, enable);
inv.setItem(1, compass);
}
 
}
 
//Visibility Dye
@EventHandler
public void onPlayerClickEvent(PlayerInteractEvent event) {
 
Player player = event.getPlayer();
 
ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
List<String> enableList = new ArrayList<String>();
enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
enableMeta.setLore(enableList);
enable.setItemMeta(enableMeta);
 
ItemStack disable = new ItemStack(Material.INK_SACK, 1, (short) 8);;
ItemMeta disableMeta = (ItemMeta) disable.getItemMeta();
disableMeta.setDisplayName(ChatColor.RED + "Players >> Disabled");
List<String> disableList = new ArrayList<String>();
disableList.add(ChatColor.WHITE + "Right click to enable player visability");
disableMeta.setLore(disableList);
disable.setItemMeta(disableMeta);
 
if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Players >> Enabled")){
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
if(!this.players.contains(event.getPlayer().getName())){
for(Player targetPlayers : Bukkit.getOnlinePlayers()){
if(player.canSee(targetPlayers)){
player.hidePlayer(targetPlayers);
} else{
event.setCancelled(true);
}
this.players.add(player.getName());
}
player.getInventory().removeItem(enable);
player.setItemInHand(disable);
player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_GRAY + "You have toggled player visibility: " + ChatColor.GREEN + "On");
}
}
}
if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED + "Players >> Disabled")){
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
for(Player targetPlayers : Bukkit.getOnlinePlayers()){
if(player.canSee(targetPlayers)){
event.setCancelled(true);
} else {
player.showPlayer(targetPlayers);
}
this.players.remove(player.getName());
}
player.getInventory().removeItem(disable);
player.setItemInHand(enable);
player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_GRAY + "You have toggled player visibility: " + ChatColor.RED + "Off");
}
}
}
 
}
 

 

STILL

you add them to the players list when they join.
BUT check if they are NOT in the list for it to work

It cannot work as I stated already.

 

How do I change that?

 

Either remove the part were you check if they are NOT in the list or remove the part were they get added to the list when they join

 

If i removed the list any new players who join will be visable

 

nowhere in your code you set people invisible if they are on this list

 

you simply just do if(!this.players.contains(event.getPlayer().getName())){...
Just remove the ! in the line...

 

Thank you!

But this is what happens....
with 1 click it toggles twice???

 

after

After you checked one of them just do return; Example:

player.getInventory().removeItem(enable);
player.setItemInHand(disable);
player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_GRAY + "You have toggled player visibility: " + ChatColor.GREEN + "On");
return;
}

 

or to make it codewise "nicer" juse propper else-if construct

 

Thank you Jalau, but now it just says
".... On"
".... Off"
with one right click

How would I save Array Lists so on reload the lists are not lost.

 

Save it to a config file.... Also that can't be.... Add a return after the off say and on say in the same {} as the sendMessage is...

 

Do you mind just correcting it for me and adding in the saving to the config, because I've been stuck on this forever, plus I did move this to plugin request forums but none has corrected it for me.

This is what I have:

Code:java

import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.PlayerInventory;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
    public ArrayList<String> cooldown = new ArrayList<>();
    //List for hiding players
    ArrayList<String> players = new ArrayList<String>();
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    public void onInventoryClick(InventoryClickEvent event) {
        event.setCancelled(true);
    }
 
    //Removing player from list
    public void onQuitEvent(PlayerQuitEvent event) {
        Player player = event.getPlayer();
        players.remove(player.getName());   
    }
 
    //Adding people to the list and giving them spawn items
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        PlayerInventory inv = player.getInventory();
        players.add(player.getName());
 
        ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
        ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
        enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
        List<String> enableList = new ArrayList<String>();
        enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
        enableMeta.setLore(enableList);
        enable.setItemMeta(enableMeta);
 
        // Just here for testing
        inv.setItem(8, enable);
    }
 
    //Visibility Dye
    @EventHandler
    public void onPlayerClickEvent(PlayerInteractEvent event) {
 
        final Player player = event.getPlayer();
 
        ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
        ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
        enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
        List<String> enableList = new ArrayList<String>();
        enableList.add(ChatColor.WHITE + "Right click disable player visability");
        enableMeta.setLore(enableList);
        enable.setItemMeta(enableMeta);
 
        ItemStack disable = new ItemStack(Material.INK_SACK, 1, (short) 8);;
        ItemMeta disableMeta = (ItemMeta) disable.getItemMeta();
        disableMeta.setDisplayName(ChatColor.RED + "Players >> Disabled");
        List<String> disableList = new ArrayList<String>();
        disableList.add(ChatColor.WHITE + "Right click to enable player visability");
        disableMeta.setLore(disableList);
        disable.setItemMeta(disableMeta);
 
        if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Players >> Enabled")){
            if (cooldown.contains(player)) {
                player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "Please wait " + ChatColor.YELLOW +"5 seconds " + ChatColor.GRAY + "to toggled players visibility: " + ChatColor.GREEN + "On");
                event.setCancelled(true);
            } else {
                if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
                    if(this.players.contains(event.getPlayer().getName())){
                        for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                            if(player.canSee(targetPlayers)){
                            player.hidePlayer(targetPlayers);
                            } else{
                                event.setCancelled(true);                       
                            }
                            this.players.add(player.getName());
                        }
                        player.getInventory().removeItem(enable);
                        player.setItemInHand(disable);
                        player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "You have toggled players visibility: " + ChatColor.GREEN + "On");
                        cooldown.add(player.getName());
                        Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
                            public void run() {
                                    cooldown.remove(player.getName());
                            }
                        }, 100);
                        return;
                    }
                }
            }
        }
        if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED + "Players >> Disabled")){
            if (cooldown.contains(player)) {
                player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "Please wait " + ChatColor.YELLOW +"5 seconds " + ChatColor.GRAY + "to toggled players visibility: " + ChatColor.RED + "Off");
                event.setCancelled(true);
            } else {
                if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
                    if(this.players.contains(event.getPlayer().getName())){
                        for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                            if(player.canSee(targetPlayers)){
                                event.setCancelled(true);
                            } else {
                                player.showPlayer(targetPlayers);
                            }
                            this.players.remove(player.getName());
                        }
                    }
                    player.getInventory().removeItem(disable);
                    player.setItemInHand(enable);
                    player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.GRAY + "You have toggled players visibility: " + ChatColor.RED + "Off");
                    cooldown.add(player.getName());
                    Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
                        public void run() {
                            cooldown.remove(player.getName());
                        }
                    }, 100);
                    return;
                }
            }
        }
    }
 
}
 

 

Bummmp

 

so does this work now or did no one ever fix it for u?

 

That code there still doesn't work. But someone helped me fix it yesterday.

 

infopaste Any chance I could get the code? I am trying to do the same thing, but I cant get it to work

 

You are changing the item in line 97. Then in line 110 you are check the item in hand. Because you changed the item, the if-statement is true too. So change the if-statement in line 110 to a else-statement

 

infopaste Could you add me on skype? I need your help