Magic Clock Code?

Hello,
I was wondering if someone could give me the code, to make all players invisible when right click on a item.
Someone thing Like the one on Hive:

How would you code that,

Thank you.

 

infopaste check if player clicks on that item in his inventory, if the item is that green die, go through all online players and set the player for them hidden. Then change the idem to the gray die and change the display name to disabled. If someone clicks on the gray die go through all online players and set the player for them to shown.

 

Spoon feeding code is not the way to learn. To make something like this, you use something like the code I posted bellow. This is from the official "How to make a plugin" wiki. This can be found here.

This is the code from the wiki which relates to making player invisible to others:

Code:java

//Hiding a Player From Another Player
//This will hide the player who used this command from a specified player. Everyone else will be able to see the player.
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
if(cmd.getName().equalsIgnoreCase("HideMe") && args.length == 1) {
if (!(sender instanceof Player)) {
sender.sendMessage("Only players can use this command!");
return true;
}
// After checking to make sure that the sender is a Player, we can safely case it to one.
Player s = (Player) sender;
 
// Gets the player who shouldn't see the sender.
Player target = Bukkit.getServer().getPlayer(args[0]);
if (target == null) {
sender.sendMessage("Player " + args[0] + " is not online.");
return true;
}
// Hides a given Player (s) from someone (target).
target.hidePlayer(s);
return true;
}
return false;
}

You would use arraylsits and booleans to see if the putty is a certain color.

 

I'm new to Bukkit coding, I can read it but have trouble writing it. If someone doesn't mind give me the code to make the magic clock, and changing putty with lores. I could modify it to my liking.

I understand that's what I have to do, but I don't understand what the code is to do so.

 

Then you need to learn how to code in java before attempting bukkit API.

 

I have been working on that, but I really like the code for my hub.

 

infopaste

There's no good knowing how to read it if you want to be a developer. You need to be able to understand how it works.

Maybe read the Plugin Tutorial, then try making something as simple as sending a message, and continue from there.

 

You can't just take code, change a few words and call it your own. That unethical and just not right. Find the plugin you need from the Dev List and just use it. No harm in giving the proper author credit.

 

I only feel it is acceptable to spoonfeed people after they have actually give the problem a legitimate go. infopaste
This should be moved to the request section.

 

Theres an very easy way, Just listen to when theres a click and then check what material it is and then set it to another material and loop through all the online players and if they'r not equal to you then player.hidePlayer(target)

 

I will give it A try and display my code.

 

infopaste Yeah, I'm actually too lazy to code you that. Why don't you just use commands instead of this and when you've collected more experience go back to this and add the inventory thing? Just look if the player has the right permission and entered the right command and then go through all online players and set the sender to hidden for them.

 

Agreed.

 

This is my legitmate try:

Code:java

    @EventHandler
    public void onPlayerFristClickEvent(PlayerInteractEvent event) {
 
        Player player = event.getPlayer();
 
        ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
        ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
        enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
        List<String> enableList = new ArrayList<String>();
        enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
        enableMeta.setLore(enableList);
        enable.setItemMeta(enableMeta);
 
        ItemStack disable = new ItemStack(Material.INK_SACK, 1, (short) 8);;
        ItemMeta disableMeta = (ItemMeta) disable.getItemMeta();
        disableMeta.setDisplayName(ChatColor.RED + "Players >> Disabled");
        List<String> disableList = new ArrayList<String>();
        disableList.add(ChatColor.WHITE + "Right click to enable player visability");
        disableMeta.setLore(disableList);
        disable.setItemMeta(disableMeta);
 
 
 
        if(event.getPlayer().getItemInHand().equals(enable)) {
            if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
                for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                    if(player.canSee(targetPlayers)){
                        player.hidePlayer(targetPlayers);
                        player.getInventory().removeItem(enable);
                        player.setItemInHand(disable);
                    } else{
                        event.setCancelled(true);                       
                    }
                }   
            }
        }
        if(event.getPlayer().getItemInHand().equals(enable)) {
            if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
                for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                    if(player.canSee(targetPlayers)){
                        event.setCancelled(true);
                    } else {
                        player.showPlayer(targetPlayers);
                        player.getInventory().removeItem(disable);
                        player.setItemInHand(enable);
                    }
                }
            }
        }
    }

 

Check the name instead of the ItemStack. p.getItemInHand() this returns and ItemStack, so we get the meta, getItemMeta(). Once we have the meta we can get the Display name. getDisplayName(); From there check the whole string.
It should look something like this:

Code:java

if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN+"Player >> Enabled")){//code here}

EDIT: You also don't need two of the same checks.

 

Code:java

 @EventHandler
public void onPlayerFristClickEvent(PlayerInteractEvent event) {
 
Player player = event.getPlayer();
 
ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
List<String> enableList = new ArrayList<String>();
enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
enableMeta.setLore(enableList);
enable.setItemMeta(enableMeta);
 
ItemStack disable = new ItemStack(Material.INK_SACK, 1, (short) 8);;
ItemMeta disableMeta = (ItemMeta) disable.getItemMeta();
disableMeta.setDisplayName(ChatColor.RED + "Players >> Disabled");
List<String> disableList = new ArrayList<String>();
disableList.add(ChatColor.WHITE + "Right click to enable player visability");
disableMeta.setLore(disableList);
disable.setItemMeta(disableMeta);
 
if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN+"Player >> Enabled")){
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
for(Player targetPlayers : Bukkit.getOnlinePlayers()){
if(player.canSee(targetPlayers)){
player.hidePlayer(targetPlayers);
player.getInventory().removeItem(enable);
player.setItemInHand(disable);
} else{
event.setCancelled(true);
}
}
}
}
if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED+"Player >> Disable")){
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
for(Player targetPlayers : Bukkit.getOnlinePlayers()){
if(player.canSee(targetPlayers)){
event.setCancelled(true);
} else {
player.showPlayer(targetPlayers);
player.getInventory().removeItem(disable);
player.setItemInHand(enable);
}
}
}
}
}

I when in-game spawned myself Lime Dye, gave it the Lore 'Player >> Enabled' in green, and nothing happends.

I don't think I'm understanding what your saying.

 

I think youre doing something wrong, I'll take a look when I get home.

 

Thank you very much I do really appreciate your time.

 

infopaste

Did you register your events? And also, instead of giving the player disabled and removing enabled every time you hide a player, do it AFTER you hide the players.

 

I did register my events. :/
Do you mean doing it like this:

Code:java

if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN+"Player >> Enabled")){
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
for(Player targetPlayers : Bukkit.getOnlinePlayers()){
if(player.canSee(targetPlayers)){
player.hidePlayer(targetPlayers);
} else{
event.setCancelled(true);
}
}
player.getInventory().removeItem(enable);
player.setItemInHand(disable);
}
}
if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED+"Player >> Disable")){
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
for(Player targetPlayers : Bukkit.getOnlinePlayers()){
if(player.canSee(targetPlayers)){
event.setCancelled(true);
} else {
player.showPlayer(targetPlayers);
}
}
player.getInventory().removeItem(disable);
player.setItemInHand(enable);
}
}
}

 

infopaste No he means registering it in your main class.

 

I did do that, I was asking about what he met of taking the item change outside of the loop.

 

You should check out some java tutorials before continuing, the best thing to do is to learn java before attempting to work with the Bukkit API. When I first started I did what you did but later learned I needed to stop and learn java first. Trust me.

Click here for the official oracle tutorial site

 

I have been learning, but I really need this plugin for my hub 'now'. That's why I'm asking if someone could fix it for me, pointing out what I did wrong and where I could make it more clean.

 

If you need it now there are already plugins for it...

 

http://dev.bukkit.org/bukkit-plugins/magic-clock/ , which I currently am using, but I want the items to change, with different lores.

 

Well if you're so insistent upon it I'll give you some help with it.

How to properly check the name of an ItemStack while avoiding plenty of potential NullPointerExceptions:

Code:java

public void checkItem(ItemStack item, String name){
    return item != null && item.hasItemMeta() && item.getItemMeta().hasDisplayName() && item.getItemMeta().getDisplayName().equals(name);
}

As for hiding, showing, you need to loop through the rest of the online players and use yourPlayer.hide/showPlayer(onlinePlayerFromLoop) or something to that effect.

 

Let me show you the hole thing so you see if theirs another mistakes,

Code:java

public class Main extends JavaPlugin implements Listener {
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    ArrayList<String> players = new ArrayList<String>();
 
    @EventHandler
    public void OnJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        players.add(player.getName());
    }
 
    //Magic Clock
    @EventHandler
    public void onPlayerClickEvent(PlayerInteractEvent event) {
 
        Player player = event.getPlayer();
 
        ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
        ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
        enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
        List<String> enableList = new ArrayList<String>();
        enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
        enableMeta.setLore(enableList);
        enable.setItemMeta(enableMeta);
 
        ItemStack disable = new ItemStack(Material.INK_SACK, 1, (short) 8);;
        ItemMeta disableMeta = (ItemMeta) disable.getItemMeta();
        disableMeta.setDisplayName(ChatColor.RED + "Players >> Disabled");
        List<String> disableList = new ArrayList<String>();
        disableList.add(ChatColor.WHITE + "Right click to enable player visability");
        disableMeta.setLore(disableList);
        disable.setItemMeta(disableMeta);
 
        if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN+"Player >> Enabled")){
            if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
                if(!this.players.contains(event.getPlayer().getName())){
                    for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                        if(player.canSee(targetPlayers)){
                            player.hidePlayer(targetPlayers);
                        } else{
                            event.setCancelled(true);                       
                        }
                        this.players.add(event.getPlayer().getName());
                    }
                    player.getInventory().removeItem(enable);
                    player.setItemInHand(disable);
                    player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_GRAY + "You have toggled player visibility: " + ChatColor.GREEN + "On");
                }
            }
        }
        if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED+"Player >> Disable")){
            if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
                for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                    if(player.canSee(targetPlayers)){
                        event.setCancelled(true);
                    } else {
                        player.showPlayer(targetPlayers);
                    }
                    this.players.remove(event.getPlayer().getName());
                }
                player.getInventory().removeItem(disable);
                player.setItemInHand(enable);
                player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_GRAY + "You have toggled player visibility: " + ChatColor.RED + "Off");
            }
        }
    }
}

 

before I work through your code.. What is not working? Any Stacktrace? Can you please provide the full code?

 

There are no errors, It just does't work

Here is my main class:

Code:java

package com.elyniacraft;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
    }
 
    ArrayList<String> players = new ArrayList<String>();
 
    @EventHandler
    public void OnJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        players.add(player.getName());
    }
 
    //Magic Clock
    @EventHandler
    public void onPlayerClickEvent(PlayerInteractEvent event) {
 
        Player player = event.getPlayer();
 
        ItemStack enable = new ItemStack(Material.INK_SACK, 1, (short) 10);
        ItemMeta enableMeta = (ItemMeta) enable.getItemMeta();
        enableMeta.setDisplayName(ChatColor.GREEN + "Players >> Enabled");
        List<String> enableList = new ArrayList<String>();
        enableList.add(ChatColor.WHITE + "Right click to enable to disable player visability");
        enableMeta.setLore(enableList);
        enable.setItemMeta(enableMeta);
 
        ItemStack disable = new ItemStack(Material.INK_SACK, 1, (short) 8);;
        ItemMeta disableMeta = (ItemMeta) disable.getItemMeta();
        disableMeta.setDisplayName(ChatColor.RED + "Players >> Disabled");
        List<String> disableList = new ArrayList<String>();
        disableList.add(ChatColor.WHITE + "Right click to enable player visability");
        disableMeta.setLore(disableList);
        disable.setItemMeta(disableMeta);
 
        if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN+"Player >> Enabled")){
            if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
                if(!this.players.contains(event.getPlayer().getName())){
                    for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                        if(player.canSee(targetPlayers)){
                            player.hidePlayer(targetPlayers);
                        } else{
                            event.setCancelled(true);                       
                        }
                        this.players.add(player.getName());
                    }
                    player.getInventory().removeItem(enable);
                    player.setItemInHand(disable);
                    player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_GRAY + "You have toggled player visibility: " + ChatColor.GREEN + "On");
                }
            }
        }
        if(player.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED+"Player >> Disable")){
            if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK) || event.getAction().equals(Action.RIGHT_CLICK_AIR)){
                for(Player targetPlayers : Bukkit.getOnlinePlayers()){
                    if(player.canSee(targetPlayers)){
                        event.setCancelled(true);
                    } else {
                        player.showPlayer(targetPlayers);
                    }
                    this.players.remove(player.getName());
                }
                player.getInventory().removeItem(disable);
                player.setItemInHand(enable);
                player.sendMessage(ChatColor.DARK_GRAY + "[" + ChatColor.YELLOW + "Visibility" + ChatColor.DARK_GRAY + "] " + ChatColor.DARK_GRAY + "You have toggled player visibility: " + ChatColor.RED + "Off");
            }
        }
    }
}

Here is my plugin.yml

Code:

name: EPlayerVisability
main: com.elyniacraft.Main
version: 1.7.4
description: Custom Plugin for Elynia's Hub Server.
website: elyniacraft.com
author: Lightningrocks27