Looping through blocks in a radius

Hai,

I'm making a mini survival games plugin for someone and I need to get all chests within a sphere (But cube could work) and do stuff with them. I don't know how to do this, so any help would be appreciated

 

You can use this. It returns all blocks in a world between two locations:

Code:java

public List<Block> getRegionBlocks(World world, Location loc1, Location loc2) {
        List<Block> blocks = new ArrayList<Block>();
 
        for(double x = loc1.getX(); x <= loc2.getX(); x++) {
            for(double y = loc1.getY(); y <= loc2.getY(); y++) {
                for(double z = loc1.getZ(); z <= loc2.getZ(); z++) {
                    Location loc = new Location(world, x, y, z);
                    blocks.add(loc.getBlock());
                }
            }
        }
 
        return blocks;
    }

After you get all the blocks with this you need to do something like:

Code:java

public void fillChests(World world, Location loc1, Location loc2) {
        List<Block> blocks = getRegionBlocks(world, loc1, loc2);
 
        for(Block block : blocks) {
            if(block.getType().equals(Material.CHEST)) {
                //Do something.
            }
        }
    }

 

You can try do a loop around player, will be a Cube, then calculate distance to make it Sphere.

Within the loop, you can test what is the type of each block.
But i think there be a better way. I read once something in entity realted with Near [something].

Be careful with large areas, things can go slow.

Something like that. (i write by my mind, check it before use!)

Code:java

Location loc= player.getLocation();
...
for(int x = loc.getX() - radius; x < loc.getx + radius; x++ )
{
  for(int y = loc.getY() - radius; y < loc.getY + radius; y++ )
  {
      for(int z = loc.getZ() - radius; z < loc.getZ + radius; z++ )
      {
            //Block b = get block at (x,y,z)
            // is this a chest ?
      }
  }
}

 

Thanks, this code doesn't seem to be working. It's probably something on my side, this is my code:
(I have the getRegionBlocks exactly same as one posted)

Code:java

public void fillChests(World world, Location loc1, Location loc2) {
 
List<Block> blocks = getRegionBlocks(world, loc1, loc2);
 
for(Block block : blocks) {
 
if(block.getType().equals(Material.CHEST)) {
 
for (Player p : Bukkit.getOnlinePlayers()) {
 
p.sendMessage("New chest");
 
}
 
}
 
}
 
}

My command:

Code:java

 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args ) {
 
Player p = (Player) sender;
 
if (label.equalsIgnoreCase("ch3st")) {
 
fillChests(Bukkit.getWorld("world"), new Location(Bukkit.getWorld("world"), 0, 100, 0), new Location(Bukkit.getWorld("world"), 50, 0, 50));
 
}
 
return false;
 
}

It doesn't say 'new Chest' even though there is a chest in that region. Any help appreciated, thanks

 

I will make the command and check if it works for me.

 

Ok thanks

Shameless bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It doesn't work for me to.​

 

Ok it's the loop that's broken. It returns the same point, both p1 and p2. I'll try and fix it.

I've tried a few things and all I can get working is this, not really what you want but it gets blocks south east from where you're standing in a square:

Code:java

private static List<Block> getArenaBlocks(Location l, int radius)
    {
        World w = l.getWorld();
        int xCoord = (int) l.getX();
        int zCoord = (int) l.getZ();
        int YCoord = (int) l.getY();
 
        List<Block> tempList = new ArrayList<Block>();
        for (int x = 0; x <= 2 * radius; x++)
        {
            for (int z = 0; z <= 2 * radius; z++)
            {
                for (int y = 0; y <= 2 * radius; y++)
                {
                    tempList.add(w.getBlockAt(xCoord + x, YCoord + y, zCoord
                            + z));
                }
            }
        }
        return tempList;
    }

Hope this helps

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I'll try this tonight

 

Did you ever make a fix of tamajpm's code? I need it and can't figure out what's wrong with it

 

Voltex What errors do you get?

To get all blocks around a location (a central one):

Code:java

 
    private static List<Location> getArenaBlocks(Location l, int radius)
    {
    World w = l.getWorld();
    int xCoord = (int) l.getX();
    int zCoord = (int) l.getZ();
    int YCoord = (int) l.getY();
 
    List<Location> tempList = new ArrayList<Location>();
    for (int x = -radius; x <= radius; x++)
    {
    for (int z = -radius; z <= radius; z++)
    {
    for (int y = -radius; y <= radius; y++)
    {
    tempList.add(new Location(w, xCoord + x, YCoord + y, zCoord + z));
    }
    }
    }
    return tempList;
    }
 

That should do the thing. It returns a

 

Worked this out a bit ago, but this looks more efficient. Thanks

 

Voltex
You're welcome
I think there is a way of doing this in an exact sphere, but I prefer not messing around with Math.* Methods

 

Neither, 3D geometry scares me (Plus i'm still a few years short of learning it)

 

Yes, 3D geometry isn't fun, but 3D cubes are the easiest type, spheres are not so... funny

 

Someone else wrote this method and I haven't tested it but it might work.

Code:

    public List<Location> getSphere(Location loc, int r, int h, boolean hollow, boolean sphere, int plus_y) {
        List<Location> circleblocks = new ArrayList<Location>();
        int cx = loc.getBlockX();
        int cy = loc.getBlockY();
        int cz = loc.getBlockZ();
        for (int x = cx - r; x <= cx + r; x++) {
            for (int z = cz - r; z <= cz + r; z++) {
                for (int y = (sphere ? cy - r : cy); y < (sphere ? cy + r : cy + h); y++) {
                    double dist = (cx - x) * (cx - x) + (cz - z) * (cz - z) + (sphere ? (cy - y) * (cy - y) : 0);
                    if (dist < r * r && !(hollow && dist < (r - 1) * (r - 1))) {
                        Location l = new Location(loc.getWorld(), x, y + plus_y, z);
                        circleblocks.add(l);
                    }
                }
            }
        }
        return circleblocks;
    }

 

Loogeh Looks complex..