Looping Player Names From Array List

*_________This Thread Has Been SOLVED_________*


Hello,

I am trying to hide players from an Array List when a player joins the server. The issue is, is that its not hiding the players for the player who joined. Heres my code for the listener (Yes i registered the events in my core class )

Code:java

package me.Airbornz.PrisonExtras;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
 
public class NPListen implements Listener {
 
@EventHandler
public void onJoin(PlayerJoinEvent event){
Player player = event.getPlayer();
if (Core.ninjaplayers.size() > 0){
player.hidePlayer((Player) Core.ninjaplayers);
}
}
 
@EventHandler
public void onQuit(PlayerQuitEvent event){
Player player = event.getPlayer();
String name = player.getName();
Core.ninjaplayers.remove(name);
}
 
}
 

Thanks in Advance
Cole

 

Airbornz You casting an arraylist to a Player

 

Airbornz
I am guessing you are saving the player's name to the list. If so, casting to player will not work. To get the player and hide them, you need to loop through all the players within the list and hide the player not the name.

for (String s : Core.ninjaplayers) //for all the names within the list
player.hidePlayer(Bukkit.getPlayer(s)); //coverts the string to a player object.

 

So then this would be correct?

Code:

package me.Airbornz.PrisonExtras;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
 
public class NPListen implements Listener {
   
    @EventHandler
    public void onJoin(PlayerJoinEvent event){
        Player player = event.getPlayer();
        if (Core.ninjaplayers.size() > 0){
                player.hidePlayer(Core.ninjaplayers);
        }
    }
   
    @EventHandler
    public void onQuit(PlayerQuitEvent event){
        Player player = event.getPlayer();
        String name = player.getName();
        Core.ninjaplayers.remove(name);
    }
 
}

Because my IDE says thats wrong :/

Just saw 97WaterPolos post, testing now.

Players are still able to see players from the list after rejoining/joining :/

Code:java

package me.Airbornz.PrisonExtras;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
 
public class NPListen implements Listener {
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onJoin(PlayerJoinEvent event){
        Player player = event.getPlayer();
        if (Core.ninjaplayers.size() > 0){
            for (String s : Core.ninjaplayers) //for all the names within the list
                player.hidePlayer(Bukkit.getPlayer(s)); //coverts the string to a player object.
        }
    }
 
    @EventHandler
    public void onQuit(PlayerQuitEvent event){
        Player player = event.getPlayer();
        String name = player.getName();
        Core.ninjaplayers.remove(name);
    }
 
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Airbornz
What is your list? IAlso, you need to check and see if the player is IN the list before you remove them from it for your quit event. And you would need 2+ people to test this. Also try adding debug messages to see what went wrong, and try not to copy and paste code :L