Logging - The proper way ?

As many of you know, you can log to the console in three ways:

Code:java

/* Way 1 */
System.out.println("Message");
 
/* Way 2 */
Logger log = Logger.getLogger("Minecraft");
log.info("Message!");
 
/* Way 3 */
Logger log = Bukkit.getServer().getLogger();
log.info("Message!");

How do you log to the console? I normally use way 3, but for quick debugging way 1. When I was new to the Craftbukkit API, I used way 2.

EDIT: I accidently hit return when creating the poll. The poll was created without me adding the options 'Way 3' and 'Other.' Just respond with what way you log to the console!

 

Code:java

public class Chat(){
    private static Logger log = Logger.getLogger("Minecraft");
 
    public static void console(String msg){
        log.info("[PluginName] " + msg);
    }
 
    public static void console(String[] msg){
        for(String s : msg){
            log.info("[PluginName] " + s);
        }
    }
}
 
//From another class
Chat.console("Hello World!");

This allows me to create multiple types of message output as well as include sending messages/errors to players.

 

I also have a class named "Log."

 

I use JavaPlugin.getLogger().info("Hi");
this has advantages that [pluginname] is automaticly is added to the log messages

 

Bukkit offers getLogger() for a reason, it's best that you use that one.

You can also use getConsoleSender().sendMessage(); to send colored console messages.

But for flexibility just use Bukkit/getServer().getLogger() and do not store it in a field.

 

Why don't you store it into a field? I do that, considering I have a separate class for logging.

 

number1_Master
I forgot to be specific, I meant fields in the main class
getLogger() returns null if you're calling it before onLoad() because it needs the plugin name which is not available at that point.

Examples:

Code:

private Logger log = getLogger();

@Override
public void onEnable()
{
    log.info("stuff"); // bad, NullPointerException, getLogger() is called when class is loaded so plugin name is not availalbe.

    log = getLogger(); // good
    log.info("stuff"); // good

    getLogger().info("stuff"); // good
}

 

I see what you are saying.

 

This is what i use:
https://github.com/Chilinot/Surviva...vivalgamesmultiverse/utils/ConsoleLogger.java

It allows me to listen to my plugins messages ingame aswell as see what class/object said what. The output is also colour-coded, both in console and ingame.

An example how it is initialized:

Code:

public ChestManager(Main instance) {
    this.plugin = instance;
    this.logger = new ConsoleLogger(this.plugin, "ChestManager");
 
    this.randomizedchests = new ArrayList<Location>();
    this.loadItemList();
 
    this.generator = new Random(System.currentTimeMillis());
 
    this.logger.debug("Initiated");
}

 

Very interesting. For the custom plugins on my server, I also added color codes so this way I can clearly see what it is going on in the console!

 

Looking at your code,

Code:java

 
for(String playername : listeners) {
			Player player = plugin.getServer().getPlayer(playername);
 
			if(player != null) {
				player.sendMessage(label + " [" + this.name + "] - " + ChatColor.WHITE + msg);
			}
			else {
				listeners.remove(playername);
			}
		}

as far I know, if you edit a list while looping over it gives an concurent modifed exception, did you test for it?

 

No, that logger was something i made when bukkit added ansi to their library. Haven't looked at it much since then. Thanks for pointing it out, ill fix it when i can

EDIT:
Problem is now fixed, also added a synchronized wrapper around the set since i like being able to use the loggers in separate threads.