Listeners Not listening.

NoMansLand · Feb 25, 2013

Hello Again Bukkit,

I have been writing this plugin for 2 days now, fixed a prior issue by doing a re-write and now I can't get my event listeners to listen.

there's 2 java files: Main.java & Listeners.java

This is Main.java:

package net.myfallen.gl;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.text.SimpleDateFormat;
import java.util.logging.Logger;

import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
import net.myfallen.gl.Listeners;

public class Main extends JavaPlugin implements Listener {

public void onEnable() {
Logger log = getLogger();
log.info("[GL] - GL is loading....");
log.info("[GL] - GL is implementing the listeners.......");
getServer().getPluginManager().registerEvents(new Listeners(), this);
log.info("[GL] - GL has implemented the listeners.");
log.info("[GL] - Checking for Database Connection. I will close this after it's complete.");
Connection connection = null;
try {
connection = DriverManager.getConnection("REMOVED FOR SECURITY REASONS.");
} catch (SQLException e) {
log.info("[GL] - Error Could NOT establish MySQL Connection. Please see crash log below.");
// TODO Auto-generated catch block
e.printStackTrace();
}
if(connection != null) {
log.info("[GL] - I have found the successful MySQL database. YAY!");
} else {
log.info("[GL] - I cannot connect to the database, Please see issue above and/or below.");
}
log.info("[GL] - GL Has loaded successfuly.");
try {
connection.close();
} catch (SQLException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}

}
public void onDisable() {
Logger log = getLogger();

log.info("[GL] - GL is closing down..");
log.info("[GL] - Have a good day.");
}

}
Click to expand...

This is Listeners.java:

package net.myfallen.gl;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.text.SimpleDateFormat;
import java.util.logging.Logger;

import org.bukkit.command.Command;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.java.JavaPlugin;

public class Listeners extends JavaPlugin implements Listener {

@EventHandler
public void onPlayerJoin(PlayerJoinEvent event) throws SQLException {
Player joinedPlayer = event.getPlayer();
Logger log = getLogger();
log.info("[GL] - A player has joined the server. Performing Integrity Tests.");
if(joinedPlayer.isOp()) {
String query = "SELECT * FROM users WHERE username='" + joinedPlayer + "' LIMIT 1";
Connection con = DriverManager.getConnection("REMOVED FOR SECURITY");
Statement stmt = con.createStatement();
ResultSet rs = stmt.executeQuery(query);

if(rs.next() == true) {
log.info("[GL] - The player has been found in the database.");
log.info("[GL] - I will be updating their login times.");
SimpleDateFormat dt = new SimpleDateFormat("dd-MM-yyyy");
String userJoinedExists = "INSERT INTO logging(username,joindate) VALUES ('" + joinedPlayer + "','" + dt + "')";
stmt.executeQuery(userJoinedExists);
log.info("[GL] - User has logged in and data is upto date.");
} else {
log.info("[GL] - The player has not been found in the database. Performing Sync");
String update = "INSERT INTO users(username) VALUES ('" + joinedPlayer + "')";
stmt.executeQuery(update);
log.info("[GL] - The player has synced into the database.");
}
} else {
log.info("[GL] - Player failed the integrity test... Please do NOT report this, this is not an issue with me, this is an issue with them.");
}
}
@EventHandler
public void onPlayerQuit(PlayerQuitEvent event) throws SQLException {
Player quitPlayer = event.getPlayer();
Logger log = getLogger();
log.info("[GL] - A player has left the server. Performing Final Integrity Tests.");
if(quitPlayer.isOp()) {
Connection con = DriverManager.getConnection("REMOVED FOR SECURITY");
String query = "SELECT * FROM logging WHERE username='" + quitPlayer + "' AND exitdate=' '";
Statement stmt = con.createStatement();
stmt.executeQuery(query);
ResultSet rs = stmt.executeQuery(query);
String id;
while(rs.next()) {
id = rs.getString(1);
SimpleDateFormat dt = new SimpleDateFormat("dd-MM-yyyy");
log.info("[GL] - User ID Found, User ID: " + id + ", performing final sync.");
String query2 = "UPDATE logging SET exitdate='" + dt + "' WHERE id='" + id + "'";
stmt.executeQuery(query2);
log.info("[GL] - The player has been removed.");
}
} else {
log.info("[GL] - Player failed the integrity test... Please do NOT report this, this is not an issue with me, this is an issue with them.");
}
}
@EventHandler
public void onPlayerCommandPreprocess(Player player, Command cmd) throws SQLException {
Player playername = (Player) player;
String commandName = cmd.getName();
Logger log = getLogger();
log.info("[GL] - A Player has sent a command, Performing Integrity Tests.");
if(playername.isOp()) {
Connection con = DriverManager.getConnection("REMOVED FOR SECURITY");
SimpleDateFormat dt = new SimpleDateFormat("dd-MM-yyyy");
SimpleDateFormat tf = new SimpleDateFormat("mm:HH:ss");
Statement stmt = con.createStatement();
String query = "INSERT INTO commands (username,commandIssueTime,command,commandIssueDate) VALUES ('" + playername + "','" + tf + "','" + commandName + "','" + dt + "')";
stmt.executeQuery(query);
log.info("[GL] - The information has been updated.");

} else {
log.info("[GL] - Player failed the integrity test... Please do NOT report this, this is not an issue with me, this is an issue with them.");
}
}

}
Click to expand...

Thank you for your help.

Tirelessly · Feb 25, 2013

Listener class shouldn't extend JavaPlugin.

NoMansLand · Feb 25, 2013

With out it, log.getLogger() doesnt work.

Tirelessly · Feb 25, 2013

NoMansLand said: ↑

With out it, log.getLogger() doesnt work.
Click to expand...

So use an instance of your main class passed via the constructor to call JavaPlugin methods

NoMansLand · Feb 25, 2013

1:24:04 PM
CONSOLE:
[SEVERE] [GL] GL v0.1 attempted to register an invalid EventHandler method signature "public void net.myfallen.gl.Listeners.onPlayerCommandPreprocess(org.bukkit.entity.Player,org.bukkit.command.Command) throws java.sql.SQLException" in class net.myfallen.gl.Listeners
any idea why I would get this then onPlayerCommandPreprocess?

chasechocolate · May 31, 2016

Why do you have the @EventHandler annotation on a method that is not an event listener (onPlayerCommandPreprocess)?

NoMansLand Oh and what Tirelessly is saying:
Code:java
//In your Listeners class:
private Main plugin;
public Listeners(Main plugin){
  this.plugin = plugin;
}
And then the logger can be accessed with:
Code:java
plugin.getLogger().info("Hello");
EDIT by Moderator: merged posts, please use the edit button instead of double posting.

NoMansLand · Feb 25, 2013

I figured that out afterwards and then repeatedly banged my head into the desk for being an idiot..

Didn't help much.. but now i'm getting this:

2013-02-25 21:32:54 [SEVERE] Could not pass event PlayerJoinEvent to GL v0.1
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
at net.minecraft.server.v1_4_R1.PlayerList.c(PlayerList.java:159)
at net.minecraft.server.v1_4_R1.PlayerList.a(PlayerList.java:98)
at net.minecraft.server.v1_4_R1.PendingConnection.d(PendingConnection.java:130)
at net.minecraft.server.v1_4_R1.PendingConnection.c(PendingConnection.java:45)
at net.minecraft.server.v1_4_R1.DedicatedServerConnectionThread.a(DedicatedServerConnectionThread.java:44)
at net.minecraft.server.v1_4_R1.DedicatedServerConnection.b(SourceFile:29)
at net.minecraft.server.v1_4_R1.MinecraftServer.r(MinecraftServer.java:598)
at net.minecraft.server.v1_4_R1.DedicatedServer.r(DedicatedServer.java:224)
at net.minecraft.server.v1_4_R1.MinecraftServer.q(MinecraftServer.java:494)
at net.minecraft.server.v1_4_R1.MinecraftServer.run(MinecraftServer.java:427)
at net.minecraft.server.v1_4_R1.ThreadServerApplication.run(SourceFile:849)
Caused by: java.lang.NullPointerException
at net.myfallen.gl.Listeners.onPlayerJoin(Listeners.java:24)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
... 14 more

The exact same Player joinPlayer = player.getEvent(); works in other plugins that i've developed..

chasechocolate · Feb 25, 2013

NoMansLand said: ↑

The exact same Player joinPlayer = player.getEvent(); works in other plugins that i've developed..
Click to expand...

player.getEvent()? *event.getPlayer()

NoMansLand · May 31, 2016

Sorry typo, but that's what I have in the script and it's giving the the null error.

Line 24: plugin.getLogger().info("[GL] - A player has joined the server. Performing Integrity Tests.");
(listeners.java)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

AmShaegar · Feb 26, 2013

In onEnable() it should be like this:

getServer().getPluginManager().registerEvents(new Listeners(this), this);

In Listeners it should be like this:

private Main plugin;
public Listeners(Main plugin){

this.plugin = plugin;
}

Oh and:

public class Main extends JavaPlugin implements Listener {

NoMansLand · Feb 26, 2013

AmShaegar said: ↑

In onEnable() it should be like this:

getServer().getPluginManager().registerEvents(new Listeners(this), this);

In Listeners it should be like this:

private Main plugin;
public Listeners(Main plugin){

this.plugin = plugin;
}

Oh and:

public class Main extends JavaPlugin implements Listener {
Click to expand...

I replaced all the "log.info" with System.out.Print() and it works now, but do I have to set the commands I want submitted with " public void onPlayerCommandPreprocess(Player player, Command cmd) throws SQLException {" or is there a way to log every command done?

fireblast709 · Feb 26, 2013

It happens because you have a syntax error in your SQL. You might want to get the query where it happens and see where exactly you made that mistake.

NoMansLand · Feb 26, 2013

fireblast709 said: ↑

It happens because you have a syntax error in your SQL. You might want to get the query where it happens and see where exactly you made that mistake.
Click to expand...

If I had a Syntax error or any error in my SQL it would come up with something, would it not? I'd like to think so.. or even print out the line that a command has been sent.

Here's the java: http://pastebin.com/eBdhjQeM

The plugin.yml

name: GL
main: net.myfallen.gl.Main
version: 0.1
website: http://www.myfallen.net - YAY!
author: NoMansLand_MFGC
Click to expand...

The only issue now is that it wont get the commands

NoMansLand · Mar 1, 2013

Does anyone have any idea how to get all the commands listened to?

Log in or Sign up

Listeners Not listening.

NoMansLand

Tirelessly

NoMansLand

Tirelessly

NoMansLand

chasechocolate

NoMansLand

chasechocolate

NoMansLand

AmShaegar

NoMansLand

fireblast709

NoMansLand

NoMansLand

Share This Page

Listeners Not listening.

Share This Page

Useful Searches