Launch Exploding Firework without Launch Sound. The Quest for Answers

Alright everyone, in this thread, we are going to finally find the answer to the ultimate Bukkit question.

How do I spawn an exploding firework, without a launch sound, and make it work 100% of the time?

Currently, all of the options I have found on the forums have yielded results that either work only about 50% of the time (other 50% firework just spawns and is destroyed), or have the launching sound, which we don't want.

Here are some of the current methods, and the results they yield

Works: 80-90% of the time
No launching sound.

Code:java

 
 
                try {
                    // Bukkity load (CraftFirework)
                    World world = loc.getWorld();
                    final Firework fw = (Firework) world.spawn(loc, Firework.class);
                    // the net.minecraft.server.World
                    Object nms_world = null;
                    Object nms_firework = null;
        /*
        * The reflection part, this gives us access to funky ways of messing around with things
        */
                    if (world_getHandle == null) {
                        // get the methods of the craftbukkit objects
                        world_getHandle = getMethod(world.getClass(), "getHandle");
                        firework_getHandle = getMethod(fw.getClass(), "getHandle");
                    }
                    // invoke with no arguments
                    nms_world = world_getHandle.invoke(world, (Object[]) null);
                    nms_firework = firework_getHandle.invoke(fw, (Object[]) null);
                    // null checks are fast, so having this seperate is ok
                    if (nms_world_broadcastEntityEffect == null) {
                        // get the method of the nms_world
                        nms_world_broadcastEntityEffect = getMethod(nms_world.getClass(), "broadcastEntityEffect");
                    }
        /*
        * Now we mess with the metadata, allowing nice clean spawning of a pretty firework (look, pretty lights!)
        */
                    // metadata load
                    FireworkMeta data = (FireworkMeta) fw.getFireworkMeta();
                    // clear existing
                    data.clearEffects();
                    // power of one
                    data.setPower(1);
                    // add the effect
                    data.addEffect(fe);
                    // set the meta
                    fw.setFireworkMeta(data);
        /*
        * Finally, we broadcast the entity effect then kill our fireworks object
        */
                    // invoke with arguments
                    nms_world_broadcastEntityEffect.invoke(nms_world, new Object[]{nms_firework, (byte) 17});
                    fw.detonate();
                    fw.remove();
                } catch (Exception e) {
                    e.printStackTrace();
                }

 

NerdsWBNerds
With the solution above tiny amounts of lag (more than a few players) drastically reduces the percentage of it working. There was a time when that class woken nearly 100% D:

 

There has got to be some way to do this and have it work 100% of the time

 

NerdsWBNerds
Quantum64
This quest for the answer is similar to a question I asked several months ago. I received advise to use packets to allow clients to visually see lightning, but without playing the lightning sound. You may need to do something similar here.
Links:
http://forums.bukkit.org/threads/sound-manipulation-of-lightning.251081/
http://forums.bukkit.org/threads/using-packets-for-lightning-to-avoid-lightning-sound.251383/
Basically, I needed to change the class of lightning and override the sound being played.

Word of warning: Packets aren't easy to manage, and often need to be changed for EVERY bukkit update.

Hope this helped,
- Minty

 

NerdsWBNerds
https://forums.bukkit.org/threads/util-play-firework-explosions-v2-1-nms.243217/