Solved KillStreaks

ajs333 you can also do

Code:java

Player killer = (Player)e.getEntity().getKiller()

Just be sure to check the the person who died is a player and the killer himself using what AoH_Ruthless says

 

boysnnoco
Thank you for fixing that issue but now I get a internal error that says:

15:43:23 [SEVERE] Could not pass event PlayerDeathEvent to sKits v1
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
at org.bukkit.craftbukkit.v1_6_R3.event.CraftEventFactory.callPlayerDeathEvent(CraftEventFactory.java:344)
at net.minecraft.server.v1_6_R3.EntityPlayer.die(EntityPlayer.java:312)
at net.minecraft.server.v1_6_R3.EntityLiving.damageEntity(EntityLiving.java:710)
at net.minecraft.server.v1_6_R3.EntityHuman.damageEntity(EntityHuman.java:714)
at net.minecraft.server.v1_6_R3.EntityPlayer.damageEntity(EntityPlayer.java:383)
at net.minecraft.server.v1_6_R3.EntityHuman.attack(EntityHuman.java:884)
at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:1121)
at net.minecraft.server.v1_6_R3.Packet7UseEntity.handle(SourceFile:36)
at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296)
at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:116)
at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:30)
at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592)
at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227)
at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488)
at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421)
at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
Caused by: java.lang.NullPointerException
at sKits.events.KillStreak.onPlayerDeath1(KillStreak.java:36)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)

... 20 more

Here is line 36:

Code:

int kills = killstreak.get(killer.getName());

 

ajs333 make sure there is a killer by doing a simple check

Code:java

if(killer != null){
//Code
}

 

boysnnoco
Still get the same error...

 

ajs333 make sure that the killer is in/ has a number in the array list
so do

Code:java

if(killstreak.get(killer.getName() != null){
//Code
}

 

boysnnoco
Just to make sure I am understanding what you are telling me.. can you check this..

Code:

@EventHandler
    public void onPlayerDeath1(PlayerDeathEvent e) {
        if(e.getEntity().getKiller() instanceof Player) {
            Player killer = (Player) e.getEntity().getKiller();
            Player killed = e.getEntity();
            if(killer != null){
                if(killstreak.get(killer.getName()) != null){
                    if(!killstreak.containsKey(killer.getName())) {
                        killstreak.put(killer.getName(), 0);
                    }
                    killstreak.put(killer.getName(),
                            killstreak.get(killer.getName() +1));
                    if(killstreak.containsKey(killed.getName())) {
                        killstreak.remove(killed.getName());
                    }
                    int kills = killstreak.get(killer.getName());
                    if(kills == 1) {
                        Bukkit.broadcastMessage(ChatColor.GOLD + killer.getName() + " has a 1 killstreak!");
                    }
                }
            }
        }
    }

 

ajs333 you want to check if it is null then add them to the hashmap my bad

 

boysnnoco
There are no error in my code nor are there any internal errors but it doesn't broadcast my message...

Here is my whole class then:
Keep in mind that my main class is called sKits

Code:

package sKits.events;
 
import java.util.HashMap;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
 
import sKits.sKits;
 
public class KillStreak implements Listener{
   
    private HashMap<String, Integer> killstreak = new HashMap<String, Integer>();
   
    sKits kits;
    public KillStreak(sKits plugin) {
        kits = plugin;
    }
   
    @EventHandler
    public void onPlayerDeath1(PlayerDeathEvent e) {
        if(e.getEntity().getKiller() instanceof Player) {
            Player killer = (Player) e.getEntity().getKiller();
            Player killed = e.getEntity();
            if(killer != null){
                if(killstreak.get(killer.getName()) != null){
                    if(!killstreak.containsKey(killer.getName())) {
                        killstreak.put(killer.getName(), 0);
                    }
                    killstreak.put(killer.getName(),
                            killstreak.get(killer.getName() +1));
                    if(killstreak.containsKey(killed.getName())) {
                        killstreak.remove(killed.getName());
                    }
                    int kills = killstreak.get(killer.getName());
                    if(kills == 1) {
                        Bukkit.broadcastMessage(ChatColor.GOLD + killer.getName() + " has a 1 killstreak!");
                    }
                    if(kills == 3) {
                        Bukkit.broadcastMessage(ChatColor.GOLD + killer.getName() + " has a 3 killstreak!");
                    }
                }
            }
        }
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ajs333 are you registering your events?
if so try this (I basically rebuilt your listener):

Code:java

    @EventHandler
    public void onPlayerDeath1(PlayerDeathEvent e) {
        if(e.getEntity().getKiller() instanceof Player) {
            Player killer = (Player) e.getEntity().getKiller();
            Player killed = e.getEntity();
            if(killer != null){
                if(killstreak.get(killer.getName()) != null){
                    if(killstreak.get(killer.getName()) != null){
                        int k = killstreak.get(killer.getName()) + 1;
                        killstreak.put(killer.getName(),k);
                        if(killstreak.containsKey(killed.getName())) {
                            killstreak.remove(killed.getName());
                        }
                        int kills = killstreak.get(killer.getName());
                    }else{
                        if(kills == 1) {
                            Bukkit.broadcastMessage(ChatColor.GOLD + killer.getName() + " has a 1 killstreak!");
                        } killstreak.put(killer.getName(), 1);
                    }
                }
            }
        }
    }

I don't know if it works

 

boysnnoco
Wait, this is how you register events right?

Code:

pm.registerEvents(new KillStreak(), this);

 

ajs333 yeah (as long as it is in your onEnable() )

 

boysnnoco
Yea, in my main class under the onEnable()

I tested it and it still doesn't work...
Is there a way I can test to see if the event is being called?

 

add a debug message like Bukkit.broadcastMessage("FIRED");
at the top of your event
ajs333

 

boysnnoco
Nope the event isn't being called... :/

 

ajs333 show me your main class please

 

boysnnoco
Oh, wait I forgot one thing... but when I kill a player it now says HI!

Code:

@EventHandler
    public void onPlayerDeath1(PlayerDeathEvent e) {
        Bukkit.broadcastMessage("Hi");
        if(e.getEntity().getKiller() instanceof Player) {
            Player killer = (Player) e.getEntity().getKiller();
            Player killed = e.getEntity();
            if(killer != null){
                if(killstreak.get(killer.getName()) != null){
                    if(killstreak.get(killer.getName()) != null){
                        int k = killstreak.get(killer.getName()) + 1;
                        killstreak.put(killer.getName(),k);
                        if(killstreak.containsKey(killed.getName())) {
                            killstreak.remove(killed.getName());
                        }
                    }else{
                        int kills = killstreak.get(killer.getName());
                        if(kills == 1) {
                            Bukkit.broadcastMessage(ChatColor.GOLD + killer.getName() + " has a 1 killstreak!");
                        } killstreak.put(killer.getName(), 1);
                    }
                }
            }
        }
    }

Edit:
When ever anyone dies the server says "HI"

 

ajs333 that's because your saying 'hi' when someone dies

 

boysnnoco
Ik that but it doesn't broadcast the KillStreak message...

 

ajs333 this is what I have (and it seems to work)

Code:java

    public final HashMap<String, Integer> killstreak = new HashMap<String, Integer>();   
    @EventHandler
    public void onPlayerDeath1(PlayerDeathEvent e) {
        Bukkit.broadcastMessage("Hi");
        if(e.getEntity().getKiller() instanceof Player) {
            Player killer = (Player) e.getEntity().getKiller();
            Player killed = e.getEntity();
            if(killstreak.get(killer.getName()) != null){
                int k = killstreak.get(killer.getName()) + 1;
                killstreak.put(killer.getName(),k);
                if(killstreak.containsKey(killed.getName())) {
                    killstreak.remove(killed.getName());
                }
            }else{
                killstreak.put(killer.getName(), 1);
                Bukkit.broadcastMessage(ChatColor.GOLD + killer.getName() + " has a 1 killstreak!");
            }
        }
    }

 

boysnnoco
The issue is that it isn't removing their killstreak once they die...

 

ajs333 do killstreak.remove(killed.getName());

 

boysnnoco
Its in there so I wasn't sure why it wasn't removing the killed person...

Code:

if(killstreak.containsKey(killed.getName())) {
                    killstreak.remove(killed.getName());
                }

Edit:
Hmm what could fix that issue?

 

ajs333 the only thing I could think of is to make a seperate event just for removing people out of the hashmap

 

boysnnoco
Ok, I'll try that!

 

boysnnoco why would he need to create a seperate event?

 

Pizza371
If you were to test what boysnnoco gave me, you would notice that once the player dies it doesn't remover their killstreak so i'm not sure how to do that... He suggested to make a new Event... How would you do it?

 

Pizza371 I was running out of ideas, I didn't quite understand why it wasn't removing the player but wth... lol

ajs333

Code:java

@EventHandler
public void onKillStreakRemove(PlayerDeathEvent e){
//Code that removes the player
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

boysnnoco ajs333 looks like you two's are nesting the the removal inside an if statement that has nothing to do with it, yet again, I could be reading the code wrong..
here:

Code:

 @EventHandler
    public void onPlayerDeath1(PlayerDeathEvent e) {
        Bukkit.broadcastMessage("Hi");
        Player killed = e.getEntity();
        if(killstreak.containsKey(killed.getName())) killstreak.remove(killed.getName());
        if(e.getEntity().getKiller() instanceof Player) {
            Player killer = (Player) e.getEntity().getKiller();
            if(killstreak.get(killer.getName()) != null){
                int k = killstreak.get(killer.getName()) + 1;
                killstreak.put(killer.getName(),k);
            }else{
                killstreak.put(killer.getName(), 1);
                Bukkit.broadcastMessage(ChatColor.GOLD + killer.getName() + " has a 1 killstreak!");
            }
        }
    }

 

@Pizzaa371 that must be it im really tired and I didn't notice it lol

 

boysnnoco ajs333 Pizza371
I did not read the last 2 posts, so this may be a repeat ...
The formatting of the if/else blocks is pretty off.
In particular, it's this chunk:

Code:java

if(killstreak.get(killer.getName()) != null){
int k = killstreak.get(killer.getName()) + 1;
killstreak.put(killer.getName(),k);
if(killstreak.containsKey(killed.getName())) {
killstreak.remove(killed.getName());
}
}else{
killstreak.put(killer.getName(), 1);
Bukkit.broadcastMessage(ChatColor.GOLD + killer.getName() + " has a 1 killstreak!");
}

It's much more efficient to use this:

Code:java

if(!killstreak.containsKey(killer.getName())) killstreak.put(killer.getName(), 0) //If they aren't in the killstreak map, add them with score 0.
Bukkit.broadcastMessage("debug1"); //Add debug messages to see how far it gets
int kills = killstreak.get(killer.getName()); //Casts a variable (this is a safe place because it ensures the killer is in the map)
killstreak.put(killer.getName(), kills + 1); //Either way it will add 1 to the killstreak.
Bukkit.broadcastMessage("debug2");
if (kills == 1) {
Bukkit.broadcastMessage("debug3");
}

Just edit out the chunk of code I was talking about and paste that in (understand it first!). I freehanded it on the forums so it may be a little off so be wary of that