Increased Map Height (128+) Test Plugin

Discussion in 'Bukkit Discussion' started by DeLux, Nov 29, 2011.

Thread Status:
Not open for further replies.
  1. Offline

    drakcore

    Have any of you seen Mine UP ?
    Maybe with the use of spout you could merely link the worlds with one another without affecting the original worlds/file structure, just a "simple" link to each world via their coordinates.
     
  2. Offline

    croxis

    The objective with this isn't world stacking (plugins already do this) but tall buildings, mountains, and deep pits.
     
  3. Offline

    sintri

    Still bit discouraging to see after all this time still can't get a bukkit plugin/mod to up the height while standard mods have already reached far past 256.
     
    Erik Vikersveen likes this.
  4. Offline

    Killerrabbit

    Indeed... my users have been crying for increased heigh in SMP for ages, but considering it's one of the most wanted features, no dev's seem intrested in it, and mojang is just releasing sheep eat grass updates..
     
    efstajas likes this.
  5. Offline

    croxis

    I've posted my mod, but site rules prevent releasing 3rd party builds. I don't think it will work as a plugin, too many things are still hardcoded in the vanilla code at 128.
     
  6. Offline

    Efflixi

    Can someone explain to me how to use croxis patch? I see the code but no instructions on what to do.
     
  7. Offline

    croxis

    Patch files are applied using a patch application program (there are too many for the three OSs to give any specific instructions).

    Also here is my github branch as the GPL requires me to provide the source upon request. It has not been updated for 1.1 so someone will need to merge that in.
     
  8. Offline

    plasmas222

    Just leaving a small comment to show support. Keep it up. :)
     
  9. Offline

    Hazilo

    I've updated both my craftbukkit and my spoutplugin github forks for 1.1

    Want an example of the land generated? Here comes:
    [​IMG]
    [​IMG]
     
  10. Offline

    Nam

    I tried to compile this and I get the following error when trying to compile craftbukkit...

    PHP:
    [ERRORFailed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compileon project craftbukkitCompilation failureCompilation failure:
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java:[43,7errorCraftPlayer is not abstract and does not override abstract method setBedSpawnLocation(Locationin Player
    [ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/CraftWorld.java:[46,7errorCraftWorld is not abstract and does not override abstract method <T>getEntitiesByClass(Class<T>...) in World
    [ERROR]
    [
    ERRORcould not parse error message:  where T is a type-variable:
    [
    ERRORextends Entity declared in method <T>getEntitiesByClass(Class<T>...)
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftAnimals.java:7errorCraftAnimals is not abstract and does not override abstract method setBreed(boolean) in Animals
    [ERROR] public class CraftAnimals extends CraftCreature implements Animals {
    [
    ERROR] ^
    [
    ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftCow.java:[7,7errorCraftCow is not abstract and does not override abstract method setBreed(boolean) in Animals
    [ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftPig.java:[7,7errorCraftPig is not abstract and does not override abstract method setBreed(boolean) in Animals
    [ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/block/CraftBlock.java:[15,7errorCraftBlock is not abstract and does not override abstract method getDrops(ItemStackin Block
    [ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftSheep.java:[9,7errorCraftSheep is not abstract and does not override abstract method setBreed(boolean) in Animals
    [ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftChicken.java:[7,7errorCraftChicken is not abstract and does not override abstract method setBreed(boolean) in Animals
    [ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/CraftOfflinePlayer.java:[17,7errorCraftOfflinePlayer is not abstract and does not override abstract method getBedSpawnLocation() in OfflinePlayer
    [ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftWolf.java:[10,7errorCraftWolf is not abstract and does not override abstract method setBreed(boolean) in Animals
    [ERROR]
    [
    ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftMushroomCow.java:[7,7errorCraftMushroomCow is not abstract and does not override abstract method setBreed(boolean) in Animals
    [ERROR] -> [Help 1]
    org.apache.maven.lifecycle.LifecycleExecutionExceptionFailed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compileon project craftbukkitCompilation failure
            at org
    .apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
            
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
            
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
            
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
            
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
            
    at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
            
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
            
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
            
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
            
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
            
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
            
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
            
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
            
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            
    at java.lang.reflect.Method.invoke(Method.java:601)
            
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
            
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
            
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
            
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
    Caused byorg.apache.maven.plugin.CompilationFailureExceptionCompilation failure
            at org
    .apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:516)
            
    at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:114)
            
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
            
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
            ... 
    19 more
    [ERROR]
    [
    ERRORRe-run Maven using the -switch to enable full debug logging.
     
  11. Offline

    Isocadia

    Any instructions on how to compile and install these? Or could you maybe send them to my email adress thom272@hotmail.com ?

    Also, how would I tell the spoutcraft client the world is 256 high or does it do that automaticly? And is this possible with a 512 high world?
     
  12. Offline

    Hazilo

    Two things: either your bukkit repository is not up-to-date or too recent for my fork (updated yesterday), and you are using maven compile instead of maven clean install.

    One link: http://wiki.bukkit.org/Setting_Up_Your_Workspace
    You need bukkit repository too.
    The height is automatically sent to the spoutcraft.
    Due to the chunk design, I think that it is not possible to go over 256 height without further changes.
     
  13. Offline

    Nam

    I went to https://github.com/Bukkit/Bukkit yesterday and downloaded the https://github.com/Bukkit/Bukkit/tarball/master file (Bukkit-Bukkit-1.0.1-R1-64-ga210df5.tar.gz). I extracted it and ran "mvn clean install". This worked without any problems.
    I than went to https://github.com/lama-kun/CraftBukkit and downloaded the https://github.com/lama-kun/CraftBukkit/tarball/master file (lama-kun-CraftBukkit-1.0.1-R1-27-gf7b9024.tar.gz). I extracted it and ran "mvn clean package", "mvn package", or "mvn clean install" and I get the same compilation error.

    Any suggestions? I would really like to be able to utilize 256 tall worlds. :)
     
  14. Offline

    Hazilo

    Both have wrong names, this is part of what messes up the compilation I think. Also, use git to get the repositories instead of the archive version, this might help.
     
  15. Offline

    Nam

    Also, after reading the note "Note: this is not needed as the repository we use has Bukkit too, but you might have a newer one (with your own changes :D)" I tried to delete my ~/.m2, then just do "mvn clean package" for lama-kun-CraftBukkit-1.0.1-R1-27-gf7b9024.tar.gz but I get the same error.

    Not sure what wrong file names have to do with it, but I tried git to get the repositories and then tried "mvn clean package", but I get the exact same error. The https://github.com/lama-kun/CraftBukkit/tarball/master link is supposed provide a tarball of the git archive, so the tarball and running git manually should both get the same content as far as I know. Perhaps I am wrong.

    According to the note, it gets the bukkit repositories automatically, is it a possibility that some changes have been made since yesterday causing your dependencies to on bukkit to produce the failure?

    Looking at https://github.com/Bukkit/CraftBukkit/commits/master I see that one of the compilation errors may be liked to changes made yesterday. For instance, the ...

    Code:
    [ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java:[43,7] error: CraftPlayer is not abstract and does not override abstract method setBedSpawnLocation(Location) in Player


    may be due to this change...

    https://github.com/Bukkit/CraftBukkit/commit/188f64d59a2823fe439d32b7099a4401b399df7f

    and this error..

    Code:
    [ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/CraftWorld.java:[46,7] error: CraftWorld is not abstract and does not override abstract method <T>getEntitiesByClass(Class<T>...) in World
    may be due to this change...

    https://github.com/Bukkit/CraftBukkit/commit/d7c5dfa19cac89b8591d63528abdcdc9d6b6ef7f

    and this error...

    PHP:
    [ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-f7b9024/src/main/java/org/bukkit/craftbukkit/entity/CraftMushroomCow.java:[7,7errorCraftMushroomCow is not abstract and does not override abstract method setBreed(boolean) in Animals
    may be due to this change...

    https://github.com/Bukkit/CraftBukkit/commit/28a88ec1047f5c7dcc5d9325399ad236c469ff9f

    Can you make updates, or is there a way around this?

    I just saw you made some updates, I tried out the latest code, and I am getting a different error now, but I am hoping that's because your still making changes...

    Code:
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project craftbukkit: Compilation failure: Compilation failure:
    [ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-1c7665c/src/main/java/org/bukkit/craftbukkit/entity/CraftAnimals.java:[27,19] error: cannot find symbol
    [ERROR]
    [ERROR] could not parse error message:  symbol:  variable ageLocked
    [ERROR] location: class EntityAnimal
    [ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-1c7665c/src/main/java/org/bukkit/craftbukkit/entity/CraftAnimals.java:31: error: cannot find symbol
    [ERROR] return getHandle().ageLocked;
    [ERROR] ^
    [ERROR]
    [ERROR] could not parse error message:  symbol:  variable ageLocked
    [ERROR] location: class EntityAnimal
    [ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-1c7665c/src/main/java/org/bukkit/craftbukkit/block/CraftBlock.java:238: error: cannot find symbol
    [ERROR] return new CraftBrewingStand(this);
    [ERROR] ^
    [ERROR]
    [ERROR] could not parse error message:  symbol:  class CraftBrewingStand
    [ERROR] location: class CraftBlock
    [ERROR] /home/mcsmp/tmp/lama-kun-CraftBukkit-1c7665c/src/main/java/net/minecraft/server/EntityPotion.java:69: error: no suitable method found for a(EntityLiving,EntityLiving,int,double,EntityPotion)
    [ERROR] MobEffectList.byId[i].a(this.shooter, (EntityLiving) entity, mobeffect.getAmplifier(), d1, this); // CraftBukkit - added 'this'
    [ERROR] ^
    [ERROR] -> [Help 1]
    [ERROR]
    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 21, 2016
  16. Offline

    Hazilo

  17. Offline

    Nam

    As mentioned in my post above, I tried the latest code, and I am getting a different compilation error now.

    Thanks for the quick updates, I'm soooo looking forward to being able to play 256 tall worlds with bukkit. So are the players on my server.

    I just deleted ~/.m2 and tried "mvn clean package" again, this time it worked :) YAY... Time to test it.

    My mistake, that was the compilation of your Bukkit release, not your CraftBukkit release.

    Based on the errors and the commits, I think it may be this commit causing the problem...

    https://github.com/Bukkit/Bukkit/commit/992fa6d0398e9bf8838fecd2f0b6717672b6984a

    I wish I knew Java so I could provide a patch, unfortunately I program PHP, not Java.

    I copied some missing files that your code was referencing, and was able to compile it. I am now able to play 256 tall worlds on bukkit.... YOU ROCK!!!!

    The spout plugin though has an error when I do a "stop" on the server...

    Code:
    20:41:58 [INFO] [Spout] Unloading Spout vUnknown.
    20:41:58 [SEVERE] Error occurred while disabling Spout vUnknown (Is it up to date?): tried to access method gnu.trove.map.hash.TLongObjectHashMap$ValueView.<init>(Lgnu/trove/map/hash/TLongObjectHashMap;)V from class gnu.trove.map.hash.TLongObjectHashMap
    java.lang.IllegalAccessError: tried to access method gnu.trove.map.hash.TLongObjectHashMap$ValueView.<init>(Lgnu/trove/map/hash/TLongObjectHashMap;)V from class gnu.trove.map.hash.TLongObjectHashMap
            at gnu.trove.map.hash.TLongObjectHashMap.valueCollection(TLongObjectHashMap.java:345)
            at org.getspout.spoutapi.chunkstore.SimpleChunkDataManager.saveWorldChunks(SimpleChunkDataManager.java:119)
            at org.getspout.spoutapi.chunkstore.SimpleChunkDataManager.unloadWorldChunks(SimpleChunkDataManager.java:103)
            at org.getspout.spoutapi.chunkstore.SimpleChunkDataManager.unloadAllChunks(SimpleChunkDataManager.java:136)
            at org.getspout.spout.Spout.onDisable(Spout.java:147)
            at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:234)
            at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:1060)
            at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:270)
            at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:263)
            at org.bukkit.craftbukkit.CraftServer.disablePlugins(CraftServer.java:185)
            at net.minecraft.server.MinecraftServer.stop(MinecraftServer.java:384)
            at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:464)
            at net.minecraft.server.ThreadServerApplication.run(SourceFile:465)
    Hmm... It seems that your fork ONLY supports 256 tall worlds. I would ideally like to be able to have people first joining the server go to a 128 tall world (for compatibility reasons) then go through to the 256 tall world via a portal. Any chance you could update the code to do this?

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 21, 2016
  18. Offline

    Hazilo

    Well, that is the problem with hard-coded values, one height for all...
    I'll watch if it is possible to turn it into a plugin a bit later, but, just like you, Java is not my language, C is ;)
     
  19. Offline

    Nam

    I had actually been waiting for a developer by the name of fishtaco to make it as a plugin. He said he went to do it, but then bukkit was missing a hook that was involved in the world generation code or something like that. Perhaps his work could help you come up with a plugin. He has been very slow to respond, and has been primarily focusing on single player mods, or vanilla mods. I would prefer to be able to use bukkit. Here is the thread for fishtacos height mod...
    http://www.minecraftforum.net/topic/544429-110100fishtacos-mods-better-caves-fps-height-mod/
    From what I understand, spout supports world heights based upon a network bit that is transmitted (read that in forum posts somewhere). I am not sure at what point it gets that network bit, but if it occurs when transportation or something is done, then the client side supports it already, but it's the server side.
    Perhaps it would require a modification to both the CraftBukkit code, Spout, and the creation of a world generator plugin that gets spout to send the correct network bit when that world generator is used.
    I hope this sparks some ideas... in the mean time, I am loving having access to 256 height bukkit worlds. Thank you very much for what you have accomplished so far, and I hope to see even more good stuff in the future.
     
  20. Offline

    Erik Vikersveen

    ohh the amount of jealousy I feel! Twice the height meens 8 times the need for bukkit!
    We (our server) have been waiting for FishTaco to make 256 worlds bukkit friendly for so long. The patching/compiling thing is just a bit to complicated for me. My programming skills ends at bat files.

    Anyway, congratulations on making bukkit work with heigher worlds!
     
  21. Offline

    Nam

    Yea, I've been waiting for a long time as well for FishTaco to finish his mod. Unfortunately he hasn't been around much lately.

    But Hazilo has done some awesome work here, and I give him Kodos for that.

    The only problem I have right now with the build is that the mod SpoutMaterials has two issues. First of all it cannot smelt added ores because currently the Spout Plugin doesn't support that according to the developer (because furnace doesn't smelt items with data codes over 16), and the textures no longer display when the blocks are placed in the world. I know the first issue has been going on since the stable release, but the second issue may be because of code changes made by Hazilo. I hope these two things get fixes soon, because then things will become majorly epic!!.
     
    Erik Vikersveen likes this.
  22. Offline

    Kanilox

  23. Offline

    ledhead900

    What is the resource use at now with this, I know that resources skyrocket using SP versions of such a change.
     
  24. Offline

    croxis

    Doubling the ram use is a rough estimate.
     
  25. Offline

    Lying_Cake

    This should be #1 priority. This is the biggest problem with minecraft...
     
  26. Offline

    Erik Vikersveen

    New RB of CraftBukkit is out... 1.1
     
  27. [​IMG]
     
    hammale likes this.
  28. Offline

    Nam

    I saw that Hazilo updated his CraftBukkit and SpoutPlugin git archives. The CraftBukkit code compiles, but the SpoutPlugin code gives an error when compiling...

    Code:
    [INFO] -------------------------------------------------------------
    [ERROR] COMPILATION ERROR :
    [INFO] -------------------------------------------------------------
    [ERROR] /home/mcsmp/tmp/lama-kun-SpoutPlugin-715d1ba/src/org/getspout/spout/SpoutNetServerHandler.java:[102,44] error: cannot find symbol
    [ERROR]  package org.getspout.spoutapi.event.inventory
    /home/mcsmp/tmp/lama-kun-SpoutPlugin-715d1ba/src/org/getspout/spout/SpoutNetServerHandler.java:[342,5] error: cannot find symbol
    [ERROR]  class SpoutNetServerHandler
    /home/mcsmp/tmp/lama-kun-SpoutPlugin-715d1ba/src/org/getspout/spout/SpoutNetServerHandler.java:[342,39] error: cannot find symbol
    [INFO] 3 errors
    [INFO] -------------------------------------------------------------
     
  29. Offline

    lezyamin

    Is there a way to download this, as a pre-compiled plugin?
     
  30. Offline

    Hazilo

    No, no pre-compiled release nor plugin and I lack time to make one...

    Yeah, spout repo have been modified a lot, still have some work to do...
     
Thread Status:
Not open for further replies.

Share This Page