[INACTIVE][EDIT] PaintingSwitch v0.1 - Choose paintings with ease [672]

lol... "Could it be any more simple..." ITT: your next challenge is to make it change just by thinking of the picture... good luck... jkes its good as ty GREAT WORK + 1 Internets

 

Just thought I'd let you know I've tested this on 617 and it's working.

 

Thanks!

 

@Edward Hand
Hey, I know I said this was working, and it does appear to be, but I've just noticed a small bug, if someone is holding something and they try to change the picture, this pops up in the server log. Still works, but not sure what the log entry is about.

Code:

[SEVERE] Could not pass event PLAYER_ITEM_HELD to PaintingSwitch
java.lang.IllegalStateException: Start block missed in BlockIterator
	at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:169)
	at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:243)
	at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:278)
	at org.bukkit.craftbukkit.entity.CraftLivingEntity.getLineOfSight(CraftLivingEntity.java:86)
	at org.bukkit.craftbukkit.entity.CraftLivingEntity.getTargetBlock(CraftLivingEntity.java:112)
	at com.edwardhand.paintingswitch.PaintingListener.onItemHeldChange(PaintingListener.java:33)
	at org.bukkit.plugin.java.JavaPluginLoader$14.execute(JavaPluginLoader.java:247)
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:59)
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:255)
	at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:529)
	at net.minecraft.server.Packet16BlockItemSwitch.a(SourceFile:24)
	at net.minecraft.server.NetworkManager.a(NetworkManager.java:198)
	at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:72)
	at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
	at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:368)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:283)
	at net.minecraft.server.ThreadServerApplication.run(SourceFile:375)

 

I would like an option so that you have to hold shift while scrolling.

 

Great plugin, this has probably saved me hours.

I agree with the other posters who suggested a time or action based lock on switching.

 

I'd like at least a fallback on ops.txt or something, because then anybody can edit anybody's paintings. Or maybe a command. Something like that.

 

Amazing work, thank you very much.

 

SWEET !

 

Tried and tested on 670, seems to be working.

 

I agree with Cnuut, that would be convenient. I like this plugin but it's sometimes displeasing to change paintings unintentionally.​

 

I just want to add a "me too" to the sneaking/"holding shift" bit.
Should be a simple change to check the boolean org.bukkit.entity.Player.isSneaking()
I've only recently started hosting and writing plugins, with exactly zero releases myself. If it's more involved than that, feel free to ignore me.

Either way you slice it, this is one very nice plugin. My wife is always complaining about placing pictures 384 times to get the right one, and now she finally doesn't have to.

Thank you!

 

2011-04-14 23:10:24 [SEVERE] Could not pass event PLAYER_ITEM_HELD to PaintingSwitch
java.lang.IllegalStateException: Start block missed in BlockIterator
at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:169)
at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:243)
at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:278)
at org.bukkit.craftbukkit.entity.CraftLivingEntity.getLineOfSight(CraftLivingEntity.java:86)
at org.bukkit.craftbukkit.entity.CraftLivingEntity.getTargetBlock(CraftLivingEntity.java:112)
at com.edwardhand.paintingswitch.PaintingListener.onItemHeldChange(PaintingListener.java:33)
at org.bukkit.plugin.java.JavaPluginLoader$14.execute(JavaPluginLoader.java:282)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:59)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:255)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:561)
at net.minecraft.server.Packet16BlockItemSwitch.a(SourceFile:24)
at net.minecraft.server.NetworkManager.a(NetworkManager.java:198)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:72)
at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:368)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:283)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:375)
2011-04-14 23:10:25 [INFO] Stopping server

 

nice love it , tobad everyone can change your paintings, need i protection system, like the one used on signs

 

That's no different to how things are without the plugin installed.
I know of no plugin that protects against painting destruction.

 

i cant say i seen one yet so that something we need , a paiting protect system , lets hope thay make one soon . even antibuild dosent stop grifers from grifing paintings

 

Great mod! Works just fine with #670. Keep up the good work!

 

Any chance to have the holding shift option added to this plugin ? I'm not the only one who want it, so if you don't want to add it please tell us. Thanks.

 

thx great plugin continue your great work dude

 

Fail.. it starts without errors, but it crashes the server while running.

 

I'm running #670 and I haven't had a single problem with it. It works just fine. May be there is a conflict with another mod you are using.

 

Thank you works Brilliantly, Simple and elegant.

 

+1

 

@Edward Hand Got this running on RB 684 without any problems.

 

Waiting for 695 support.

 

@Edward Hand: Could you please fix this for Craftbukkit 714?

 

Update it please!

 

Is it eating your paintings too?

 

Yes.

 

can u plz update this plugin CB 714 ??

Code:

2011-04-14 23:10:24 [SEVERE] Could not pass event PLAYER_ITEM_HELD to PaintingSwitch
java.lang.IllegalStateException: Start block missed in BlockIterator
at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:169)
at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:243)
at org.bukkit.util.BlockIterator.<init>(BlockIterator.java:278)
at org.bukkit.craftbukkit.entity.CraftLivingEntity.getLineOfSight(CraftLivingEntity.java:86)
at org.bukkit.craftbukkit.entity.CraftLivingEntity.getTargetBlock(CraftLivingEntity.java:112)
at com.edwardhand.paintingswitch.PaintingListener.onItemHeldChange(PaintingListener.java:33)
at org.bukkit.plugin.java.JavaPluginLoader$14.execute(JavaPluginLoader.java:282)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:59)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:255)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:561)
at net.minecraft.server.Packet16BlockItemSwitch.a(SourceFile:24)
at net.minecraft.server.NetworkManager.a(NetworkManager.java:198)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:72)
at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:368)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:283)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:375)