[INACTIVE][ECON] SignShop v1.1 - Commandless Multi-World Player Owned Shops [860] iConomy

Discussion in 'Inactive/Unsupported Plugins' started by Ne0nx3r0, May 3, 2011.

  1. Offline


    Development on this plugin has stopped.
    Commandless Player Owned Shops
    Current Version:​
    v1.1 [860] June 19th, 2011

    *Requires iConomy (v5.0)​

    Some notes about upgrading from < 1.0:
    1. config.yml is the new messages.yml, you can delete messages.yml
    2. BACK UP YOUR sellers.yml BEFORE MAKING ANY CHANGES OR UPDATING (sorry, wanted to make that clear.)
    Create signs to sell goods from a chest you specify; allow your players to setup and run their own shops!

    Supported Signs:
    Supported Signs (open)

    [Buy] - Buys an item fro the shop chest for the price specified on the 4th line
    [Sell] - Sells an item to the shop chest for the price specified on the 4th line
    [Donate] - Gives an item to the shop chest
    [Slot] - Gives a random item from the selected chest items (not the entire inventory) to the player
    [DeviceOn] - Turns a lever on
    [DeviceOff] - Turns a lever off
    [DeviceToggle] - Toggles a lever
    [Device] - Temporarily turns on a lever
    *[gBuy] - Buys an item from the shop, but the owner receives no money
    *[gSell] - Sells an item to the shop, and the player receives money, but not from the owner.
    *[iBuy] - Buy an item from the "shop", but really the item is created from scratch whether the shop has it in stock or not.
    *[iSell] - Sells an item to the "shop", but really the item just disappears.
    *[Day] - Turns the time to day
    *[Night] - Turns the time to night
    *[Rain] - Turns on rain + thunder
    *[ClearSkies] - Turns off rain + thunder
    *[Repair] - Repairs the current item
    *[Heal] - Fully heals the player

    *Must be OP/SignShop.Admin to create

    Usage (open)

    1. Create a sign. Line 1 needs to be [Buy] (or whatever type of sign). Line 4 needs to be the price (aka 50, 50.25) of your item(s). lines 2&3 can describe your item(s), or be blank.
    2. While holding redstone, click on the sign. (you should get a message)
    3. Find a chest you want to use as your storage, put ONLY the items you want the sign to sell in it. For example, if you have a stack of 64 Cobblestone and want to sell two at a time, put only two in the chest.
    4. Click on the chest with redstone. (you should get a message)
    5. Put all of your cobblestone in the chest
    6. Now players can click on your sign (no redstone needed), purchase the cobbletone two at a time! (right click to buy without confirmation dialog)
    Note - One chest can maintain multiple signs, just take everything out and set the new sign up, then put all the items for both signs in so the shop has something to sell.

    Permissions Nodes:
    Permissions Nodes (open)

    • SignShop.Signs.*
    • SignShop.Admin.*

    Version 1.1
    • Bug fix - creates the plugin directory if needed.
    Changelog (open)
    Version 1.1
    • Bug fix - creates the plugin directory if needed.
    Version 1.0
    • Added localization, scheduled saving, custom signs, better localized logging, backing up of sellers.yml, proof of god, etc.
    Version 0.7.2
    • Lost to the world
    Version 0.7.1
    • Bug fix for iSell/iBuy signs
    Version 0.7
    • Added a small gaggle of new sign operations, small bug fixes. updated messages.yml
    Version 0.6.1
    • Moved gBuy/gSell to OP/Admin operations, as gBuy is exploitable.
    Version 0.6
    • Added gBuy/gSell signs, renamed config.yml to messages.yml
    Version 0.5.4
    • Bug fix for slot shops
    Version 0.5.3
    • Bug fix, added check/msg for missing chests
    Version 0.5.2
    • Bug/exploit fix - cancels event if the user does't have enough items
    Version 0.5.1
    • Bug fix for signs clicked with less than 3 characters
    Version 0.5
    • Added Permissions support, added configurable messages, added [Redstone] sign. Set plugin to respect events being cancelled. Various bug fixes and code maintenance.
    Version 0.4.2
    • Bug fix with confirmation messages showing the owners name instead of the players name
    Version 0.4.1
    • Bug fix with [Sell] signs paying shop owners
    Version 0.4
    • iConomy 5.0 support, also added Sell, Donate, Slot, iBuy, iSell signs
    Version 0.3.1
    • Bug fix
    Version 0.3
    • iConomy 5.0 compatibility, also signs now need [Buy] to be the first line. (Making room for [Sell], [Donate] signs)
    Version 0.2
    • Added yml persistence
    Version 0.1
    • Initial release

    Known Issues:
    • Conflicts with Essentials; disable signs in the essentials config before adding this plugin.
    Coming soon:
    • Extra storage (still working on it... infinite storage would be better, and might be possible ;))
    • I develop this plugin because I enjoy it and want to give back to this community; however if you are interested in supporting it's future I gladly accept donations via PayPal, and BitCoin.
    Do you like this plugin? Click like so I know! ; )
  2. Offline


    Hi, found kinda a bug, if you place an iBuy shop use it, then delete the chest and then use the sign, you'll get this error message in the logs :
    2011-05-11 23:56:15 [SEVERE] Could not pass event PLAYER_INTERACT to SignShop
    java.lang.ClassCastException: org.bukkit.craftbukkit.block.CraftBlockState cannot be cast to org.bukkit.block.Chest
        at Ne0nx3r0.SignShop.SignShopPlayerListener.onPlayerInteract(SignShopPlayerListener.java:321)
        at org.bukkit.plugin.java.JavaPluginLoader$9.execute(JavaPluginLoader.java:280)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:59)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:289)
        at org.bukkit.craftbukkit.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:162)
        at net.minecraft.server.ItemInWorldManager.interact(ItemInWorldManager.java:207)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:526)
        at net.minecraft.server.Packet15Place.a(SourceFile:57)
        at net.minecraft.server.NetworkManager.a(NetworkManager.java:196)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:75)
        at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
        at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:372)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:287)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:394)
    I think this should be handled be the plugin and give for exemple an error message and destroy the sign without a valid chest or something like that ;)
  3. Offline


    Yeah, I'm an op. I suspect there's a conflict with Essentials. I tried making [Buy] and [Sell] signs, and it all defaulted to EssentialsEco signs.

    I like yours better. :/
  4. Offline


    I confirm that you have to disable all signs in essentials config files before using this plugin or you'll have a conflict and this plugin will not work at all ;)
  5. Offline


    Hrm... Not sure how to mitigate that, I suppose I'll add it as a known issue for now
  6. Offline


    ive got an issue with item names, anything that is used as a dye ingredient comes up as inksack IE. bonemeal, lapis ore, cocoa etc. same with charcoal and coal, both labeled coal. I am sure there are others, just the once ive noticed. Great plugin otherwise

    and it keeps removing my links, you need to fix this. its pretty game breaking

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
    Last edited by a moderator: May 14, 2016
  7. Offline


    Anyone else having this issue? Perhaps someone who understands which details are needed to troubleshoot? ; )
  8. Offline


    please add permissions support, i just only want that users can buy/sell ;/
  9. Offline


    Is there a way, that nobody gets the money earned by the shops made with [iBuy] and [iSell]?
  10. Offline


    Can you add a [trade] sign similar to the one in essentials?
    Useful if people want to trade without money. :)
  11. Offline


    I have Essentials installed next to SignShops... But everytime I create a sign with [buy] the way it stands on this site, it says "wrong item-ID". It shows me the standard configuration for Essentials. So is there any way to deactivate EssentialsEco?
  12. Offline


    Thanks for this plug-in! LOL Permissions would be nice but its still a great plug-in. keep up the good work :)
  13. Offline


    basically you cannot buy redstone from the players, am I right?
  14. Offline


    You've gotta get this compatible with permissions mod asap :p I'd love to be using this..
  15. Offline


    Everything seems to be working, but im not getting paid when people buy from my signs. Any idea what might be causing that?
  16. Offline



    Not sure, you can check your log for errors, might also be a plugin conflict

    I'll take a look at this

    I dunno about this, but it's something to consider.

    The only thing users can do besides buy and sell even without permissions is slot and donate, and donate is basically sell with a price of 0. Only OPs can use the iSell/iBuy signs, but I'll see what I can do once I finish up some other things this week.

    I'm working on it, though honestly there's not much you would need to enable/disable, unless for some reason you wanted to have buy and not sell, etc.
  17. Offline


    oh it's okay, silly me, I had redstone in my hands when trying to sell it. :)
  18. Offline


  19. Offline


    Looks fine; you might take a look in SignShops and see if the yml file was created okay and it has entries. Also you should try setting up a new sign+chest and see if it shows up in the yml.

    I believe this is the issue mentioned in known issues, read the initial post (and possibly through the thread a bit).

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
    Last edited by a moderator: May 14, 2016
  20. Offline


    Why Ops Only? :( And To Setup A Shop Its Different From What You Said
  21. Offline


    iSell and iBuy generate and destroy items; to prevent cheating these are reserved for ops that want to setup, for example a place where players can sell all the dirt they want.

    *edit* just checked, and the usage listed in the initial post looks good to me. Let me know if it isn't correct.
  22. Offline


    Hi, i hope you respond
    i love this plugin :), amazing. I saw in the changelog that you were going to add permissions. i was wondering if this is something that will be out soon. I made a bunch of signs (over like 25) only to realize i missed the OP ONLY :( and i want players to be able to use it but not give them OP

    thanks again, great plugin!
  23. Offline


    They can use signs, just not iSell and iBuy
  24. Offline


    ne0nx3ro said:

    Wakko said:
    Can you add a [trade] sign similar to the one in essentials?​
    Useful if people want to trade without money. :)

    I dunno about this, but it's something to consider.​

    Yah, it would be nice to have [Trade] or [iTrade] since there's [buy] and [sell] signs.
    Can you make the signs easier to use though?
    For example:
    Line #1: [buy] (or sell)
    Line #2: # of items selling
    Line #3: item id
    Line #4: price
    (Yes, I know it's like Essentials, but it's much easier)

    Also, how do I disable the EssentialsEco signs?
    I can't find it in the config.
    Do I just remove its .jar?
  25. Offline


    If I give my players op they will be able to use all commands and I don't want that. Permissions soon??
  26. Offline


    You know I've never used essentials, so I honestly don't know, heh.

    If you read closely, players only need to be OPs to create iSell and iBuy, all signs can be used by all players, and the rest of the signs can be created by all players.

    For the record I am working on permissions support; but I'm also adding configurable messages (it just sort of works out well to do both at the same time), so it'll be another day or two.
    nbirk94 likes this.
  27. Offline


    I am trying to write a review of the different shop choices for the people on our server. I envision one stop shopping with a large mall broken down into types of items rather than individual player shops. For example all the players selling wool would place their signs together in one section.

    I like that you have 2 lines to write a description of what you are selling, not an item id number, but could this be a potential problem?

    What if you saw:


    But when you clicked it, they were really just selling you a dirt block?

    Does the sign creator's name automatically get put on the sign? If it doesn't, combined with the ability to make misleading descriptions, it would be serious problem on a large server.
    I hope I am wrong about these points, because this looks like a really good choice otherwise.
  28. Offline


    If you left click it tells you what you are buying and the price, then you click again to confirm. Right click buys it instantly.
  29. Offline


    I seems that CraftBukkitUpToDate keeps on downloading a bad SignShops.jar file. Could you please make sure the author of CraftBukkitUpToDate has the right source? Thanks.
  30. Offline


    I think this issue was already resolved:

    However you will need to troubleshoot with him, as I don't know a thing about how that plugin works.

    Update on the progress for permissions/etc; the coding is done, just needs some more testing/debugging before it's released. It all seems to work fine, I just want to verify it once I'm rested.

    - iSell/iBuy will no longer give/take money from the creator
    - config.yml contains configurable messages
    - permissions support (Regular users should get SignShop.Signs.*, for iSell/iBuy is SignShop.Admin.*), including individual signs (SignShop.Signs.Buy, SignShop.Admin.iBuy, etc)

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
    Last edited by a moderator: May 14, 2016
  31. Offline


    My server is right now facing the problem, that the signshop is used to steel stuff from locked chests.
    People make signs with a price of 0.01 or so and link them to chests, that aren't their own. Is there anyway to prohibit this?

Share This Page