[INACTIVE][ECON] BetterShop 1.6.5- iConomy Global Command-based Shop [602 & 677]

Discussion in 'Inactive/Unsupported Plugins' started by jjfs85, Feb 4, 2011.

  1. Offline

    jjfs85

    BetterShop - The "better" global command-based shop that ties into iConomy:
    Version: v1.6.5 (1.6.5.3)
    Download: (static jar) BetterShop.jar
    (older, 602 compatible) BetterShop_1.6.2.8.jar
    (older, 556 compatible) BetterShop_1.6.2.5.jar
    (older versions are not supported, sorry)
    Authors: jascotty2, and jjfs85, with a little help from lologarithm.

    Webpage coming soon.

    Want the most up-to-date info on usage, features, the changelog, and more?
    Read the README!

    Plugin Information (as of v1.6.5.3 - 4/11/11)

    Commands (open)

    • /shop
      • for those used to a plugin having one command, this is another way to get to the following commands
    • /shophelp (shelp) [command]
      • shows you all the commands you can use
      • can show specific help for a command
    • /shoplist (sl,slist) [pagenum]
      • shows a listing of items for sale
      • (if -1, all, or full given, will show full list. (mainly for console use))
    • /shopitems (sitems)
      • show full listing of items in shop, without prices
    • /shopcheck (sc,scheck) <item>
      • lookup a specific item so you don't have to read through pages of prices
    • /shopbuy (buy,sbuy) <item> [amount]
      • buy an item for the price in the shopshop ("all" is accepted as an amount)
    • /shopbuyall (buyall,sbuyall) <item>
      • buy all of an item that you can hold
    • /shopsell (sell,ssell) <item> [amount]
      • sell an item for the price in the shop
    • /shopadd (sadd): <item> <buy> [sell]
      • add an item to or update an item in the price list
    • /shopremove (sremove): <item>
      • remove an item from the price list
    • /shopload (sload):
      • reload prices from pricelist database
    • /shopsellall (sellall): [inv] [item [...]]
      • Sell all of item from your inventory (alias to command /shop sell all)
      • (inv will not search lower 9 slots)
    • /shopbuystack (buystack): <item> [item | amount]
      • buy a stack of an item (usually 64)
    • /shopsellstack (sellstack) <item> [amount]
      • sell a stack of an item (usually 64)
    • /shopbuyagain (buyagain,sba):
      • repeat last buy action
    • /shopsellagain (sellagain,ssa):
      • repeat last sell action
    • /shopkits (skits):
      • show a listing of avalliable kits (will be elaborated later)


    Dependencies (open)

    BetterShop's dependencies:

    Economy plugins supported:


    iConomy
    - or
    BOSeconomy

    Supported Plugins:

    • Permissions v2.5.0+ by people - permissions and groups plugin
    or​
    • GroupManager by not Zenexer after all- a replacement for Permissions that is fully compatible with plugins that require it (using FakePermissions)
    • Help 0.2+
    • MinecraftIM


    Features (open)

    Features:
    configurable
    • Fully configurable colors and message text in config.yml file
    • shoplist can have text alignment (read config for more info): <item> <l(eft-aligned)> <buy and sell info>
      • - uses minecraft font character spacing, so is very close to perfectly aligned in chat
    • shoplist can optionally not show listing tail (or head, but recommended to leave <page> of <pages>)
    • Items can be colored in the new itemsdb.yml file
    • also in itemsdb.yml: kits!
      • - define your own kits that the shop can sell
      • - three examples provided, edit and add to your liking
    • Configurable Options:
      • -max pagesize when printing shoplist
      • -whether to broadcast all transactions publicly
      • -name of the pricelist file/table
      • -customsort: a custom sorting order, so you can have items at the top of the shop list
      • -allowbuyillegal: if someone without BetterShop.admin.illegal can buy illegal items
      • -whether maxstack should be honored
      • -if used tools can be bought back
      • -default color for items
    shop flexibility
    • shopcheck will run a name comparison check, and return all matching items
    • Item sub-type support for dye colors, cloth colors, etc: magentacloth = 35:2 = cloth:magenta
    • "all" is a valid amount when buying or selling: "/sell cobblestone all" or "/sell all cobblestone"
    • damaged tools can be resold for an adjusted value of sellprice*(1-(damage/maxdamage))
    • buystack can be given multiple items, or number of stacks: "/buystack wool 5" or "/buystack wool blackdye reddye"
    • shopsellall can be given multiple items (/sell all cobble gravel flint dirt)
    • plural-insensitive items: if not found, will check if plural & remove "s"
    • not just items can be bought anymore: can now buy LivingEntities, like dogs (wolf)
    • signs can be used for buying & selling
      • Code:
         [*][BetterShop]
         [*]buy [amt], buyall, buystack, sell [amt], sellall, sellstack
         [*]item name (recommended) or id:data, or for sellall: onhand, inv
         [*](unused line)
         [*]
      • to activate, someone with BetterShop.admin.makesign must left-click the sign.. the first line will change color when active
      • left-click for price check (or activate), right-click to buy/sell
      • if a unauthorized player destroys a block a sign is on, is canceled
      • can scan for uxexpected sign destruction (tnt) & replace it
    administration
    • Every item and subtype can be priced differently
    • Disable buying or selling of an item by giving it a price of -1 (0 makes it free)
    • command aliases to stop carpal tunnel
    • many commands have sub-aliases.. eg. shoplist kits will run shoplistkits
    • MySQL pricelist support
    • MySQL pricelist can be cached for a given timespan (decreases table selects)
      • (flatfile is cached until manually updated)
    • Transaction records (MySQL or flatfile as .csv)
    • Downloads mysql-bin.jar dependency automatically
    • buy/sell cap in program set to 999,999,999 (not that you'd be using that much, but the cap is to prevent other errors)
    • if encounters errors while editing a player's account, will attempt to reload iConomy (i've had issuses with it before)
    • can backup the current pricelist: /shop backup
    • on start, can check the download page to see if there is an update available
    • /shop ver[sion] shows version # and if is up-to-date
    • shop can be given a finite stock from which to buy & sell
    • /shop ver[sion] to check the current version & see if there's an update
    • MinecraftIM support: forward errors or all messages
    • checks for missing & unused configuration nodes
    • strings have default values if missing
    • auto error reporting added (can be disabled)
    • help main page integration can be disabled
    • global shop can be disabled & only allow signs to be used


    Installing (open)

    Installation instructions:

    New Installation?
    Upgrading?

    • lots more added to config.yml all the time..
    • to 1.6.3+ ? Itemsdb.yml has been expanded to include entities
    • from before v1.6.1.3 ? Itemsdb.yml has been expanded:
      • not required to update, but recommended
      • if you've already edited yours, you can look here and see what i've added
        • mainly: leaves, charcoal, tools & armor damage, some more aliases
    • from version 1.5.9b - 1.6.1.0 and use MySQL transaction logging?
      • ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);
      • ALTER TABLE BetterShopMarketActivity CHANGE COLUMN SOLD SOLD TINYINT;
        • optional, but useful for php
    • from version between 1.5.5 - 1.5.9 and use MySQL pricelist?
      • ALTER TABLE minecraft.BetterShop CHANGE COLUMN BUY BUY DECIMAL(11,2);
      • ALTER TABLE minecraft.BetterShop CHANGE COLUMN SELL SELL DECIMAL(11,2);
    • from an earlier version?
      • Will import your old pricelist.yml into the db you have setup in the config :)
      • Items.db is no longer used - delete it :)
    Permissions:

    Just add the following nodes to Permissions' world.yml file (or data.yml file for GroupManager):


    - 'BetterShop.user.*'
    ^ Allows the user to use the list, sell, buy, and help commands
    - 'BetterShop.admin.*'
    ^ Allows the user to use the add, remove, and load commands

    Alright, so you have the plugins in place and set up, and permissions nodes added to the Permissions' config.yml. Now just place the BetterShop.jar file in the server's plugins directory. Then just start the server and add things to the shop. That's all!

    Adding Items:
    There are two ways to add things to the shop:
    1. Recommended, but slow: use /shopadd [item] [buy-price] [sell-price]
    2. Faster: use a text editor or spreadsheet program to edit the pricelist.csv


    TODO (open)

    features listed here may already be in the works, or may be on the back burner
    if you want a new feature, or want something sooner, ask :)

    • calculated/derived item prices
    • /shopvalue item[@amount] item to show the current trade value for two items
    • discount system: users or groups can be charged less/more for an item or all items (sell prices also affected)
    • dynamic market pricing, based off of logged market activity
    • region shops (items added while in a region defined as a shop are only added to that shop)
    • add option for amount in stock for surplus decreases how much item is worth to the shop
    • /shop alias <item> - show the itemname, with a list of aliases
    • add pages for /shopitems
    • more descriptive kit listing, similar to shoplist:
      • - pages
      • - show what makes up a kit
      • - enable admin.add to see avaliable kits
    • SQLite support?
    • tie item prices to stock quotes?
    • craftables' stock is tied to source material stock (if using sell craftables)
    • make LivingEntities follow the owner around?
    • change buystock if itemStock is enabled so that if trying to buy multiple stacks (buystack item 20) and stock runs out to stop buying (stop showing "out of stock")
    • individually-customizable restock stock values per-item
    • chest shop interface ?
    • automatically add missing config nodes (preserving comments)
    • add a simple builtin economy system, if none found?
    • add categories to items
      • - can search, buy, & sell with category
    • user-owned shops (signs, linked to chests)
    • 4th line for configurable prices or shop profit owner


    Changelog (open)

    Changelog:
    (the (?) means plugin didn't report that as the version.. sorry :))

    Version 1.6.5.3 - 4/11/11 - jascotty2
    • added option to disable sign protection
    • added sign action wait, to prevent sign click spamming
    • fixed a nullpointer error when selling
    Version 1.6.5.2 - 4/11/11 - jascotty2
    • removed spawnwolf debugging line
    • wolves bought have correct health
    Version 1.6.5.1 - 4/10/11 - jascotty2
    • removed a debugging line
    • wolfs bought have their owner already set (need to increase health)
    Version 1.6.5.0 - 4/10/11 - jascotty2
    • corrected new settings (missed some previously)
    • fixed default sign pricecheck showing wrong one
    • fixed messenger formatting error
    • misc. null fixes
    • BOSEconomy support added
    • changed block protection from scan to save (should improve performance)
    • added tnt protection, in the form of a scanner that routinely checks that all shop signs & their anchors still exist
    • added syntax check for /buy & /sell # [item] (like the sign syntax)
    • allowbuyillegal now defaults to true
    • fixed color set (hidden logic error)
    • signs can have the item name colored according to the defined item color
    Version 1.6.4.2 - 4/9/11 - jascotty2
    • fixed sign destroy permission check to only check bettershop signs
    Version 1.6.4.1 - 4/8/11 - jascotty2
    • "inhand" and "inv" added as valid sellall/buyall items (signs only)
      • - "in hand" buys/sells all of the type of item in the player's hand
    • sign destroy protection algorithm improved (still can't check for explosions :( )
    Version 1.6.4.0 (?) - 4/8/11 - jascotty2
    • stock message error fixed when selling too much
    • fixed <curr> causing a server freeze
    • added amount to pricecheck, so can check the result buy/sell price
    • fixed a buying error when already has some of the item
    • added a sign interface
      • - first line: [BetterShop] (not case-sensitive)
      • - second line: action: buy [amt], buyall, buystack, sell [amt], sellall, sellstack
      • - third line: item (name, id, etc)
      • - fourth line: unused (was going to make price, but decided on pricecheck instead)
      • - to activate, someone with BetterShop.admin.makesign must left-click the sign.. the first line will change color when active
      • - left-click to pricecheck
      • - right-click to run action
    • if a unauthorized player destroys a block a sign is on, is canceled
    • fixed column check for table updating
    • updated for 670
    • configuration nodes are moved to more organised parent nodes (easier to edit if using an intelligent text editor)
      • - older nodes are still supported (for now)
    Version 1.6.3.6 - 4/6/11 - jascotty2
    • again, previously forgot to update the date in last version
    • - added additional checks to prevent future false-positives
    • -- (also checks if comment on download matches plugin, not if plugin >= comment version)
    • figured out the integrity check errors :)
    • now runs checks on changed tables to check if needs updating (and adds columns as necessary)
    • - just transaction log table for now (only table with added columns)
    • another option added: AutoUpdate
      • - if a new update is found, will download & install
      • - can also run manually with /shop updade (OP-only, since forces update & restarts server plugins)
    Version 1.6.3.5 - 4/4/11 - jascotty2
    • fixed a rare null exception in integretycheck?
    • fixed saving errors when transaction logging disabled
    • implemented infinite stock (setting stock to -1 makes infinite)
    • # 1,000+ downloads in one day!
    Version 1.6.3.4 - 4/3/11 - jascotty2
    • fixed a rare invalid function signature error
    • fixed if a player tries to buy/sell air
    • OPs now completely bypass security checks
    • more changes to error reporting format: added a custom message
    • # 10,000+ lines of code :)
    Version 1.6.3.3 - 4/2/11 - jascotty2
    • renamed monstertamer package, to avoid conflicts if you're using the monstertamer plugin
    • should have a reported bug in integrety check taken care of.. not sure of the cause, though
    Version 1.6.3.2 - 4/2/11 - jascotty2
    • fixed more error reporting bugs (still can't find one stupid stock flatfile bug)
    • added stock messages to config
    Version 1.6.3.1 - 4/1/11 - jascotty2
    • fixed chickens & buying more than one animal
    • updated error reporting(again)
    • rand libary update for my (jascotty2's) version of CookieMonster
    Version 1.6.3 - 4/1/11 - jascotty2
    • fixed buy/sell == 0 ? no (in shoplist, 0 incorrectly showed as no)
    • updated for 612 (and 600+ .. had accidently been using the wrong libary)
    • LivingEntities can now be purchased! :D
      • special thanks to fullwall for the MonsterTamer plugin, from which this ability comes from (1.3)
      • if capable, will attack the anything attacking the purchaser (if nearby)
    Version 1.6.2.8 - 3/31/11 - jascotty2

    • nullpointer fixed if running 602 with old groupmanager
    • other misc. null fixes
    • removed redundant reload points for iConomy
    • repaired a mysql totalTransactionLog format error
    • error reporting now begins with a portion of the date, so i can see them listed in order
    • more info added to error reports.. still can't figure out the stock flatfile save bug
    Version 1.6.2.7 - 3/30/11 - jascotty2

    • improved error reporting format & removed a few unnecessary send triggers
    Version 1.6.2.6 - 3/30/11 - jascotty2

    • now checks for missing & unused configuration nodes
    • strings have default values if missing
    • auto error reporting added (can be disabled)
    • now compatible with bukkit 602
    • help main page integration can be disabled
    • hidden changes to get one step closer to dynamic pricing
    Version 1.6.2.5 - 3/28/11 - jascotty2

    • forgot to update the date in the last release, so a false 'newer release' was showing up
    • fixed help support when help loaded before bettershop
    Version 1.6.2.4 - 3/25/11 - jascotty2

    • Added support for my new plugin: MinecraftIM :)
    • removed a stock debugging line i forgot to remove
    • manually set locale for updating date format.. should fix non-us countries?
    Version 1.6.2.3 - 3/23/11 - jascotty2

    • added stock db to reload
    • fixed a stock update on sell
    • updated plugin commands to include sellstack (oops :oops:)
    Version 1.6.2.2 - 3/23/11 - jascotty2

    • more commands added to register with help
    • fixed a MySQL update syntax error for stock
    Version 1.6.2.1 - 3/23/11 - jascotty2

    • fixed a plural search bug
    • added /sellstack (much like buystack)
    • fixed a buyagain logic error
    • /shop import <file> - insert values from file in plugin folder
    • /shop restore <file> - clear shop & load from saved backup file
    • flatfile itemstock repaired
    Version 1.6.2 - 3/23/11 - jascotty2

    • stock option - items can have a finite amount
      • selling to the shop increases the stock, buying decreases
      • can have a minimum update interval: time before will reset stock to initial amounts
      • maximum stock: most will hold
      • noOverStock: will not allow selling if item stock is full
    • note on stock: does not track each item's damage values (if tools)
      • (selling a damaged good allows 1 intact to be bought)
    • /shop restock (permission BetterShop.admin.restock) to update how much stock the shop has
    • permission node BetterShop.admin.backup added for backing up the pricelist
    • added Help plugin integration: will automatically register commands with help
    • added some more MySQL db connection reconnect points (autoReconnect=true not working is becomming irritating)
    • more checking for iConomy account editing failures (i've had more problems with it)
    • fixed a format error if using a replacement char in listing (like <l.>)
    • retructured sellall inventory editing
    • # passed 7500 lines of code! (430KB)
    Version 1.6.1.4 - 3/21/11 - jascotty2

    • (hopefully) fixed MySQL region formatting errors (such as europe where the decimal is a comma)
    • addto/updated help menu
    • added [command] to help: lookup a specific command (also accepts aliases)
    • fixed flatfile total transactions log
    • shop ver[sion] also shows if the plugin is up-to-date
    Version 1.6.1.3 - 3/20/11 - jascotty2

    • default color for items
    • plural-insensitive items: if not found, will check if plural & remove "s"
    • fixed transaction log insert missing the price
    • was having problems reading bit from php, so shanged SOLD column from bit to tinyint
      • alter table BetterShopMarketActivity change column SOLD SOLD TINYINT;
    • finished flatfile support for transaction logging
    Version 1.6.1.2 - 3/20/11 - jascotty2

    • runs MySQL connection check before executing database queries, and manually attempts reload if not connected
      • (still trying to iron out MySQL connection bugs, but this should end those errors)
    • removed list debugging lines i forgot to remove earlier
    Version 1.6.1.1 - 3/19/11 - jascotty2

    • removed double negative add check.. can add an item for -1, -1
    • fixed some Item errors: color and .equals(ItemStack).. fixes itemdb colors and sellall
    • fixed page numbering for when there are hidden items
    • fixed sell for 0: a <= instead of < .. thought i'd fixed that, but apparently not all of those.
    Version 1.6.1 - 3/19/11 - jascotty2

    • update check is optional (in config)
    • /shop backup to save pricelist to a backup csv file
    • updates itemsdb on shopload, in case the admin wanted to update colors/kits and such
    • added price column in marketHistory table
      • upgrading from older version?
      • ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);
    • added flatfile support for transaction logging (uses csv)
    • removed pricelist save file on close (is already saved on edit)
    • if an item is marked as no buy, no sell, don't show on shoplist
    • itemsdb names can be saved (and outputted) with title formatting (eg RedstoneTorch)
    • - included itemsdb also expanded & names formatted
    • case-insensitive item matching
    Version 1.6.1 alpha - 3/18/11 - jascotty2

    • Checks git to see if there is a newer version avaliable
    • fixed price = 0 to be free
    • fixed null in sellall if selling all sellable
    Version 1.6.0f - 3/18/11 - jascotty2

    • better error check for config & importing old yml pricelist
    • MySQL pricelist can be cached for a given timespan (decreases table selects)
    • fixed sell bug (selling one would credit for amount in the first stack)
    Version 1.6.0e - 3/17/11 - jascotty2

    • fixed a removal error - there was a typecast exception previously
    Version 1.6.0d - 3/17/11 - jascotty2

    • if the old PriceList.yml file exists, will import into whatever db is enabled, then rename the file
    • fixed public message bug - would send broadcast (num_players-1) times
    Version 1.6.0c (?) - 3/17/11 - jascotty2

    • added more options: allowbuyillegal, usemaxstack, buybacktools
    • fixed buystack history
    • major buystack logic error repaired - previously didn't work correctly
    • buystack can now be given multiple items, or number of stacks: "/buystack wool 5" or "/buystack wool blackdye reddye"
    • damaged tools can now be resold for an adjusted value of sellprice*(1-(damage/maxdamage))
    Version 1.6.0b (?) - 3/16/11 - jascotty2

    • fixed a minor buy error if tried to buy more than they can hold, and could hold 0 more
    • major MySQL problem fixed - pricelist table wasn't being created
    Version 1.6.0 - 3/16/11 - jascotty2

    • major code restructure & reorganization
    • changed item db to a more descriptive yml file
      • can define what items make an item (for calculated/dynamic costs)
      • can change what color it will be outputted as in the listing
      • define kits (sold.. store won't buy them)
    • MySQL buy & sell fields increased to decimal(11,2), and cap in program set to 999,999,999
    • shoplist can now optionally not show listing tail (or head, but recommended to leave <page> of <pages>)
    • removed value check - can now "sell" items that sell for 0
    • added /shop command alias - for if a user is more used to "/shop help" than "/shophelp"
    • many commands have sub-aliases.. eg. shoplist kits will run shoplistkits
    • now does pre-check for if user can hold as much as they're trying to buy
      • and "all" to try to buy as many as they can hold
    • items can be marked as illegal, and can only be purchased by a select few (using permissions)
      • also not shown to users who cannot buy them, except with pricecheck
    • option in config to make transactions publicly broadcasted
    • option in config to have a custom sort order
    • shopsellall can be given multiple items (/sell all cobble gravel flint dirt)
    • now shows what items were sold when using shopsellall
    • fixed bug where single sell parameter would == sell [item] all
    • all, full, -1 added as a pricelist pagenumber: will print the full list (intended for console use)
    • marketactivity table truncate logic repaired..
    • marketactivity MySQL table changed with primary key(DATE, USER, ID) (instead of DATE, USER) to resolve conflicts with sellall
    • items can be marked as 'legal: false', and only those with permissions can buy them (can still sell)
    • if encounters errors while editing a player's account, will attempt to reload iConomy
    • sellall can be given "inv" as first parameter to only sell from inventory (not in quick access slots)
    • shopcheck given partial name matching: "/shopcheck wool" (not "shopcheck 35") will show all colored wool prices :)
    • fixed sellall bug when an item not for sale
    • /shopbuystack (buystack): buy a stack of an item (usually 64)
    • /shopbuyagain (buyagain,sba): repeat last buy action
    • /shopsellagain (sellagain,ssa): repeat last sell action
    • /shopkits (skits): show a listing of avalliable kits (will be elaborated later)
    • can now buy kits :)
    • /add now has sell as an optional parameter.. will set to -1 if not given (or if is a kit)
    Version 1.5.9b - 3/11/11 - jascotty2

    • width outputting in minecraft chat (for /shoplist): now can have item (or listing) right-align, left-align, or centered
    • implemented transaction log and total transactions record
    • no longer dependent on permissions: if missing, ops have .admin.* & everyone has .user.*
    • bugs: MySQL buy & sell is decimal(6,2), limiting price to 9,999 (plus a nondescriptive error)
      • to fix (db minecraft, table BetterShop):
      • alter table minecraft.BetterShop change column buy buy decimal(11,2);
      • alter table minecraft.BetterShop change column sell sell decimal(11,2);
    • unknown error: MySQL connection seems to get dropped & won't connect until restart plugin
      • seems to stem from iConomy (v4.4 (Arcadia)) or v0.2 [Coelho].. i only have 4.4, but .2 is being logged
      • shopload should fix this, but iconomy will still be down.. if you have a plugin like hotswap, reload iConomy
    • not a bug, but forgot to remove: debug output of select statements being executed
    Version 1.5.8(?) - 3/10/11 - jascotty2

    • fixed a sell error for one parameter
    • major-ish code restructure - removed data redundancy
    • / shopsell all [item] (alias to /shopsell [item] all)
    Version 1.5.7(?) - 3/10/11 - jascotty2

    • / shopsell [item] all added: sell all of an item that you have
    • fixed total sell value min to .01 instead of 1 (if your server uses low prices)
      • before this fix, one could get around this check by trying to sell alot of an item
    • now automatically downloads mysql dependency (zip from mysql mirror & unzip or from iConomy mirror)
    Version 1.5.5(?) - 3/9/11 - jascotty2

    • Pricelist can now be in a MySQL database
    Version 1.5.4 - 3/2/11

    Fixed some lingering bugs with lologarithm's help.


    Version 1.5.3
    Fixed sell 0 < sellprice < 1 bug.


    Version 1.5.2
    Now it'll convert your old pricelist.yml to the new 1.5.x format automagically!


    Version 1.5.1
    Fixed the bug where setting a price to -1 didn't disable it
    Fixed the "LOLWTFDOESN'TWORK" bug.
    Made price-list listing configurable in config.yml. The way it was 'sposta be.

    (older versions not shown..)

     
  2. Offline

    Amin Azman

    thanks, help alot!
     
  3. Offline

    jjfs85

    Sorry to have forgotten to update that :\
     
  4. Offline

    buckeT.de

    Hey,
    great work again (I love this check update function onLoad <3 )

    But the critic will follow on purpose :-(
    Maybe update /shophelp command?
    e.g. "SHOP: /shopload - Reload the PriceList.yml file"
    and the new short commands /ssa and so would be nice.



    Greetz,
    buckeT
     
  5. Offline

    jascotty2

    Version 1.6.1.4 :)
    (hopefully) fixed MySQL region formatting errors (such as europe where the decimal is a comma)
    addto/updated help menu
    added [command] to help: lookup a specific command (also accepts aliases)
    fixed flatfile total transactions log
    /shop ver[sion] also shows if the plugin is up-to-date
     
  6. Offline

    Fritz3

    It is possible to use an area for the shop? So that the Players only can buy/sell there?
     
  7. Offline

    serenewaffles

    Whoops. Guess I got confused between TODO and the option being in the settings file. In any case, I hope shop stock is coming soon, because it's the only thing preventing me from switching my server to bukkit, and this plugin looks like it's the best candidate.
     
  8. Offline

    Greedish

    Could anyone share a balanced price table that they use on their server? It's such a pain to configure all the prices and think up what each item is worth!
     
  9. Offline

    jascotty2

    that's in the works as well.. don't know when it will be available, but it is something we're working on
    there are two sample pricelists in the description (under "Installing").. don't know about jjfs85's, but i know i tried to make my shop as balanced as i could, and so one wouldn't be able to make money by just buying & selling
     
  10. Offline

    FabianN

    I'm getting an mysql error after a recent update to Bettershop
    I'm running Bettershop 1.6.1.4
    Code:
    2011-03-21 22:58:51 [INFO] Loading BetterShop version 1.6.1.4 ...
    2011-03-21 22:58:55 [INFO] [BetterShop] BetterShop is up-to-date
    2011-03-21 22:58:55 [INFO] [BetterShop] MySQL database localhost:iconomy/BetterShop loaded.
    2011-03-21 22:58:55 [SEVERE] [BetterShop] Error executing SELECT on BetterShopMarketActivity
    java.sql.SQLException: Column Index out of range, 8 > 7.
    	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1055)
    	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:956)
    	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:926)
    	at com.mysql.jdbc.ResultSetImpl.checkColumnBounds(ResultSetImpl.java:792)
    	at com.mysql.jdbc.ResultSetImpl.getStringInternal(ResultSetImpl.java:5529)
    	at com.mysql.jdbc.ResultSetImpl.getString(ResultSetImpl.java:5448)
    	at com.mysql.jdbc.ResultSetImpl.getDoubleInternal(ResultSetImpl.java:2382)
    	at com.mysql.jdbc.ResultSetImpl.getDouble(ResultSetImpl.java:2343)
    	at com.nhksos.jjfs85.BetterShop.BSTransactionLog.updateCache(BSTransactionLog.java:270)
    	at com.nhksos.jjfs85.BetterShop.BSTransactionLog.truncateRecords(BSTransactionLog.java:245)
    	at com.nhksos.jjfs85.BetterShop.BSTransactionLog.truncateRecords(BSTransactionLog.java:228)
    	at com.nhksos.jjfs85.BetterShop.BSTransactionLog.load(BSTransactionLog.java:49)
    	at com.nhksos.jjfs85.BetterShop.BetterShop.onEnable(BetterShop.java:122)
    	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:118)
    	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:451)
    	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:217)
    	at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:92)
    	at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:70)
    	at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:204)
    	at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:191)
    	at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:131)
    	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:246)
    	at net.minecraft.server.ThreadServerApplication.run(SourceFile:366)
    2011-03-21 22:58:55 [SEVERE] [BetterShop] Error executing SELECT on BetterShopMarketActivity
    java.sql.SQLException: Column Index out of range, 8 > 7.
    	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1055)
    	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:956)
    	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:926)
    	at com.mysql.jdbc.ResultSetImpl.checkColumnBounds(ResultSetImpl.java:792)
    	at com.mysql.jdbc.ResultSetImpl.getStringInternal(ResultSetImpl.java:5529)
    	at com.mysql.jdbc.ResultSetImpl.getString(ResultSetImpl.java:5448)
    	at com.mysql.jdbc.ResultSetImpl.getDoubleInternal(ResultSetImpl.java:2382)
    	at com.mysql.jdbc.ResultSetImpl.getDouble(ResultSetImpl.java:2343)
    	at com.nhksos.jjfs85.BetterShop.BSTransactionLog.updateCache(BSTransactionLog.java:270)
    	at com.nhksos.jjfs85.BetterShop.BSTransactionLog.load(BSTransactionLog.java:71)
    	at com.nhksos.jjfs85.BetterShop.BetterShop.onEnable(BetterShop.java:122)
    	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:118)
    	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:451)
    	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:217)
    	at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:92)
    	at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:70)
    	at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:204)
    	at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:191)
    	at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:131)
    	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:246)
    	at net.minecraft.server.ThreadServerApplication.run(SourceFile:366)
    2011-03-21 22:58:55 [INFO] [BetterShop] Attached to iConomy.
    2011-03-21 22:58:55 [INFO] [BetterShop] Attached to Permissions.
    2011-03-21 22:58:55 [INFO] BetterShop version 1.6.1.4 is enabled!
    
    
    Bukkit:
    2011-03-21 22:58:42 [INFO] Starting minecraft server version Beta 1.3
    2011-03-21 22:58:42 [INFO] Loading properties
    2011-03-21 22:58:42 [INFO] Starting Minecraft server on *:25565
    2011-03-21 22:58:42 [INFO] This server is running Craftbukkit version git-Bukkit-0.0.0-552-gf9a4b36-b559jnks (MC: 1.3)
     
  11. Offline

    GizmoTheGreen

  12. Offline

    jascotty2

    i mentioned that i added a column to that table.. you could drop it, or run the table update:
    in the plugin description, under "Installing"
    ALTER TABLE BetterShopMarketActivity ADD COLUMN PRICE DECIMAL(11,2);



    i use that plugin, too :)
    never thought of automatically registering with it.. that sounds like a good idea :)

    Version 1.6.2 :D
    stock option - items can have a finite amount
    - selling to the shop increases the stock, buying decreases
    - can have a minimum update interval: time before will reset stock to initial amounts
    - maximum stock: most will hold
    - noOverStock: will not allow selling if item stock is full
    - note on stock: does not track each item's damage values (if tools) .'. selling a damaged good allows 1 intact to be bought
    /shop restock (permission BetterShop.admin.restock) to update how much stock the shop has
    permission node BetterShop.admin.backup added for backing up (and eventually restoring) the pricelist
    added Help plugin integration: will automatically register commands with help
    added some more MySQL db connection reconnect points (autoReconnect=true not working is becomming irritating)
    more checking for iConomy account mod failures (i've had more problems with it)
    fixed a format error if using a replacement char (like <l.>)
    retructured sellall inventory editing
    # passed 7500 lines of code! (430KB)

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 8, 2016
  13. Offline

    lenocinor

    Thanks as always for your hard work on this plugin. :) Getting a few new bugs in the new version:

    - When I type /buyagain after buying something, it doesn't buy anything and says "You have no recent sell history"
    - /sellstack appears not to work at all
    - "/sc leaves" returns all three types of leaves three times in the listing (so nine listed items total)...no other partial item names I've seen do this though

    Also, I know you haven't made any changes regarding them, but just reminding that kits are not working and used fishing rods are not selling. I'm guessing you plan to look into these bugs sometime later.
     
  14. Offline

    roly

    any idea what are permissions name we add to the groupmanager groups.yml?
     
  15. Offline

    Kostronor

    I use
    Code:
        - BetterShop.admin.illegal
    for buying water usw.
        - BetterShop.user.*
    for allowing buying and selling
    Damn, the downloadlink is still 1.6.1.4 >.<
    Please update :D
    And please give an option to import the pricelist into the database (from csv to mysql)

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 8, 2016
  16. Offline

    jascotty2

    Version 1.6.2.1
    fixed a plural search bug (where "leaves" would return 3 times)
    added /sellstack (much like buystack)
    fixed a buyagain logic error
    /shop import <file> - insert values from file in plugin folder
    /shop restore <file> - clear shop & load from saved backup file
    flatfile itemstock repaired
    (thanks for the bug reports :))
    fishing rods were missing a maxdamage value.. you should update your itemsdb (see the description)
    as for kits: they're working fine for me.. what is the error you're getting?

    the static jar should always be the most current release
     
  17. Offline

    lenocinor

    Ah, didn't realize I needed to add those maxdamage values, so added them and all the item sales work now. Thanks!

    Went and retested the bugs, and they're fixed too now, except for /sellstack (which does nothing when I type it currently) and the kits thing. I don't get any error when I type "/shopkits", either in the main window or the console. It just says:
    "SHOP: Kit listing:
    SHOP:
    "
    This happens with the default itemsdb.yml, too. Let me know if you need my YML or CSV files for testing.

    PS: Don't forget to add import/restore/sellstack to the help command, don't see them there at the moment.
     
  18. Offline

    Tokew

    Hi, great plugin.
    I am experiencing a bug when using the new stock feature. Here is my setup:

    Config.yml
    itemStock:
    enabled: true
    tablename: BetterShopItemStock
    startStock: 0
    maxStock: 5000
    noOverStock: true
    restock: 0

    BetterShop.csv
    id,subdata,buyprice,sellprice,name
    87,0,50.0,50.0,Netherack
    89,0,50.0,50.0,Glowstone

    BetterShopItemStock.csv
    id,subdata,name,amount
    87,0,Netherack,1000
    89,0,Glowstone,1000



    The problem is that whenever I buy 1 item, the stock changes to 1999 (it adds 999 items) and when I sell 1 item, it add 1000 to the stock.
     
  19. Offline

    jascotty2

    Version 1.6.2.3
    added stock db to reload
    fixed a stock update on sell (thanks for finding that error :))
    updated plugin commands to include sellstack (sorry about that)

    Version 1.6.2.2
    more commands added to register with help
    fixed a MySQL update syntax error for stock

    /shopkits lists the kits that are for sale, not the ones that can be added to the pricelist..
    you have to add a kit to the shoplist before it can be seen there
     
  20. Offline

    Mattdk

    Why can't I find any compiled artifacts on your github?

    edit: nvm. x)
     
  21. Offline

    lenocinor

    Ah, I didn't realize that. Maybe I was being dense but for some reason I just assumed the prices for kits would be calculated. They work great now, thanks. I would mention somewhere though that kits must start with ID 5000 in the CSV, and this ID must increment by 1 for each kit added.

    Oh, and the static JAR points to a version that's a version old at the moment. I had to download the latest version at GitHub.

    All the old bugs I've reported seem to be fixed, and I can't find any new ones. Hooray! :) I'll try to keep up with new versions and report any regressions though. Thanks again for this shop and for your help getting it going. It's really a joy to use on our server.
     
  22. Offline

    jascotty2

    i upload two files with each release to the BetterShop downloads page.. one with the version appended to the filename & one to replace the old static jar.... not sure how you're getting an older version, since the downloads page isn't cached. :confused:
    thanks for the feedback :)
     
  23. Offline

    Tokew

    I am still experiencing the shop buy/sell stock-bug.

    Original value
    89,0,Glowstone,1000

    Value following the "/shop buy glowstone" command
    89,0,Glowstone,1999

    Value following the "/shop sell glowstone" command
    89,0,Glowstone,3000

    Nevermind my last message. It works great now. Thank you! :)
    I can however confirm Lenocinors claim that the static jar link points to an old version. The github version included the new stock bugfixes.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 8, 2016
  24. Offline

    jascotty2

    that is very strange.. i've tried downloading from the post link to see if i can get that, but i get the up-to-date version.
    there must be some caching going on, though... it's giving you the file you've already downloaded for some reason.
    maybe could be the browser or git not updating all of their copies ??? :confused:
     
  25. Offline

    XspeedPL

    I got this everytime:
    Code:
    21:43:40 [WARNING] [BetterShop] uxexpected error during check for updates
    java.text.ParseException: Unparseable date: "Wed Mar 23 19:08:25 -0700 2011"
    at java.text.DateFormat.parse(Unknown Source)
    at com.nhksos.jjfs85.BetterShop.Updater.isUpToDate(Updater.java:117)
    at com.nhksos.jjfs85.BetterShop.Updater.check(Updater.java:42)
    at com.nhksos.jjfs85.BetterShop.Updater.check(Updater.java:34)
    at com.nhksos.jjfs85.BetterShop.BetterShop.onEnable(BetterShop.java:147)
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:118)
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:451)
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:217)
    at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:92)
    at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:70)
    at net.minecraft.server.MinecraftServer.e(MinecraftServer.java:204)
    at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:191)
    at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:131)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:246)
    at net.minecraft.server.ThreadServerApplication.run(SourceFile:366)
    
    
     
  26. Offline

    jascotty2

    that's not the fist i've seen that, and i'm not sure where it comes from, since that is the valid date format :(
    the other error came from someone in europe.. what country are you in?
     
  27. Offline

    XspeedPL

    Poland. So this exception is caused by my regional settings?
     
  28. Offline

    jascotty2

    Version 1.6.2.4
    Added support for my new plugin: MinecraftIM :)
    removed a stock debugging line i forgot to remove
    manually set locale for updating date format.. should fix non-us countries?

    i'm not sure.. i can't get it to reproduce :(
    try the next version.. i added a manual locale, so hopefully that should fix it.
     
  29. Offline

    serenewaffles

    I am not getting anything for BetterShop with Help 0.2

    EDIT: Running BetterShop 1.6.2.3
     
  30. Offline

    lilsasquach

    Im sorry to sound stupid, and this problebly is not the place to post this, but i filled out the permissions and its still not working. It still says i don't have permission, and im an admin. Now i don't know if i filled it out right, it looks like this

    Admins:
    default: true
    info:
    prefix: ''
    suffix: ''
    build: true
    inheritance:
    permissions:
    - 'BetterShop.user.*'
     
  31. Offline

    jascotty2

    if you're getting error messages in the console, try my help fork (0.2.3): https://github.com/downloads/jascotty2/Help/Help.jar

    just a pointer: you probably shouldn't make Admins to be a default group
    it looks ok to me.. but i use groupmanager.. you might want to make sure that you reloaded the permissions config after changing the file
     

Share This Page