[INACTIVE][ADMN] SimpleSave v3.25 Simple automatic saving! [000] - Backups!

Discussion in 'Inactive/Unsupported Plugins' started by desmin88, Mar 11, 2011.

  1. Offline

    desmin88

  2. Offline

    TerrorBite

    I set SimpleSave to back up every 6 hours (360 minutes). However, it appears to be backing up every time a user logs out instead. I'm guessing this could be a bug involving the schedulers?
     
  3. Yeah, now I'm having the same thing, it keeps saving like mad. How do I fix this?
     
  4. Offline

    TerrorBite

    It's not too bad for me cause there's relatively few people on my server currently while the word spreads that it's back up, so people don't log out often.
    But once it starts getting more users, it will start to become an issue.

    By the way ImmortalOverlord, you got post number 399999.
     
  5. Offline

    Scizzr

    I'm having the same issue on my server, I've got it set to 15-minute saves and 60-minute backups and I sat here and watched it over the course of an hour and it saved 8 times and backed up twice.

    I did notice on both @d3rtus and my server log, the server backs up at [x] time, then exactly 1 minute later.
    Code:
    back,save    time    : note            (counter[s])
    ==================================================================================
     (0b,0s)     1:56:03 : Player login.   (time = 0 mins)
     (0b,1s)     2:10:04 : World saved.    (time = 14 mins)
     (0b,2s)     2:11:06 : World saved.    (time = 15 mins; 1 min since last save)
     (0b,3s)     2:25:06 : World saved.    (time = 29 mins; 14 mins since last save)
     (0b,4s)     2:26:06 : World saved.    (time = 30 mins; 1 min since last save)
     (0b,5s)     2:40:07 : World saved.    (time = 44 mins; 14 mins since last save)
     (0b,6s)     2:41:07 : World saved.    (time = 45 mins; 1 min since last save)
     (1b,6s)     2:55:07 : World backup.   (time = 59 mins)
     (1b,7s)     2:55:08 : World saved.    (time = 59 mins, 14 mins since last save)
     (2b,8s)     2:56:08 : World backup.   (time = 60 mins; 1 min since last backup)
     (2b,8s)     2:56:09 : World saved.    (time = 60 mins, 1 min since last save)
    
    Here is my config file:
    Show Config
    Code:
    #SimpleSave Config File 
    #Tue Jun 21 00:18:11 EDT 2011
    save.use=true
    save.interval=15
    save.message.send=true
    save.message.starting=§7[§fServer§7]§f: §6Beginning world save.
    save.message.ending=§7[§fServer§7]§f: §2World save complete.
    save.message.color=WHITE
    backup.use=true
    backup.world.filter=
    backup.interval=60
    backup.history.length=24
    backup.message.send=true
    backup.message.starting=§7[§fServer§7]§f: §6Beginning hourly backup.
    backup.message.ending=§7[§fServer§7]§f: §6Hourly backup complete.
    backup.message.color=WHITE
    backup.date.format=yyyy-MM-dd hh-mm-ss
    backup.directory=backup
    plugin.send.saveoff-on=true
    plugin.ignore.noplayers=true
    plugin.version=3.1
    


    As people have said, this is a very useful plugin but it just needs this one detail hammered out. Since I have 'backup.history.length=24', this also limits me to effectively 12 hours since it is doing 2 backups every hour. If I wanted to do 24 backups (so that I have one for each hour of the past day), I would be forced to double this, which is very bad when you have 3 maps totaling nearly 150MB (48*150MB is 7.2GB that's constantly being used as backups).

    Good eye. I noticed that as well. I'm not really sure if this has anything to do with why it's still backing up more frequently that configured, but nonetheless a minor bug. :)

    Thanks for a great plugin otherwise. If you do fix this, your plugin will be golden.
     
  6. Offline

    Ratchet

    I'm only using simplesave for backups and it isn't working for that.

    this is my config;
    Code:
    #SimpleSave Config File 
    #Sun Jun 19 04:07:32 BST 2011
    save.interval=10
    save.use=false
    backup.message.ending=[SimpleSave] Ending world backup
    backup.message.starting=[SimpleSave] Beginning world backup
    backup.directory=backup
    backup.history.length=3
    save.message.send=true
    backup.use=true
    plugin.send.saveoff-on=true
    backup.interval=300
    plugin.ignore.noplayers=true
    backup.world.filter=
    save.message.color=RED
    backup.message.color=RED
    plugin.version=3.1
    backup.message.send=false
    save.message.starting=[SimpleSave] Beginning world save
    save.message.ending=[SimpleSave] Ending world save
    backup.date.format=dd-MM-yy hh-mm-ss
    
    server has been running 2 days now and no backups have been made
     
  7. Offline

    desmin88

    @Ratchet
    On your side, my backups are perfectly fine. Try setting backups to 30 minutes, I think it's innacurate due to bukkit schedulers.
    @cembry90
    Very detailed report. I think it has to due with the inaccuracies of bukkit's schedulers.

    I'm going to work on a rewrite that will use threads and not bukkits inaccurate scheduler for a more robust hardy saving system.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 11, 2016
  8. Offline

    fatmarley

    cheers. This mod is very helpful and glad you are keeping at it.
     
  9. Offline

    Steeled

    Github says error :(

    Whatever it works now.
     
  10. Offline

    desmin88

    @Steeled
    Your very undescriptive. How can I fix this 'problem' your having if you don't tell me any information about it.
     
  11. Offline

    Jake Radcliff

    When it is time for the plugin to do /save-all (the equivalent) it generates the error code below. Also, it doesn't back up the server. At all. No backup folder in the server root folder.
    Code:
    2011-06-22 22:02:12 [INFO] Saving World. . .
    2011-06-22 22:02:12 [WARNING] Task of 'SimpleSave' generated an exception
    java.lang.IllegalArgumentException: No enum const class org.bukkit.ChatColor.PURPLE
        at java.lang.Enum.valueOf(Enum.java:196)
        at org.bukkit.ChatColor.valueOf(ChatColor.java:9)
        at org.desmin88.simplesave.SimpleSave$SaveMethod.run(SimpleSave.java:125)
        at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:138)
        at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:386)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:309)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
     
  12. Offline

    desmin88

    @Jake Radcliff
    There is no color purple for message colors.
    Check color values in the OP configuration spoiler
     
  13. Offline

    Jake Radcliff

    *Facepalm* Thank you... I should have read over the error message before just posting it... You are awesome.
     
  14. Offline

    fatmarley

    Would like a manual save command with permissions if possible. Been having issues with towny and would like to save prior to restarting the server.
     
  15. Offline

    Madmusk

    Just started using this and I'm a bit confused. I have it set to backup every 30 minutes and save history is 20. When I check my backup folder (after running it all night) I have 10 backups and they range from every 10 minutes to 20 minutes. Is this because of the inaccurate Bukkit scheduler problem? Why do I only see 10 backups?

    Thanks! Love the plugin other than these confusing issues.

    Edit: Just noticed this too: the size of the nether zip files varies greatly over time. Started at 1.5MB (unused) and went down to around 300k before gradually getting to 1.5MB again.
     
  16. Offline

    MCreation

    08:39:13 [INFO] [SimpleSave] Beginning world backup
    08:39:13 [INFO] [SimpleSave] Beginning world save
    08:39:14 [SEVERE] SimpleSave: Error when copying files!
    08:39:14 [SEVERE] SimpleSave: This means a plugin you have is not acting nice, o
    r isn't threadsafe
    08:39:14 [SEVERE] SimpleSave: Go to my thread and post the following information

    08:39:14 [INFO] Failed to copy full contents from 'world\region\r.-1.-1.mcr' to
    'backup\world\region\r.-1.-1.mcr'null
    08:39:14 [SEVERE] java.io.IOException: Failed to copy full contents from 'world\
    region\r.-1.-1.mcr' to 'backup\world\region\r.-1.-1.mcr'
    08:39:14 [SEVERE] at org.desmin88.simplesave.FileUtils.doCopyFile(FileUtil
    s.java:310)
    08:39:14 [SEVERE] at org.desmin88.simplesave.FileUtils.doCopyDirectory(Fil
    eUtils.java:265)
    08:39:14 [SEVERE] at org.desmin88.simplesave.FileUtils.doCopyDirectory(Fil
    eUtils.java:263)
    08:39:14 [SEVERE] at org.desmin88.simplesave.FileUtils.copyDirectory(FileU
    tils.java:230)
    08:39:14 [SEVERE] at org.desmin88.simplesave.FileUtils.copyDirectory(FileU
    tils.java:156)
    08:39:14 [SEVERE] at org.desmin88.simplesave.FileUtils.copyDirectory(FileU
    tils.java:125)
    08:39:14 [SEVERE] at org.desmin88.simplesave.Backup.backup(Backup.java:42)

    08:39:14 [SEVERE] at org.desmin88.simplesave.SimpleSave$BackupMethod.run(S
    impleSave.java:144)
    08:39:14 [SEVERE] at org.bukkit.craftbukkit.scheduler.CraftWorker.run(Craf
    tWorker.java:34)
    08:39:14 [SEVERE] at java.lang.Thread.run(Unknown Source)
    08:39:17 [INFO] [SimpleSave] Ending world backup
    08:39:19 [INFO] [SimpleSave] Ending world save
    08:39:19 [WARNING] Can't keep up! Did the system time change, or is the server o
    verloaded?

    I DONT KNOW WATS WRONG!!!?!?!?!?!?!?! ;/
    >
     
  17. Offline

    Felonu

    I would wonder if you have 2 worlds... the save history is a total between all worlds so if you have 2 worlds you will get 10 from each world saved... the timing part is likely to do with the scheduler issue.
     
  18. Offline

    desmin88

    @MCreation
    Ignored.

    To users of SimpleSave, expect a new version out tomorrow or sunday that fixes the issues of wrong saving/backup times.

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 11, 2016
  19. Offline

    Master_Rudik

    Can we get a command to force backup? That's pretty much all I feel this plugin is missing. (BTW I still love it even if you don't add that. I'll just love it more if you do.)
     
  20. Offline

    Reterg

    /ssbackup works I think. Not from the console though. Only in game.
     
  21. Offline

    Bronski

    Good to hear. I'll just keep it in then I guess. I just noticed when I fell to another world (with the Inception plugin) that the backup fired. I'm not sure if that was it thinking I "left" or if your issues involves multiworld stuff but maybe that will help.

    I guess my only other requests would be an option to backup the plugins folder and the mysql database (it's not like I can leave them out of a comprehensive backup plan), though I know not everyone uses mysql :D
     
  22. Offline

    TfT_02

    Thank you for updating to 928 so quickly :)
     
  23. Offline

    desmin88

    SS updated to 3.2:
    Ultra robust scheduling system...no lag or delays on saves/backups happens to the second.
     
  24. Offline

    Bronski

    CB860, got this when I logged in after just starting the server:

    20:58:26 [SEVERE] Could not pass event PLAYER_JOIN to SimpleSave
    java.lang.IllegalStateException: Timer already cancelled.
    at java.util.Timer.sched(Unknown Source)
    at java.util.Timer.schedule(Unknown Source)
    at org.desmin88.simplesave.SSplayerListener.Scheduling(SSplayerListener.java:65)
    at org.desmin88.simplesave.SSplayerListener.onPlayerJoin(SSplayerListener.java:25)
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:243)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:310)
    at net.minecraft.server.ServerConfigurationManager.c(ServerConfigurationManager.java:126)
    at net.minecraft.server.NetLoginHandler.b(NetLoginHandler.java:96)
    at net.minecraft.server.NetLoginHandler.a(NetLoginHandler.java:33)
    at net.minecraft.server.NetworkListenThread.a(SourceFile:91)
    at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:399)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:309)
    at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)
     
  25. Offline

    desmin88

    @Bronski
    Fill out an error reporting form from the OP. Then I can help you.

    @Bronski
    Woops, my big error there. Update soon.
    Updated to 3.21, fixes exception

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: May 11, 2016
  26. Offline

    ACStache

    @desmin88
    is the link to 3.21? I tried updating and it still says 3.13

    edit: launching the server says 3.13 initialized. Also, not sure if it was fixed in 3.2(1) or not, but it's currently saving the server when no one is logged in, and plugin.ignore.noplayers=false in the config.
     
  27. Offline

    desmin88

    @ACStache
    Woops, forget to set that. But yes, its 3.21
    I'm looking into that error.
     
  28. Offline

    Ratchet

    is there a command to do a manual backup?
     
  29. Offline

    lexon

    [​IMG]

    When shutting down my server i get the following error....
     
  30. Offline

    ACStache

    I think it's /ssBackup although I'm not 100% sure.

    Also, @desmin88 I can't seem to download the right version, every time I click the link it gives me 3.13 :(
    I've cleared the config and jar from my computer before downloading and it's still not right.
     
  31. Offline

    desmin88

    @lexon
    Your using an outdated version.
    @ACStache
    I've told you already I forgot to change it to 3.21.
    Anyways update to 3.22
     

Share This Page