Solved I need a bit of ItemStack help.

Ok guys, as much as i hate to do this, i must ask for some advice. I am making a guns plugin and i have a few custom items (ammo, guns, ect) and i am having trouble with the whole distribution prosess.
Here is an itemstack to base it this off of.

Code:

    ItemStack ammo = new ItemStack(Material.GHAST_TEAR, 1);

Here are the questions i have:
1.) Do i need to give the item its metadata in every method its used in?
2.) I need to give/take this itemstack from peoples inventories in different quantities, whats the easyiest way to do that? Do i make methods for it? Or simply use .setAmount?

I understand i just made a complete fool out of myself, but if anybody can give me a helping hand, it truely would be appreciated. Im not asking to be spoon fed code, but a slight push in the right direction would do the trick.

 

xXRobbie21Xx

What methods is it used in, exactly?

The easiest way to do that is to search their inventory for the material, then for the ItemMeta, then change the size of the stack, and then update their inventory.

 

Setammount will work but misfires some times, use check of players inventory contains at least a amount of ghast tear before removing, if it does, player.removeItem(itemstack);// or something similar
I don't know if you ise the item in a method but it already has metadata and depends on how u use it.
And no you haven't made a fool of yourself, there are no stupid or foolish questions, here are only such answers...

 

mythbusterma mine-care
Im just going to past my whole class, if thats okay.
I tried to mess around a bit with creating my own methods in order to work around it but as you can see i need to take one bullet away when fired and i need to give a player bullets when using /ammostock, seen at the bottom.

Also, as far as the metadata goes, do i need to set it in every class its used in?

Thanks for letting me know how its done, really means alot

Code:java

public class main extends JavaPlugin implements Listener {
 
    public Map<UUID, Long> cantFire = new HashMap<UUID, Long>();
    private final int coolDownTime = 1;
 
    ItemStack ammo = new ItemStack(Material.GHAST_TEAR, 1);
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
 
 
        ShapedRecipe basicBullet = new ShapedRecipe(ammo)
                .shape(" c ", "igi", " r ").setIngredient('c', Material.COAL)
                .setIngredient('i', Material.IRON_INGOT)
                .setIngredient('g', Material.SULPHUR)
                .setIngredient('r', Material.REDSTONE);
        getServer().addRecipe(basicBullet);
 
    }
 
    public void onDisable() {
 
    }
 
 
 
 
    public void giveAmmo(Player name, int amount) {
        Player p = (Player) name;
        ItemStack ammo = new ItemStack(Material.GHAST_TEAR, amount);
        ItemMeta md = ammo.getItemMeta();
        md.setDisplayName("Ammo");
        ammo.setItemMeta(md);
 
            p.getInventory().addItem(ammo);
            p.sendMessage("Ammo giving worked from .ammo");
            return;
 
 
    }
 
    public void takeAmmo(Player name, int amount) {
        Player p = (Player) name;
        ItemStack ammo = new ItemStack(Material.GHAST_TEAR, amount);
        ItemMeta md = ammo.getItemMeta();
        md.setDisplayName("Ammo");
        ammo.setItemMeta(md);
 
        if (p.getInventory().contains(ammo)) {
            p.getInventory().remove(ammo);
            p.sendMessage("Ammo taking worked!");
        }
    }
 
 
 
 
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent e) {
        Player p = e.getPlayer();
        Action action = e.getAction();
        int coolDownMillis = coolDownTime * 1000;
        long lastUsed = 0;
 
        if (cantFire.containsKey(p.getUniqueId())) {
            lastUsed = cantFire.get(p.getUniqueId());
        }
 
        if (action == Action.RIGHT_CLICK_AIR || action == Action.RIGHT_CLICK_BLOCK) {
            if (p.getItemInHand().getType() == Material.DIAMOND_HOE) {
                if (p.getInventory().contains(Material.GHAST_TEAR)) {
 
                    if (System.currentTimeMillis() - lastUsed >= coolDownMillis) {
                        cantFire.put(p.getUniqueId(),System.currentTimeMillis());
 
                        Snowball snowball = (p.launchProjectile(Snowball.class));
                        snowball.setVelocity(snowball.getVelocity().multiply(2));
                        p.sendMessage("Works");
                        takeAmmo(p, 1);
                        p.updateInventory();
 
                    } else {
                        p.sendMessage("Gun overheating!");
                    }
                } else {
                    p.sendMessage("You dont have any ammo!");
                }
 
            }
        }
 
    }
 
    @EventHandler
    public void onEntityDamage(EntityDamageByEntityEvent e) {
        if (e.getDamager() instanceof Snowball) {
            Snowball s = (Snowball) e.getDamager();
            if (s.getShooter() instanceof Player) {
                Player shooter = (Player) s.getShooter();
                if (shooter.getItemInHand().getType() == Material.DIAMOND_HOE) {
                    e.setDamage(10.0);
                }
 
            }
 
        }
    }
 
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        Player p = (Player) sender;
        if (sender instanceof Player) {
            if (commandLabel.equalsIgnoreCase("AmmoStock")) {
                p.sendMessage("You recieved an ammo drop off!");
                giveAmmo(p, 3);
 
            }
 
        }
 
        return false;
    }

 

I think you need it for each method, and please fix this:

Player p = (Player) sender;
if (sender instanceof Player) {...}
If goes first.

 

xXRobbie21Xx

Instead you should see if the player's inventory contains it via Inventory#first(Material), then get the ItemStack in that location, check if it has the correct metadata via ItemStack#getItemMeta().getName().equalsIgnoreCase("something") and then change the size of said stack to one lower.

 

mine-care Okay cool, and thanks, i planned on revising everything right after i got some help

mythbusterma Ok, that makes sense. Thanks

I appreciate it!

 

xXRobbie21Xx good luck