How to interact with a pre existing vanilla scoreboard

I am trying to make a plugin that when a command block runs my command it will add a player's score on a scoreboard to their EssentialsX balance. How would I go about doing this, and is it even possible?

I am sorry for so many questions, this is my first plugin and I am not very familiar with coding java. Thanks for any help

 

So at first, if you want to access the vanilla scoreboard you have to use

Code:

Scoreboard s = Bukkit.getScoreboardManager().getMainScoreboard();

BUT if I understand you right you want to increase the players money in EssentialsX. EssentialsX is not using a scoreboard to save the players balance. So the easiest way to add money to the players balance is to let your plugin perform the command provided by essentialsX:

Code:

Bukkit.getServer().dispatchCommand(Bukkit.getConsoleSender(), "eco give <Name> <Amount>");

Hope this helped you

 

Thanks a lot! Below is what I made and it works perfect from a player, but I'm trying to make it work from a command block too in the Else If statement. I'm having trouble figuring out how to change

Code:Java

 Scoreboard board = player.getScoreboard();

to

Code:Java

 Scoreboard board = CraftBlockCommandSender.getScoreboard();

Any ideas?
The syntax is /rewardmoney <scoreboard player> <scoreboard objective> <player receiving money>

Code:Java

 @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String args[]) {
 
        Player player = (Player) sender;
        if (sender instanceof Player) {
            int rewardMoney;
            String Obj = args[1];
            String User = args[0];
            Scoreboard board = player.getScoreboard();
            Objective obj = board.getObjective(Obj);
            Score UsersScore = obj.getScore(User);
            rewardMoney = UsersScore.getScore();
 
            Bukkit.getServer().dispatchCommand(Bukkit.getConsoleSender(), "execute @p ~ ~ ~ /eco give " + args[2] + " " + rewardMoney);
 
        }
 
        else if(sender instanceof CraftBlockCommandSender) {
            int rewardMoney;
            String Obj = args[1];
            String User = args[0];
            Scoreboard board = player.getScoreboard();
            Objective obj = board.getObjective(Obj);
            Score UsersScore = obj.getScore(User);
            rewardMoney = UsersScore.getScore();
 
            Bukkit.getServer().dispatchCommand(Bukkit.getConsoleSender(), "execute @p ~ ~ ~ /eco give " + args[2] + " " + rewardMoney);
        }
 
        else {
            //put action here
        }
        return true;
    }

 

So to make it work you have to do

Code:Java

Player player = Bukkit.getPlayer(user);

After the String user = args[0];

Also write

Code:Java

Player player = (Player) sender;

Inside the if block and not above it. Otherwise you'll get an error when triggering a command block (always if you get any errors in the console mention them here)

But I still not understand how this should work because you would have to edit the content of the command block everytime another player triggers it.

Please explain that more exactly

 

I added your suggestions, here is my current code:

Code:Java

package com.ryguy2k4.ecoAddon.commands;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.craftbukkit.v1_12_R1.command.CraftBlockCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
 
public class RewardMoneyCommand implements CommandExecutor {
 
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String args[]) {
 
if (sender instanceof Player) {
int rewardMoney;
Player player = (Player) sender;
String Obj = args[1];
String User = args[0];
Scoreboard board = player.getScoreboard();
Objective obj = board.getObjective(Obj);
Score UsersScore = obj.getScore(User);
rewardMoney = UsersScore.getScore();
 
Bukkit.getServer().dispatchCommand(Bukkit.getConsoleSender(), "execute @p ~ ~ ~ /eco give " + args[2] + " " + rewardMoney);
 
}
 
else if(sender instanceof CraftBlockCommandSender) {
int rewardMoney;
String Obj = args[1];
String User = args[0];
@SuppressWarnings("deprecation")
Player player = Bukkit.getPlayer(User);
Scoreboard board = player.getScoreboard();
  Objective obj = board.getObjective(Obj);
Score UsersScore = obj.getScore(User);
rewardMoney = UsersScore.getScore();
 
Bukkit.getServer().dispatchCommand(Bukkit.getConsoleSender(), "execute @p ~ ~ ~ /eco give " + args[2] + " " + rewardMoney);
}
 
else {
//put action here
}
return true;
}
}

But, it still doesn't work, here is the console error

Console Error (open) Console Error (close)

[16:37:10] [Server thread/WARN]: CommandBlock at (-23,81,29) failed to handle command
org.bukkit.command.CommandException: Unhandled exception executing command 'rewardmoney' in plugin EcoAddon v1.0
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:140) ~[craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.CommandBlockListenerAbstract.executeCommand(CommandBlockListenerAbstract.java:267) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.CommandBlockListenerAbstract.executeSafely(CommandBlockListenerAbstract.java:166) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.CommandBlockListenerAbstract.a(CommandBlockListenerAbstract.java:121) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.BlockCommand.a(BlockCommand.java:95) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.BlockCommand.b(BlockCommand.java:81) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.WorldServer.a(WorldServer.java:750) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.WorldServer.doTick(WorldServer.java:304) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:742) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:371) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:651) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:555) [craftbukkit-1.12.2.jar:git-Bukkit-809c399]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_191]
Caused by: java.lang.NullPointerException
at com.ryguy2k4.ecoAddon.commands.RewardMoneyCommand.onCommand(RewardMoneyCommand.java:39) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[craftbukkit-1.12.2.jar:git-Bukkit-809c399]
... 13 more

Here's how it is supposed to work: I am making a minigame where when the player kills a zombie, their score goes up on a scoreboard. At the end of the game, a command block gets triggered, adding the value of their score to their balance.

 

@ryguy2k4

Something at line 39 has a value of null, could you copy that line and post it?
(We can't see line numbers)

 

ok so now i understand what you are trying to do
It looks like the minigame is created in vanilla, otherwise it wouldn't make sense to trigger a command block.
If you would control the minigame using your plugin it would be a lot more easy. But I'll try to help you the way you want it to do.
So first of all I am not able to detect the error in your code. Next time do
[.syntax=Java]<code here>[./syntax] (without the dots)
and post the code from the beginning.
But now to your code:

I changed a few things to make it work:

now the command block just has rewardmoney @p inside it.
and the code would be the following:

Code:Java

if(cmd.getName().equalsIgnoreCase("rewardmoney")) {
            if(args.length == 1) {
                if(sender instanceof CraftBlockCommandSender) {
                    Player p = Bukkit.getPlayer(args[0]);
                    int reward = p.getScoreboard().getObjective("kills").getScore(((OfflinePlayer) p)).getScore();
 
                    Bukkit.getServer().dispatchCommand(Bukkit.getConsoleSender(), "eco give " + p.getName() + " " + reward);
                }
            }
        }

this works perfectly but I don't know it it works with the mechanics of your minigame.

Just try it out and tell if there is anything to change.

 

Thank you so much! It worked perfectly but I just made a few minor changes to make it more customizable. I have been busy the past few weeks but I got on today and tried out your suggestion. Also I changed all my code in this thread to the Java format.

I changed the syntax to be /rewardmoney <player receiving reward> <Scoreboard objective> <Scoreboard player that score is located on> and it worked out with a bit of troubleshooting.

In case you're interested here's the code...

Code:java

package com.ryguy2k4.ecoAddon.commands;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.craftbukkit.v1_12_R1.command.CraftBlockCommandSender;
import org.bukkit.entity.Player;
 
public class RewardMoneyCommand implements CommandExecutor {
 
 
      @Override
      public boolean onCommand(CommandSender sender, Command cmd, String label, String args[]) {
 
            if(cmd.getName().equalsIgnoreCase("rewardmoney")) {
                  if(args.length == 3) {
                        if(sender instanceof CraftBlockCommandSender) {
                              @SuppressWarnings("deprecation")
                              Player p = Bukkit.getPlayer(args[0]);
                              int reward = p.getScoreboard().getObjective(args[1]).getScore(args[2]).getScore();
 
                              Bukkit.getServer().dispatchCommand(Bukkit.getConsoleSender(), "eco give " + p.getName() + " " + reward);
                        }
                  }
            }
            else {
                  //put action here
            }
            return true;
}
}