How to get this so it doesn't spam the message.

http://pastebin.com/wUXvFQh0
I have an issue where it spams it and it multiplies every time it repeats. Can I have some help?

boomp?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I'd be nice if you were more descriptive and could tell us what's wrong. I don't want to read the that whole thing just to find what you could have told us is wrong.

 

Sorry your right I should be more descriptive, I dontknow if I can paste the whole code. But all I know is that it spams the message that goes to all players in the game. I think it is because of the loop but I want another persons opinion and how I could fix it.

Code:java

 public void onJoin(PlayerJoinEvent e){
            Player p = e.getPlayer();
            e.setJoinMessage(prefix + ChatColor.BLUE + " Welcome " + e.getPlayer().getDisplayName() + ", to Random Minigames!");
            playersingame.add(e.getPlayer().getName());
            p.teleport(new Location(Bukkit.getWorld("McUltraGames"), 3, 98, 0));
        //if (playersingame.size() == 1){
        //}
    }
    @EventHandler
    public void onJoinSort(PlayerJoinEvent e) {
        Player p = e.getPlayer();
        if (lobby == true) {
            p.sendMessage(ChatColor.BLUE + "The game will be starting shortly!!! If you get enough players!");
            if (playersingame.size() >= 2) {
                for (String s : playersingame) {
                    Bukkit.getPlayer(s).sendMessage(prefix + ChatColor.BLUE + " The game is starting in 10 seconds! Vote now donators!");
 
                    new BukkitRunnable() {
                        @Override
                        public void run() {
                            pickGame();
 
                        }
                    }.runTaskLater(this, 100);
                }
            }
        }
    }
    @EventHandler
    public void onJoinGo(PlayerJoinEvent e){
        if (lobby == false){
            //if player is not in lobby!
            e.getPlayer().sendMessage(ChatColor.RED + "You have joined while a game is in process. Please wait until the next games starts! :)");
 
        }
    }
 
    @EventHandler
    public void onLeave(PlayerQuitEvent e) {
        e.setQuitMessage(prefix + ChatColor.BLUE + e.getPlayer().getDisplayName() + " has left Random Minigames!");
        playersingame.remove(e.getPlayer().getName());
    }
    public void lobby() {
        for (String s : playersingame) {
            Player ig = Bukkit.getPlayer(s);
            ig.sendMessage(ChatColor.LIGHT_PURPLE + "The game will be chosen in 10 seconds! Vote now donators!");
 
            new BukkitRunnable() {
                @Override
                public void run() {
 
                }
            }.runTaskLater(this, 200);
            pickGame();
        }
    }
 
    public void pickGame() {
        if (g1 > g2 && (g1 > g3)) {
            game1();
        } else if (g2 > g1 && (g2 > g3)) {
            game2();
        } else if (g3 > g1 && (g3 > g2)) {
            game3();
        } else {
            Random rand = new Random();
            int n = rand.nextInt(3);
            switch (n){
                case 1:
                    game1();
                    break;
                case 2:
                    game2();
                    break;
                case 3:
                    game3();
                    break;
                default:
                    game1();
                    break;
            }
        }
    }
    public void timer1() {
        if (playersingame.size() >= 2) {
            if (game_here == true) {//This is where you would put how long each game is and how long it will take to play blahahahahahahahah. You can also do announcements and a bunch of other stuff!
                new BukkitRunnable() {
                    @Override
                    public void run() {
                        for (String s : playersingame) {
                            game_here = false;
 
 
                            Player ig = Bukkit.getPlayer(s);
                            ig.sendMessage(ChatColor.RED + "KmanCrazy won the game == game 1");
                            lobby = true;
                            ig.teleport(lobbyspawn);
                            lobby();
 
                        }
 
                    }
                }.runTaskLater(this, 100);
            }
        }
    }
    public void timer2() {
        if (game_here2 == true) {
            new BukkitRunnable() {
                @Override
                public void run() {
                    for (String s : playersingame) {
                        game_here2 = false;
                        Player ig = Bukkit.getPlayer(s);
                        ig.sendMessage(ChatColor.RED + "Aaron won the game == game 2");
                        lobby();
                    }
                }
            }.runTaskLater(this, 100);
        }
    }
        public void timer3 () {
            if (game_here3 == true) {
                new BukkitRunnable() {
                    @Override
                    public void run() {
                        for (String s : playersingame) {
                            game_here3 = false;
                            Player ig = Bukkit.getPlayer(s);
                            ig.sendMessage(ChatColor.RED + "Hunter won the game == game 2");
                            lobby();
                        }
                    }
                }.runTaskLater(this, 100);
            }
        }

 

KmanCrazy
what message?
and is the message being sent constantly or just on a specific event?

 

tryy3
It is all the events and methods being constantly reused and tried again. It is weird. It just spams the

1. ig.sendMessage(ChatColor.RED + "KmanCrazy won the game == game 1");

 

Events are supposed to be runned when they are fired (example PlayerJoinEvent will always be called if someone joins)

and you got a bit loop going on here... lobby() runs pickGame() on line 85, pickGame() runs Game(), Game() runs timer() , timer() runs lobby()

 

tryy3
Yes I realize that it is a loop that is what it is made to do. But what I really want it to do is not spam the message constantly. When the timer runs off (The end of the game) i want it to say the winner only once.
Same with all the other messages. I think the bukkitrunnable is activated every time one person joins. Is this true and how would i fix it?

Xyplo
... Do you understand what I am talking about? I am saying I don't want it to spam. When the bukkit runnable happens, I don't want it to activate the pick game multiple times. Did you even read what you just quoted?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Dat backdoor though, lol.

 

Lolmewn
?

 

KmanCrazy If you're banned, unban? Silly backdoor Never gonna get accepted on DBO anyway.

 

I quoted the wrong thing. Messags didn't show when I replied to the thread. Sorry

 

Oh that backdoor is supposed to be there. Sorry if that seems scary, the owner of the server said it was ok. I have a "killswitch" because he says that he will pay me. It is completely fine with the owner and if i ever programmed for someone i would tell them if i was putting a backdoor on. And also this isn't for public... So don't go being a jerk about it Lolmewn it is a plugin that I am custom creating. He knows and everything. I though bukkit dev staff were supposed to help. Obviously Im wrong...

Xyplo No prob just though you were talking about that

EDIT by Moderator: merged posts, please use the edit button instead of double posting.