How to add an if op statement in my plugin.

Code:java

package me.xMwpgamer7ooox.PluginHider;
 
 
 
import java.util.logging.Logger;
 
 
 
import org.bukkit.ChatColor;
 
import org.bukkit.command.Command;
 
import org.bukkit.command.CommandSender;
 
import org.bukkit.entity.Player;
 
import org.bukkit.plugin.PluginDescriptionFile;
 
import org.bukkit.plugin.java.JavaPlugin;
 
 
 
public class main
 
  extends JavaPlugin
 
{
 
  public final Logger logger = Logger.getLogger("Minecraft");
 
 
 
  public void onDisable()
 
  {
 
    PluginDescriptionFile p = getDescription();
 
    this.logger.info(p.getName() + "V" + p.getVersion() + "Has Been Enabled!");
 
  }
 
 
 
  public void onEnable()
 
  {
 
    PluginDescriptionFile p = getDescription();
 
    this.logger.info(p.getName() + "V" + p.getVersion() + "Has Been Enabled!");
 
    getConfig().options().copyDefaults(true);
 
    saveConfig();
 
  }
 
 
 
  public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
 
  {
 
    Player player = (Player)sender;
 
    if ((commandLabel.equalsIgnoreCase("plugin")) || (commandLabel.equalsIgnoreCase("plugins")) || (commandLabel.equalsIgnoreCase("pl")) || (commandLabel.equalsIgnoreCase("?")) || (sender.isOp() == false)) {
 
      player.sendMessage(ChatColor.AQUA + "You are not allowed to view HyruleCraft's plugins!");
 
    }
 
 
 
    else if ((commandLabel.equalsIgnoreCase("help")) || (sender.isOp() == false)) {
 
      player.sendMessage(ChatColor.AQUA + "You are not allowed to view HyruleCraft's plugins, help or commands!");
 
    }
 
 
 
    else if (sender.isOp() == true) {
 
  }
 
    return false;
 
  }
 
}
 
 

I am still getting the message error for ops, this is my current code. Please help!

how would I make it so only ops could bypass the error when typing in /pl

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Use

Code:java

        if(player.isOp() == false){
            player.sendMessage("You are not op!");
        }

Something like this to make it like the way you want I think:

Code:java

    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        Player player = (Player) sender;
        if ((commandLabel.equalsIgnoreCase("plugin")) || (commandLabel.equalsIgnoreCase("plugins")) || (commandLabel.equalsIgnoreCase("pl")) || (commandLabel.equalsIgnoreCase("?")) && sender.isOp() == false) {
              player.sendMessage(ChatColor.AQUA + "You are not allowed to view HyruleCraft's plugins!");
              return true;
            }else{
                return false;
            }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Thanks, so would I put return true; at the end of my second if statement?

Code:java

package me.xMwpgamer7ooox.PluginHider;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class main
  extends JavaPlugin
{
  public final Logger logger = Logger.getLogger("Minecraft");
 
  public void onDisable()
  {
    PluginDescriptionFile p = getDescription();
    this.logger.info(p.getName() + "V" + p.getVersion() + "Has Been Enabled!");
  }
 
  public void onEnable()
  {
    PluginDescriptionFile p = getDescription();
    this.logger.info(p.getName() + "V" + p.getVersion() + "Has Been Enabled!");
    getConfig().options().copyDefaults(true);
    saveConfig();
  }
 
  public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
  {
    Player player = (Player)sender;
    if ((commandLabel.equalsIgnoreCase("plugin")) || (commandLabel.equalsIgnoreCase("plugins")) || (commandLabel.equalsIgnoreCase("pl")) || (commandLabel.equalsIgnoreCase("?")) && sender.isOp() == false) {
      player.sendMessage(ChatColor.AQUA + "You are not allowed to view HyruleCraft's plugins!");
      return true;
    }
 
    else if  ((commandLabel.equalsIgnoreCase("help")) && sender.isOp() == false) {
      player.sendMessage(ChatColor.AQUA + "You are not allowed to view HyruleCraft's plugins, help or commands!");
    }         
 
    return false;
  }

Alright so when op, I'm still getting the error I have for the non ops using this code

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Hmm.. It shouldn't be running if you are op.

 

W

Would my rank effect it?

 

xMwpgamer7ooox Beeperdp
Just a Java tip for both of you:

Code:java

if (player.isOp() == false)
 
//and
 
if (player.isOP() == true)

is equivalent to

Code:java

if (!player.isOp())
 
//and, of course
 
if (player.isOp())

Just looks better and more professional

 

The Gaming Grunts

Not to mention the unneeded return statements, if boolean is true, then obviously it'll return true.

 

And also he should be using command.getName() instead of checking the command label. It'll make your code a lot cleaner.

 

How does that make your code cleaner? In his case, they stand for the same thing, so why waste time with that when it's already defined for you?

 

Ah mabye I forgot to explain why. Using command.getName() accounts for all aliases of the command which the OP is trying to do with commandLabel.

 

That doesn't mean cleaner code and as I stated, for him they stand for the same thing as I'm assuming he has no other aliases for that command.

 

What do you mean? This is cleaner code in my opinion:

Code:java

if (cmd.getName().equalsIgnoreCase("plugin")) {
      player.sendMessage(ChatColor.AQUA + "You are not allowed to view HyruleCraft's plugins!");
    }

Than doing this:

 

Not cleaner code, just more efficient.
On a side note, I hadn't noticed he was using multiple aliases for his command, so in that case, it would be preferable to use command.getName().

 

I know - thanks though.

 

hello, I am still having the issue do you have any ideas how to solve the problem?

The Gaming Grunts ^^^ sorry forgot to tag you

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

What is your definition of clean code? I say one definition of clean code means it is easy to read. One boolean in an if statement is a lot easier to read than many.
xMwpgamer7ooox You aren't returning true in your if statement where you are checking if the player is an op. And also please look at my earlier post:

Unless you want something to be different for each alias, do the above.

 

Kazzababe I have yet to come by a case where it would be preferable not to.

 

Rocoty I'm guessing it's preferable to check the label if you're making a bukkit plugin video tutorial, since that seems to happen... not mentioning any names...

 

In the majority of my plugins that involve commands, I never have any commands with any extra aliases, so for me, using command.getName() is not needed. When using aliases, it would obviously be preferable to use command.getName().

 

Can't you also just create a permission for whatever you are trying to make? Then just configure the permission in the plugin.yml and set the default to "op".

 

xMwpgamer7ooox, Wow you use to much spacing. Kinda makes it hard to read.

 

Kazzababe You do realise that server administrators can, if they know how, edit plugin.yml files too? I learned how to do that long before learning how to make plugins. It was a simple way to make an alias for a command that the original developer didn't include, without need of an additional plugin specifically for aliases. This of course assumes that developers have checked the command name rather than a label

But Rocoty said he hadn't seen a case where it was preferable to check the label - even if you can guarantee that there will be no aliases, that doesn't make checking the label preferable. At best it's the same, so why not go with the method that has additional benefits?