How do I check if a block has an inventory, and then get that inventory?

I tried this:

Code:java

    if(block.getState() instanceof InventoryHolder)
    {
        final Inventory inventory=((InventoryHolder)(block.getState())).getInventory();        
    }

But of course, you can't cast BlockState into InventoryHolder. And as far as I can see, there is no BlockState that denotes a block with an inventory. Do I have to make separate if statements for every type of inventory block there is?

 

throwing a guess out there, but what if instead you did

Code:java

if(block.getState() instanceof InventoryHolder){
    InventoryHolder ih = (InventoryHolder)block;
    Inventory i = ih.getInventory();
}

and remember, this is a complete guess

 

Try using ContainerBlock rather than InventoryHolder. This should cover every block that can hold items. It seems that InventoryHolder extends to entities aswell.

ContainerBlock: http://jd.bukkit.org/apidocs/org/bukkit/block/ContainerBlock.html
InventoryHolder: http://jd.bukkit.org/apidocs/org/bukkit/inventory/InventoryHolder.html

 

ContainerBlock is deprecated, it's been replaced by InventoryHolder.

 

Ahhhh, didn't see that. In that case, you may have to check for each case. I.e. Chest, Dispenser, Furnace, and BrewingStand

 

Im not sure i see the issue either way

 

The issue originally was that you can't simply cast a BlockState to an InventoryHolder.

 

Actually, i just did..

Code:java

package me.Corrie.TestPlugin;
 
import java.util.logging.Logger;
 
import org.bukkit.block.Block;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.InventoryHolder;
import org.bukkit.plugin.java.JavaPlugin;
 
public class TestPlugin extends JavaPlugin implements Listener{
Logger log = Logger.getLogger("Minecraft");
 
public void onDisable(){
 
}
 
public void onEnable(){
getServer().getPluginManager().registerEvents(this, this);
}
@EventHandler
public void playerInteract(PlayerInteractEvent event){
Block block = event.getPlayer().getTargetBlock(null,100);
if(block.getState() instanceof InventoryHolder){
InventoryHolder ih = (InventoryHolder)block.getState();
Inventory i = ih.getInventory();
event.getPlayer().openInventory(i);
}
}
}
 

i just punched a chest from afar, and got its inventory displayed to me.

 

Do you mind me building off of that source? Adding permissions, configurable distance etc.
CorrieKay

 

go for it

 

My first project... making it toggleable O.O

 

just make sure you understand how it works, yeah?

 

CorrieKay Umm, I might be missing something completely obvious here, it's late. But I don't see how a BlockState can ever be an instance of InventoryHolder, they have nothing in common (no extending/implementing of each other).

 

his code only check if the block that his cursor is on IS and inventory holder. Like a chest. and then it opens it. I don't really see blockstate and inventoryholder being casted anywhere.

 

Her. ^ ^;;

Also, i dont have any idea either. ive never worked with chest-code before.

But go ahead, compile that code and run it. See for yourself.

 

It's because all BlockStates that have inventories also extend InventoryHolder

 

Something fishy is going on now. I changed it to this:

Code:java

if(location.getBlock().getState() instanceof Chest)
{
Chest ih=(Chest)(location.getBlock().getState());
}

And now all it does is spout this nonsense at me:

Code:

Caused by: java.lang.ClassCastException: org.bukkit.craftbukkit.block.CraftBlock
State cannot be cast to org.bukkit.block.Chest

Now I'm really confused. According to CorrieKay my original code should work, but it doesn't. And neither does this one...

 

change chest to InventoryHolder.

1. if(block.getState() instanceof InventoryHolder){
2. InventoryHolder ih = (InventoryHolder)block.getState();
3. Inventory i = ih.getInventory();
4. event.getPlayer().openInventory(i);

 

see my very first post.

 

Read coriekay's Code post -_- it actually works and it's not casting a block state at all. it's checking if the block on the crosshairs is an inventoryholder then opening that inventory.

 

you can litterally copypaste my code (as long as you make the plugin.yml of course), compile, and have it work...

 

This is CorrieKay code:

Code:java

 
if(block.getState() instanceof InventoryHolder){
InventoryHolder ih = (InventoryHolder)block.getState();
Inventory i = ih.getInventory();
}
 

And this is my code:

Code:java

 if(block.getState() instanceof InventoryHolder)
{
final Inventory inventory=((InventoryHolder)(block.getState())).getInventory();
}

They're the same thing...

 

yeah, and your code works

 

That's the thing, it doesn't. It gives me an error saying CraftBlockState can not be casted to InventoryHolder.

 

except it does. How about you gimme the entire source and a stacktrace instead of telling me it doesnt work?

 

Code:java

package plugin.bleachisback.ChestGrabbers;
 
import java.util.logging.Logger;
 
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.Server;
import org.bukkit.block.Block;
import org.bukkit.block.BlockFace;
import org.bukkit.block.Chest;
import org.bukkit.block.Dispenser;
import org.bukkit.block.Furnace;
import org.bukkit.block.PistonMoveReaction;
import org.bukkit.configuration.Configuration;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockPistonExtendEvent;
import org.bukkit.event.block.BlockPistonRetractEvent;
import org.bukkit.event.block.BlockRedstoneEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.InventoryHolder;
import org.bukkit.inventory.ItemStack;
import org.bukkit.material.PistonBaseMaterial;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class ChestGrabbers extends JavaPlugin implements Listener
{
    public Server server;
    public Logger log=Logger.getLogger("Minecraft");
    private PluginManager pm;
    public Configuration cfg;
 
    public void onDisable() 
    {
        trace(getDescription().getName()+" is disabled");        
    }
 
    public void onEnable() 
    {
        server=getServer();
        pm=server.getPluginManager();
 
        pm.registerEvents(this,this);
 
        trace(getDescription().getFullName()+" is enabled");
    }
 
    @EventHandler
    public void onBlockPistonRetract(final BlockPistonRetractEvent e)
    {
        Location location=e.getRetractLocation();
        if(location.getBlock().getState() instanceof InventoryHolder)
        {
            BlockFace facing=e.getDirection().getOppositeFace();            
            final Block blockTo=location.add(facing.getModX(), facing.getModY(), facing.getModZ()).getBlock();
            trace(blockTo.getType().toString());
            final byte data=location.getBlock().getData();
            InventoryHolder ih=(InventoryHolder)(location.getBlock().getState());//The line where I get the exception
            final Inventory inventory=ih.getInventory();
            final int id=location.getBlock().getTypeId();
            location.getBlock().setType(Material.COBBLESTONE);
            server.getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
                public void run()
                {
                    blockTo.setTypeIdAndData(id, data, false);
                    InventoryHolder ih=(InventoryHolder)blockTo.getState();
                    for(ItemStack item:inventory)
                    {                        
                        ih.getInventory().addItem(item);
                    }
                }
            }, 2);
        }
        trace("Piston retracted");
    }
 
    private void trace(String trace)
    {
        log.info("["+getDescription().getName()+"] "+trace);
    }
}
 

Stack trace:

Code:

12:20:27 [SEVERE] Could not pass event BlockPistonRetractEvent to Chest Grabbers

org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:303)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:459)
        at net.minecraft.server.BlockPiston.g(BlockPiston.java:90)
        at net.minecraft.server.BlockPiston.doPhysics(BlockPiston.java:52)
        at net.minecraft.server.World.k(World.java:520)
        at net.minecraft.server.World.applyPhysics(World.java:499)
        at net.minecraft.server.World.update(World.java:461)
        at net.minecraft.server.World.setData(World.java:404)
        at net.minecraft.server.BlockLever.interact(BlockLever.java:158)
        at net.minecraft.server.ItemInWorldManager.interact(ItemInWorldManager.j
ava:296)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:636)
        at net.minecraft.server.Packet15Place.handle(SourceFile:39)
        at net.minecraft.server.NetworkManager.b(NetworkManager.java:229)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:113)
        at net.minecraft.server.NetworkListenThread.a(NetworkListenThread.java:7
8)
        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:551)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:449)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:492)
Caused by: java.lang.ClassCastException: org.bukkit.craftbukkit.block.CraftBlock
State cannot be cast to org.bukkit.inventory.InventoryHolder
        at plugin.bleachisback.ChestGrabbers.ChestGrabbers.onBlockPistonRetract(
ChestGrabbers.java:121)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:301)
        ... 18 more

 

can i get the method that contains line 121? (and all called methods as well)

 

Line 121 in this case is line 59

 

try removing the parenthases. iono

 

You check location.getBlock(), but cast blockTo.getState(), which are two different blocks.