Solved Hiding the Respawn Screen and Setting the Inventory

So I have recently been looking into the best ways to cancel the respawn screen and the method that seemed genuinely accepted as the best was this:

Code:java

public static void cancelRespawnScreen(Player p)
{
Packet205ClientCommand packet = new Packet205ClientCommand();
packet.a = 1;
((CraftPlayer) p).getHandle().playerConnection.a(packet);
}

So that is what I use.

My issue, however, is not with that method, it is with giving players items in their inventory after they "respawn." The plugin will give the player the items, but the items are not actually there. Anytime this player tries to move an item around in his inventory all the items disappear.

I am settings the player's inventory by using the giveKit (line 72) method in Kit.class (https://github.com/exload/VArenas/blob/master/src/net/vectorgaming/varenas/framework/kits/Kit.java). I can assure you everything in the class works 100%.

I cannot seem to figure this issue out and any additional input is welcomed.

 

exload, To cancel the respawn screen just teleport the player right after death
EDIT: This is an easier way to do it, it just sets the health back to full, and teleports the player to a given location. It effectively stops the player from seeing the respawn screen

Code:java

@EventHandler
public void onDeath(EntityDeathEvent e){
  if(e.getEntity() instanceof Player){
     Player p = (Player) e.getEntity();
     p.setHealth(20.0);
     p.teleport(LOCATION);
    //Code for what you want to add to their inventory
  }
}

 

Odd. I tested this method out and it did not work before. Of course, when I finally decide to post it decides to work Anyways thank you for making me go back and re-test. And now no NMS code!

Actually hold up. It still won't add the items into the player's inventory. The method is called, however, nothing is added into the inventory.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Don't add items in death event. Use a task to do it and run it from death event using Bukkit.runTask(plugin, task). Don't forget to call p.updateInventory() method after messing around with his items.

 

This is generally bad coding practice as you can be forgetting to reset things such as food, saturation, potion effects, tc. Your method also does not call PlayerRespawnEvent, so it will generally conflict with plugins that change a player's spawn point.

 

macguy8, It's Not bad code practice, its just my way of quickly showing it, he's not supposed to just copy and paste

 

How is it not bad code practice? It will break many other plugins such as spawn setting plugins, and a lot of values (such as if the player's on fire, etc) will break. If the OP simply uses the other method posted, minecraft has a method which resets all of this for us and that we won't manually have to update in the future if some new bar / level gets added into the game.

 

Let's not get off topic.. I am still unable to add anything to the players inventory after I force a respawn using either method. Any idea why this might be?

 

still having this issue.. bump

 

use event.setCancelled() at the death event before anything happens

 

I had to use a scheduler to change the inventory/add potion effects, it just seems you have to delay it by a tick or so.

 

The death event is not cancelled silly!

I will try that and let you know how it goes

This has fixed the issue. Thanks!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.