Help!

The plugin is not working. I think i registered wrong the events. Please help !
Code:
Class: Nopick.Java

Code:java

package me.Abdalion.Nopick;
 
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import java.util.logging.Logger;
 
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Nopick extends JavaPlugin{
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Nopick plugin;
 
    @Override
    public void onEnable() {
    PluginDescriptionFile pdfFile = this.getDescription();
    this.getCommand("Nopick").setExecutor(new Nopick1CommandExecutor(this));
    this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " fue habilitado!");
 
}
    List<UUID> list = new ArrayList<UUID>();
 
 
    @Override
    public void onDisable() {
        getLogger().info("fue deshabilitado!");
 
 
}
 
 
 
 
}
 
 
 

Class: Nopick1CommandExecutor

Code:java

package me.Abdalion.Nopick;
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerPickupItemEvent;
 
 
 
public class Nopick1CommandExecutor implements CommandExecutor {
private final Nopick plugin;
 
public Nopick1CommandExecutor(Nopick plugin) {
this.plugin = plugin;
}
 
List<UUID> list = new ArrayList<UUID>();
 
public void PlayerListener(Nopick plugin) {
 
plugin.getServer().getPluginManager().registerEvents((Listener) this, plugin);
 
}
 
@EventHandler
public void onPickup(PlayerPickupItemEvent event) {
Player player = event.getPlayer();
if(list.contains(player.getUniqueId()))
event.setCancelled(true);
 
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("Nopick")){
list.add(p.getUniqueId());
 
 
}
return false;
}
 
 
}
 

I am having trouble with the list! I really don't know what to do.
Created a new project called "Test". Please tell me where i'm wrong!!
I enter the server, do /test an i still pick up items!
Main (Test.java)

Code:java

package me.Abdalion.Test;
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import java.util.logging.Logger;
 
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Test extends JavaPlugin{
 
public final Logger logger = Logger.getLogger("Minecraft");
 
public static Test plugin;
 
@Override
public void onDisable() {
getLogger().info("fue deshabilitado!");
}
 
@Override
public void onEnable() {
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " fue habilitado!");
new PlayerListener(this);
}
 
 
 
 
 
 
 
}
 

Listener (PlayerListener.java)

Code:java

package me.Abdalion.Test;
 
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerPickupItemEvent;
 
 
public class PlayerListener implements Listener {
 
List<UUID> list = new ArrayList<UUID>();
 
public PlayerListener(Test plugin) {
plugin.getServer().getPluginManager().registerEvents(this, plugin);
}
 
@EventHandler
public void onPickup(PlayerPickupItemEvent event) {
Player player = event.getPlayer();
if(list.contains(player.getUniqueId()))
event.setCancelled(true);
else
event.setCancelled(false);
 
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("Test")){
list.add(p.getUniqueId());
}
return false;
}
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Abdalion You need to implement both Listener and CommandExecutor, using the code you posted a few ago where it wouldn't work, you casted it to Listener, rather you need to implement Listener.

 

Abdalion
You didn't toggle picking up items in the command. Use this:

Code:java

if (list.contains(playerUUID)) {
list.remove(playerUUID);
} else {
list.add(playerUUID);
}

 

MineStein He is already registering his events in the constructor of his listener.

 

I think you got that backwards.
"To be added to the VIP list, you need to be in the VIP list, otherwise you can't be in the VIP list."

 

Gamecube762 Whoops... I am full of mistakes today! I'll edit that post now.

 

Still not working and doesn't send the message either. What should i do? D:
I created a commandExecutor but not sure if it's ok.
Test.java:

Code:java

package me.Abdalion.Test;
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import java.util.logging.Logger;
 
import me.Abdalion.Test.TestCommandExecutor;
 
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Test extends JavaPlugin{
 
public final Logger logger = Logger.getLogger("Minecraft");
 
public static Test plugin;
 
@Override
public void onDisable() {
getLogger().info("fue deshabilitado!");
}
 
@Override
public void onEnable() {
PluginDescriptionFile pdfFile = this.getDescription();
this.getCommand("Test").setExecutor(new TestCommandExecutor(this));
this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " fue habilitado!");
new PlayerListener(this);
}
 
List<UUID> list = new ArrayList<UUID>();
 
 
 
 
 
}
 

PlayerListener.java

Code:java

package me.Abdalion.Test;
 
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerPickupItemEvent;
 
 
public class PlayerListener implements Listener {
 
List<UUID> list = new ArrayList<UUID>();
 
public PlayerListener(Test plugin) {
plugin.getServer().getPluginManager().registerEvents(this, plugin);
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("Test")){
if (list.contains(p.getUniqueId())) {
list.remove(p.getUniqueId());
p.sendMessage("Test Deshabilitado!");
} else {
list.add(p.getUniqueId());
p.sendMessage("Test habilitado!");
}
}
return false;
 
 
}
 
@EventHandler
public void onPickup(PlayerPickupItemEvent event) {
Player player = event.getPlayer();
if(list.contains(player.getUniqueId())) {
event.setCancelled(true);
 
  } else {
event.setCancelled(false);
 
 
 
}
}
 
}

TestCommandExecutor.java

Code:java

package me.Abdalion.Test;
 
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerPickupItemEvent;
 
 
public class PlayerListener implements Listener {
 
List<UUID> list = new ArrayList<UUID>();
 
public PlayerListener(Test plugin) {
plugin.getServer().getPluginManager().registerEvents(this, plugin);
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("Test")){
if (list.contains(p.getUniqueId())) {
list.remove(p.getUniqueId());
p.sendMessage("Test Deshabilitado!");
} else {
list.add(p.getUniqueId());
p.sendMessage("Test habilitado!");
}
}
return false;
 
 
}
 
@EventHandler
public void onPickup(PlayerPickupItemEvent event) {
Player player = event.getPlayer();
if(list.contains(player.getUniqueId())) {
event.setCancelled(true);
 
  } else {
event.setCancelled(false);
 
 
 
}
}
 
}
 

 

This is how I usually do it:

Commands.class

Code:Java

public Main plugin;public Commands(Main instance){plugin = instance;}

Main.class

Code:Java

this.getCommand("INSERT_YOUR_COMMAND").setExecutor(newCommands(this));

 

But doing that won't solve my problem

 

Abdalion Your current problem is that you haven't been registering your events, you've been just creating a new eventListener every time the plugin starts.

Bukkit#getPluginsManager()#registerEvents( new PlayerListener(this), this )

 

You should NEVER EVER set an event uncancelled, if you don't know EXACTLY what you do.

Now it seems, that you have duplicated code in PlayerListener/CommandExecuter
It's good practise to add @EventHandler(ignoreCancelled = true), to be sure the event is only called if necessary.
Please use the @Override annontation, that makes the code more readable and "fixes" bug, before the exist.

 

Gamecube762

I added in onEnable

Code:java

 Bukkit.getPluginManager().registerEvents( new PlayerListener(this), this );

.
Is that what you ment? Because its not working

 

In your onPickup try adding debug messages
System.out.println("String")
"Pickup Start"
"Event Canceled"
ext.

 

Abdalion
not sure if what you typed is the same thing, but this one works 100%

Code:java

Bukkit.getPluginManager().registerEvents(this, this);

 

Not sure if you know, but this only works if his main class is also an EventListener.

 

Gamecube762 yes i do know
Abdalion if you wanted to do that with another class (not the main)

Events.class

Code:java

public Main plugin;
public Events(Main instance){plugin= instance;}

Main.class

Code:java

private Events Events = new Events(this);
 
@Override
public void onEnable(){
PluginManager pm = getServer().getPluginManager();
pm.registerEvents(Events, this);
//Anything else...

 

Gamecube762
The problem is in the OnPickup because it sends a message of enable and disable when i do /Test.

Code:java

 @Override
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("Test")){
if (list.contains(p.getUniqueId())) {
list.remove(p.getUniqueId());
p.sendMessage("Test Deshabilitado!");
} else {
list.add(p.getUniqueId());
p.sendMessage("Test habilitado!");
}
}
return false;
}

The onPickup. I think its allright. Note: When you pickup an item it does NOT send you a message, so its completly not working.

Code:java

    @EventHandler
    public void onPickup(PlayerPickupItemEvent event) {
    Player player = event.getPlayer();
    if(list.contains(player.getUniqueId())) {
    event.setCancelled(true);
    player.sendMessage("Item agarrado");
 
 
 
 
}
    }

 

Abdalion Huh? I tried your code and it perfectly works for me (if you ignore the part that it spams you with the no-pickup message xD)

Here's a pastebin, I quickly put your code in 1 class: http://pastebin.com/7L3EEA5T

EDIT: Now incase you want to fix that spam issue, make a new ArrayList:

Code:java

ArrayList<UUID> message = new ArrayList<UUID>();//checks if player has gotten the message before

And then add an if statement before sending the message:

Code:java

if(!message.contains(player.getUniqueId())){
    message.add(player.getUniqueId());
    player.sendMessage("You have disabled item-pickup");
    Bukkit.getScheduler().scheduleSyncDelayedTask(this, new Runnable(){
        public void run(){
            message.remove(player.getUniqueId());
        }
    }, 3 * 20);
}

 

DinosParkour
So, you did everything in one class?

 

Abdalion I quickly pasted your code in one class. If you wanted your plugin to be more clean, you'd normally put your Events in 1 class, your Commands in 1 class and you'd have your Main class.
At the top of the Events and the Commands class, put

Code:java

public Main plugin;
public theNameOfYourClass(Main instance)
{plugin = instance;}

And then at the top of your main class

Code:java

private theNameOfYourEventsClass theNameOfYourEventsClass = theNameOfYourEventsClass(this);
private theNameOfYourCommandsClass theNameOfYourCommandsClass = theNameOfYourCommandsClass(this);

Finally, register the events and don't forget to set the command executor by adding something like this to your onEnable

Code:java

this.getCommand("test").setExecutor(new theNameOfYourCommandsClass(this));

 

DinosParkour Thank you very much! And also you guys Gamecube and Tiger =)