Help!

Hello.
I'm staring with plugin making and i need help with a simple plugin i'm making.
I wish to know how to cancel the PlayerPickUpItemEvent with a command. I mean when the player issues a command, he stops picking up items and then with another command, he picks up items again. Thank you =)

 

1. Create a List<UUID>
2. onCommand - check if the player is in the list then remove them if so, else add them.
3. onPickUpItem - Check if player is in the list, cancel the event

 

Understood. As i said i am a noob, so, would you give me the code please? Its not like im gonna upload the plugin, im just learning

 

While giving the code would be easiest, it would cause you to learn less. I can give you some pseudo code though.

List<UUID> list = List<UUID> //this goes outside of the onCommand and onItemPickup

if list contains ( player getUUID ) // remove them or cancel event
else //add them

 

This is the way to add someone to a list? I researched, but not sure.

Code:java

 
ArrayList <Player> list = new ArrayList<Player>();
 
}
@EventHandler
public void onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if (commandLabel.equalsIgnoreCase("Nopick")){
list.add(p);
 
}
return false;
}
 
}
 

Also, can you lend me your e-mail or your skype? I can't PM you

 

Ya, but I suggest storing the Player's UUID or their name. Storing the player itself can cause problems later if the player leaves.

 

So, i have to use this code to create the list?

Code:java

List<UUID> list = List<UUID>

When i try to use it by its self, it shows me an error.

 

Try

Code:java

List<UUID> list = new ArrayList<UUID>();

 

Well, this is what i did so far. It's got a bunch of mistakes, please help me fix them and also please help me finish the little part missing on the code.

Code:java

package me.Abdalion.Nopick;
 
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import java.util.logging.Logger;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Nopick extends JavaPlugin{
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Nopick plugin;
    List<UUID> list = new ArrayList<UUID>();
    @Override
    public void onEnable() {
    PluginDescriptionFile pdfFile = this.getDescription();
    this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " fue habilitado!");
    }
 
    @Override
    public void onDisable() {
        getLogger().info("fue deshabilitado!");
 
 
    }
    @EventHandler
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        Player p = (Player) sender;
        if(commandLabel.equalsIgnoreCase("Nopick")){
            list.add(p.getUUID());
 
        }
        return false;
    }
 
    @EventHandler
    public void PlayerPickupItemEvent(final Player player, final Item item, final int remaining)
    if(/*What do i have to put here? "If the player is on the list"*/)
    event.setCancelled(true);
 
}
 

 

This has it most of it done for you, you just need to format it correctly

 

Solved it, but still, plugin not working.
Code:

Code:java

package me.Abdalion.Nopick;
 
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import java.util.logging.Logger;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerPickupItemEvent;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Nopick extends JavaPlugin{
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Nopick plugin;
    @Override
    public void onEnable() {
    PluginDescriptionFile pdfFile = this.getDescription();
    this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " fue habilitado!");
    }
    List<UUID> list = new ArrayList<UUID>();
    @Override
    public void onDisable() {
        getLogger().info("fue deshabilitado!");
 
 
    }
 
    @EventHandler
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        Player p = (Player) sender;
        if(commandLabel.equalsIgnoreCase("Nopick")){
            list.add(p.getUniqueId());
 
        }
        return false;
    }
 
    @EventHandler
    public void onPickup(PlayerPickupItemEvent event) {
    Player player = event.getPlayer();
    if(list.contains(player.getUniqueId()))
    event.setCancelled(true);
 
    }
    }
 

To be clear: The problem is that when i enter the game and do /Nopick, the user still picks up items on the floor.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Abdalion You seem to have forgotten to register your events.

 

Moved thread to a more appropriate forum.

 

Not working. I created a new class called PlayerListener.
So the two classes are:
Nopick:

Code:java

package me.Abdalion.Nopick;
 
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import java.util.logging.Logger;
 
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Nopick extends JavaPlugin{
public final Logger logger = Logger.getLogger("Minecraft");
public static Nopick plugin;
@Override
public void onEnable() {
PluginDescriptionFile pdfFile = this.getDescription();
new PlayerListener(this);
this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " fue habilitado!");
}
List<UUID> list = new ArrayList<UUID>();
@Override
public void onDisable() {
getLogger().info("fue deshabilitado!");
 
 
}
 
 
 
 
}
 

And PlayerListener:

Code:java

package me.Abdalion.Nopick;
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerPickupItemEvent;
 
public class PlayerListener implements Listener {
List<UUID> list = new ArrayList<UUID>();
public PlayerListener(Nopick plugin) {
 
plugin.getServer().getPluginManager().registerEvents(this, plugin);
 
}
 
@EventHandler
public void onPickup(PlayerPickupItemEvent event) {
Player player = event.getPlayer();
if(list.contains(player.getUniqueId()))
event.setCancelled(true);
 
}
 
@EventHandler
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("Nopick")){
list.add(p.getUniqueId());
 
}
return false;
}
}
 

What am i doing wrong? I put the command and still picks up items.

 

Abdalion

In your onEnable() do this:

Code:java

getServer().getPluginManager().registerEvents(new PlayerListener(), this);

 

Abdalion looks like you forgot some brackets here

Code:

if(list.contains(player.getUniqueId()))

 

Why does your onCommand have @EventHandler ?
You should change it to:

Code:java

@Override
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("Nopick")){
list.add(p.getUniqueId());
 
}
return false;
}

 

new PlayerListener shows me an error "The constructor PlayerListener() is undefined"

What should i do?

 

Abdalion

Oh yeah, add the Nopick parameter inside the parentheses

 

Code:java

    getServer().getPluginManager().registerEvents(new PlayerListener(Nopick), this);

Nopick cannot be resolved to a variable D:

 

ZodiacTheories He is already registering his events in his Listeners constructor, therefor there is no need for that.
Abdalion You don't implement CommandExecutor, and you never set the command's executor (as the onCommand is outside the main class it needs to be set).
Keep in mind, since you are using a List, both the Listener you register and the executor you set need to share the same instance of PlayerListener, otherwise they will use separate lists and not work.

 

So what should i do instead of: getServer().getPluginManager().registerEvents(new PlayerListener(Nopick), this); ?
Please remember i am starting with coding, and i don't get you D:

 

Abdalion You need to set the command executor and implement CommandExecutor in the class, and use the same instance of PlayerListener for both registering your events and setting the executor.
http://wiki.bukkit.org/Plugin_Tutorial#Using_a_separate_CommandExecutor_class

 

Ok, i created a new project called "Nopick1" to test.
2 classes:
Nopic.java:

Code:java

package me.Abdalion.Nopick;
 
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import java.util.logging.Logger;
 
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class Nopick extends JavaPlugin{
public final Logger logger = Logger.getLogger("Minecraft");
public static Nopick plugin;
 
@Override
public void onEnable() {
PluginDescriptionFile pdfFile = this.getDescription();
this.getCommand("Nopick").setExecutor(new Nopick1CommandExecutor(this));
this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " fue habilitado!");
 
}
List<UUID> list = new ArrayList<UUID>();
 
 
@Override
public void onDisable() {
getLogger().info("fue deshabilitado!");
 
 
}
 
 
 
 
}
 
 
 

And Nopick1CommandExecutor:

Code:java

package me.Abdalion.Nopick;
 
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.player.PlayerPickupItemEvent;
 
 
 
public class Nopick1CommandExecutor implements CommandExecutor {
private final Nopick plugin;
 
public Nopick1CommandExecutor(Nopick plugin) {
this.plugin = plugin;
}
 
List<UUID> list = new ArrayList<UUID>();
 
public void onPickup(PlayerPickupItemEvent event) {
Player player = event.getPlayer();
if(list.contains(player.getUniqueId()))
event.setCancelled(true);
 
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("Nopick")){
list.add(p.getUniqueId());
 
 
}
return false;
}
}
 
 

Is it Ok? Just getting a warning at " private final Nopick plugin; " The value of the field Nopick1CommandExecutor.plugin is not used.
Edit: Tryied the plugin. Not working.

 

Abdalion You've set the executor, but now you aren't registering your events and you've forgotten the @EventHandler annotation.
(that being why the event part isn't working, there are other problems like blindly casting the sender)

 

I added the @EventHandler

Code:java

@EventHandler
    public void onPickup(PlayerPickupItemEvent event) {
    Player player = event.getPlayer();
    if(list.contains(player.getUniqueId()))
    event.setCancelled(true);

How do i register the event?

 

Abdalion The same way you did it when you had your code before.

 

Have you got skype? I have some doubts

 

Abdalion I'd prefer to keep it on this thread.

 

Oh yeah, didn't catch that