Ok, so I set up my minecraft server, I keep having to port forward to connect? what gives? Also what IP should I give my friends when I fix this?
What you have is called a "dynamic IP" which changes often when you connect to the internet. You can stop this by getting what's called a "static" IP, which basically stop your IP from changing. Check this video out on how to do it. As for what IP to give to your friends, give them your "external" IP. You can find this out by typing into Google, "what is my IP"