Solved Help with AutoUpdater?

Hey, guys I recently added the auto updater to my plugin and I wish I didn't because it has caused so many problems.



Could you guys help me fix this please as I don't know how?
Here is my main:

Code:java

package com.gmail.codervortex;
 
 
import java.io.File;
import java.util.ArrayList;
 
import org.bukkit.event.Listener;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
import com.gmail.codervortex.Updater.ReleaseType;
 
 
public class Main extends JavaPlugin implements Listener
{
    private static Main plugin;
    private Events events = new Events(this);
    private com.gmail.codervortex.GuiListener GUI = new GuiListener(this);
    private com.gmail.codervortex.Updater updater;
    public ArrayList<String> kits = new ArrayList<String>();
    public ArrayList<String> AssassinCooldown = new ArrayList<String>();
    public ArrayList<String> Assassin = new ArrayList<String>();
 
 
    public static boolean update = false;
    public static String name = "";
    public static ReleaseType type = null;
    public static String version = "";
    public static String link = "";
 
 
 
    @Override
    public void onEnable() {
        plugin = this;
        getServer().getPluginManager().registerEvents(this, this);
        getLogger().info("Easy Pvp Kits v.1.1.2 is now Enabled.");
        getCommands();
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(events, this);
        pm.registerEvents(GUI, this);
        getConfig().options().copyDefaults(true);
        saveConfig();
        saveResource("config.yml", true);
 
 
 
 
 
          updater = new Updater(this, 66838, this.getFile(), Updater.UpdateType.NO_DOWNLOAD, false); // Start Updater but just do a version check
          update = updater.getResult() == Updater.UpdateResult.UPDATE_AVAILABLE; // Determine if there is an update ready for us
          name = updater.getLatestName(); // Get the latest name
          version = updater.getLatestGameVersion(); // Get the latest game version
          type = updater.getLatestType(); // Get the latest file's type
          link = updater.getLatestFileLink(); // Get the latest link
    }
 
    @Override
    public void onDisable(){
        getLogger().info("Easy Pvp Kits is now Disabled. - Made by Vortex");
    }
 
 
    public static Main getPlugin() {
        return plugin;
    }
 
    public File getPluginFile() {
          return this.getFile();
        }
 
 
    public void getCommands(){
        getCommand("Kits").setExecutor(new com.gmail.codervortex.Commands.kits(this));
        getCommand("Reset").setExecutor(new com.gmail.codervortex.Commands.Reset(this));
        getCommand("Archer").setExecutor(new com.gmail.codervortex.Kits.Archer(this));
        getCommand("Assassin").setExecutor(new com.gmail.codervortex.Kits.Assassin(this));
        getCommand("Heavy").setExecutor(new com.gmail.codervortex.Kits.Heavy(this));
        getCommand("Pyro").setExecutor(new com.gmail.codervortex.Kits.Pryo(this));
        getCommand("Pvp").setExecutor(new com.gmail.codervortex.Kits.Pvp(this));
        getCommand("Update").setExecutor(new com.gmail.codervortex.Commands.update(this));
    }
}
 

Here is the auto updater class:
http://pastebin.com/29D8cVLH

Thank you for looking into this

 

Not sure what you issue is, as you didn't really elaborate on that, but if the issue is that the config is getting reset every server start, it is because the saveResource() paramaters are: (File, boolean replaceExisting). Meaning right now you are resetting the config.yml to the current setup.

 

How would I fix that. Also BUMP

 

22vortex22 replace the saveResource() method from true to false. On line: 44

Code:

saveResource("config.yml", false);

Why aren't you just using the simple this.saveConfig();

 

To auto-download a update (provided you have encased in some form of a permissions check) use:

Code:

updater = new Updater(this, 66838, this.getFile(), Updater.UpdateType.NO_VERSION_CHECK, true);

That's the only thing I can say. I don't really know what your error is since you haven't provided any context.

Now he has both.
Just do saveConfig(). It's much easier than saveResource() and less liable to break.

 

I know how to start the download/check, the guy in the picture is telling me how to toggle it fully and would saveConfig create a file?

 

If you know how to use the updater which you've even explicitly stated ...

Then, why did you create this thread? There's been too much general ambiguity regarding what your problem is. Is it the config? The updater?

If you look here, you can see that getConfig() simply calls save on the actual config file. So yes, it would create a file if one is not present already.

 

I know that, I'm asking on help on what the bukkit mod said.... He said to make an if statement around something, but I don't know what and I don't know how to make the config not reset on startup.

 

I actually didn't read this thread other than the post you just said, but you can use the save default config method to not reset on start up.

 

22vortex22
CaptainBern kind of spelled it all out there for you in his helpful message. Anyone with a basic understanding of Java should have the capabilities of reading and understanding his message to you.

When you declare your updater variable by assigning it to your project, you need to place that in an if statement so it can actually be toggled in the config.

Code:java

if (getConfig().getBoolean("path.to.string")) {
    // DEFINE UPDATER
}

 

Okay I get that, but do I just put it around the whole class? (I know that sounds super stupid.) Where do I put the if statement? I know what to do I just don't know where. And I'm still confused on what I use for the config.

Basically i'm asking what do you mean by define updater?

Updater.java?

or

Code:java

 updater = new Updater(this, 66838, this.getFile(), Updater.UpdateType.NO_DOWNLOAD, false); // Start Updater but just do a version check
          update = updater.getResult() == Updater.UpdateResult.UPDATE_AVAILABLE; // Determine if there is an update ready for us
          name = updater.getLatestName(); // Get the latest name
          version = updater.getLatestGameVersion(); // Get the latest game version
          type = updater.getLatestType(); // Get the latest file's type
          link = updater.getLatestFileLink(); // Get the latest link

or what? I think it was the second one right?

So I got everything else fixed but if I just use saveConfig() and getConfig() it doesn't create a file to be edited? Help I'ts my last thing.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I'd explain something but you have a perfectly good explanation of exactly what's wrong by CaptainBern in your post.

 

Again, that's basic Java ... how on earth can you place an if statement around a whole class?

22vortex22
saving and getting doesn't create a new config. You have to use saveDefaultConfig() to load it. If you use saveDefaultConfig(), you need your config.yml as an embedded resource.

 

>.> I know basic java I just didn't know where to put the if statement... anyways I found that and here is my main onEnable and for some reason the config resets on start up? Help?

Code:java

@Override
    public void onEnable() {
        plugin = this;
        getServer().getPluginManager().registerEvents(this, this);
        getLogger().info("Easy Pvp Kits v.1.1.2 is now Enabled.");
        getCommands();
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(events, this);
        pm.registerEvents(GUI, this);
 
        File file = new File("plugins" + File.separator + "EasyPvpKits" + File.separator + "config.yml");
        if(file.exists()){
            return;
            }
            else{           
            saveResource("config.yml", true);
            getConfig();
            } 
        if(plugin.getConfig().getBoolean("options.auto-update")){
          updater = new Updater(this, 66838, this.getFile(), Updater.UpdateType.NO_DOWNLOAD, false); // Start Updater but just do a version check
          update = updater.getResult() == Updater.UpdateResult.UPDATE_AVAILABLE; // Determine if there is an update ready for us
          name = updater.getLatestName(); // Get the latest name
          version = updater.getLatestGameVersion(); // Get the latest game version
          type = updater.getLatestType(); // Get the latest file's type
          link = updater.getLatestFileLink(); // Get the latest link
        }
        getLogger().info("EasyPvpKits's Auto Update Function is disabled. You can reactivate it in the config.");
    }

 

22vortex22
File file = new File(this.getDataFolder(), "config.yml"); is an easier way of doing it.

And if the file doesn't exist, shouldn't you be creating it? I don't know what your saveResource method entails so please paste that.

 

Its not a custom Method.

 

22vortex22
I had a massive brain leak, sorry.

saveResource only works for embedded files; is your config embedded? If so, then you don't even need to define it as a file and check if it exists or not because it will always exist.

Therefore since it exists, your onEnable is returning and it loads a blank file..