Help squashing bugs!

Hello there! After a lot of time and you guys help, I finally finished my plugin... But... Its full with bugs
I squashed 3-4 bugs, but these are some I don't understand...

Bug #1: [Most annoying] When I place an item like wood, stonebricks, wool (all the items with the ##:1)
it changes to another item with the same ID, but a different sub ID. For instance: If I place red wool, it turn into orange wool. The same thing also happens with potions. If I want to use a speed potion, it turns into a regeneration potion... (Im 100% its my plugin because if I unload it, everything turns back normal.

Bug #2: If you look at the code: (Listener, @Eventhander) you will see that the code is supposed to work only when the item in your hand is a stick with 100 durability. It however works with every item. (exmple: When I right click with a piece of dirt the same thing will happen: The particles appear, the dirt gets a lore).

Bug #3: If you look at the code: (Plugin, @Override) you will get that the recipe "recipepipewithweed1" is supposed to work only if the wheat has a durability of "1", same with the stick. The wheat doesn't give any problems though, if I craft normal wheat with a stick, nothing happens. The stick gives the problems. The recipe *does* work even if its a normal stick.

Code (open) Code (close)

Well, I have not posted all of my code, this is just everything where I think there could be bugs.

Plugin:

Code:java

 
ShapedRecipe recipePipe, recipePipeweed;
 
ShapelessRecipe recipepipewithweed1;
 
public void onEnable() {
        Bukkit.addRecipe(recipePipe = new ShapedRecipe(new ItemStack(Material.STICK, 1)).shape("   ","  #","@@@").setIngredient('@', Material.STICK).setIngredient('#', Material.WOOD));
        Bukkit.addRecipe(recipePipeweed = new ShapedRecipe(new ItemStack(Material.WHEAT, 1)).shape("@#@","#@#","@#@").setIngredient('@', Material.WHEAT).setIngredient('#', Material.SEEDS));
        Bukkit.addRecipe(recipepipewithweed1 = new ShapelessRecipe(new ItemStack(Material.STICK, 1)).addIngredient(1, Material.STICK, 1).addIngredient(1, Material.WHEAT, 1));
        Bukkit.getScheduler().runTaskTimer(this, this, 20, 20);

Listener:

Code:java

 
@EventHandler
    public void onPlayerInteract(final PlayerInteractEvent event) {
        final Player player = event.getPlayer();
            if(event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK){
                if (player.getInventory().getItemInHand().equals(Material.STICK))
                if (player.getInventory().getItemInHand().getDurability() == 100);
                player.sendMessage("§7You started smoking your pipe filled with §aLongbottom leaf");
                ItemStack hand = player.getItemInHand();
                ItemMeta meta = hand.getItemMeta();
                ArrayList<String> lore = new ArrayList<String>();
                lore.clear();
                lore.add(ChatColor.GOLD + "" + ChatColor.ITALIC + "Test.");
                meta.setLore(lore);
                hand.setItemMeta(meta);
                player.getItemInHand().setDurability((short)1);
 
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 0);
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 1);
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 2);
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 3);
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 4);
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 5);
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 6);
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 7);
                    player.getWorld().playEffect(player.getLocation(), Effect.SMOKE, 8);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES, 0);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES, 1);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES, 2);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES, 3);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES, 4);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES, 5);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES, 6);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES, 7);
                    player.getWorld().playEffect(player.getLocation(), Effect.MOBSPAWNER_FLAMES,8);

And:

Code:java

 
        if (recipe instanceof ShapedRecipe) {
            ShapedRecipe sRecipe = (ShapedRecipe)recipe;
            if (recipeMatches(sRecipe, plugin.recipePipeweed)) {
                ItemStack result = new ItemStack(Material.WHEAT, 1, (short)1);
                ItemMeta meta = result.getItemMeta();
                meta.setDisplayName(ChatColor.GREEN + "Longbottom Leaf");
                meta.setLore(Arrays.asList(PipeweedPlugin.LongbottomLore));
                meta.addEnchant(Enchantment.DURABILITY, 1, false);
                result.setItemMeta(meta);
 
                inv.setResult(result);
            }
        }
 
if (recipe instanceof ShapedRecipe) {
            ShapedRecipe sRecipe = (ShapedRecipe)recipe;
            if (recipeMatches(sRecipe, plugin.recipePipe)) {
                ItemStack result = new ItemStack(Material.STICK, 1, (short)1);
                ItemMeta meta = result.getItemMeta();
                meta.setDisplayName(ChatColor.DARK_PURPLE + "Pipe");
                meta.setLore(Arrays.asList(PipeweedPlugin.PipeLore));
                meta.addEnchant(Enchantment.ARROW_INFINITE, 1, false);
                result.setItemMeta(meta);
 
                inv.setResult(result);
            }
        }
 
 
 

 

bug 2 would be fixed by changing: if(player.getInventory().getItemInHand().getDurability()==100);
It should be
if(player.getInventory().getItemInHand().getDurability()==100)
{

}

Obviously, you need to wrap that around the whole method

 

Thank you. This fixes bug all the bugs! Only, it creates another one... Even with the correct stick (With 100 durability) Nothing happens

 

if(player.getInventory().getItemInHand().equals(Material.STICK))

Just for the sake of testing try:
if(player.getInventory().getItemInHand().equals(Material.STICK))
{

}

Also i think getDurability isn't gonna work too well due to the fact that the stick doesn't really have a set durability and getDurability actually gets how much durability it is from that items maximum durability.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Frazz86

I removed the if(player.getInventory().getItemInHand().getDurability()==100);

But still even with a normal stick, nothing works

 

Well, I tried server things, even asked someone else (Someone on the server I play and knows a bit about java) but we could not fix the problem, since we dont know whats wrong at all! I would we terrified if this isnt fixable, since I have put lots and lots of time into this...