Help on my /fly plugin

I coded a fly plugin but i can only do /fly and not /fly <player> any help here the code

Code:

package de.emsfaruq.essentialspro.commands;

import java.util.ArrayList;

import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;

public class FlyCommand implements CommandExecutor {

private ArrayList<Player> fly = new ArrayList<>(); {

}

@Override
public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {

if(sender instanceof Player) {
Player p = (Player) sender;
if(args.length == 0) {
if (p.hasPermission("fly") || p.hasPermission("god.*") || p.hasPermission("EssentialsPro.*")) {
}else
p.sendMessage("§8§kHIII§cDazu hast du keine rechte!§8§kHIII");

Player on = (Player) sender;
if(fly.contains(on)) {
fly.remove(on);
p.sendMessage("§8§kHIII§c4Du bist nicht mehr im Fly-Modus!§8§kHIII");
p.setAllowFlight(false);

}else if(!fly.contains(on)) {
fly.add(on);
p.sendMessage("§8§kHIII§aDu bist jetzt im Fly-Modus!§8§kHIII");
p.setAllowFlight(true);

}if(args.length == 1) {
Player target = Bukkit.getPlayer(args[0]);
if(target != null) {
if(p.hasPermission("feed.others") || p.hasPermission("feed.*") || p.hasPermission("EssentialsPro.*")) {
target.setFoodLevel(20);
target.sendMessage("§aDu wurdest von §6" + p.getName() + " §agefüttert!");
p.sendMessage("§8§kHIII§aDu hast den Spieler §6" + target.getName() + " §agefüttert!§8§kHIII");
} else
p.sendMessage("§8§kHIII§cDazu hast du keine Rechte§8§kHIII");

} else
p.sendMessage("§8§kHIII§cSpieler nicht online§8§kHIII");
} else
p.sendMessage("§8§kHIII§cBenutze /feed <Spieler>§8§kHIII");
}
}
return true;
}
}

 

Probably lost between c&ps but here is the reformatted code:

Reformatted Code (open) Reformatted Code (close)

Code:Java

package de.emsfaruq.essentialspro.commands;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class FlyCommand implements CommandExecutor {
 
    private ArrayList<Player> fly = new ArrayList<>();
 
    {
 
    }
 
    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
 
        if(sender instanceof Player) {
            Player p = (Player) sender;
            if(args.length == 0) {
                if(p.hasPermission("fly") || p.hasPermission("god.*") || p.hasPermission("EssentialsPro.*")) {
                } else p.sendMessage("§8§kHIII§cDazu hast du keine rechte!§8§kHIII");
                Player on = (Player) sender;
                if(fly.contains(on)) {
                    fly.remove(on);
                    p.sendMessage("§8§kHIII§c4Du bist nicht mehr im Fly-Modus!§8§kHIII");
                    p.setAllowFlight(false);
                } else if(!fly.contains(on)) {
                    fly.add(on);
                    p.sendMessage("§8§kHIII§aDu bist jetzt im Fly-Modus!§8§kHIII");
                    p.setAllowFlight(true);
                }
                if(args.length == 1) {
                    Player target = Bukkit.getPlayer(args[0]);
                    if(target != null) {
                        if(p.hasPermission("feed.others") || p.hasPermission("feed.*") || p.hasPermission("EssentialsPro.*")) {
                            target.setFoodLevel(20);
                            target.sendMessage("§aDu wurdest von §6" + p.getName() + " §agefüttert!");
                            p.sendMessage("§8§kHIII§aDu hast den Spieler §6" + target.getName() + " §agefüttert!§8§kHIII");
                        } else
                            p.sendMessage("§8§kHIII§cDazu hast du keine Rechte§8§kHIII");
 
                    } else
                        p.sendMessage("§8§kHIII§cSpieler nicht online§8§kHIII");
                } else
                    p.sendMessage("§8§kHIII§cBenutze /feed <Spieler>§8§kHIII");
            }
        }
        return true;
    }
 
}

A lot of improvements can be made and it will still be up to you whether you want to implement:

Click if you care (open) Click if you care (close)

I use line numbers as in the reformatted code version, not in the original paste.

Line 13: Memory leaks!


Line 15-17: What are the curly braces doing there? I think you got what I'm trying to say.


Line 22: People usually advise using negative returns over positive checks. As such:
(The 2 following statements do the same thing.)



Line 25-26: Empty if-statement body.


Line 27: Did you already forget you casted the sender before?


Line 28-36: Just simplify!


Line 37: What Tim already mentioned. Useless if check.


What.

when class name:

Did you put in the wrong class lol?

Other than those, the last part is pretty solid (Line 37-50).