Help, inventory remover bug

When I run the command "/take cobblestone" with more than 1 stack of cobblestone in my inventory, it will take all of the stacks of cobblestone when it should only take one stack.

Here's the code:

Code:java

                    for (int i = 0; i < inventory.getSize(); i++) {
                        ItemStack item = inventory.getItem(i);
                        if (item != null && item.getType() == Material.COBBLESTONE) {
                            ItemStack newItem;
                            if (item.getAmount() <= 64) {
                                  newItem = null;
                            } else {
                                  newItem = item.clone();
                                  newItem.setAmount(newItem.getAmount() - 64);
                            }
                            inventory.setItem(i, newItem);
                        }
                    }

Thanks in advance!

 

SirHeadLessNick
That's because you are looping through all the inventory slots, regardless of not whether cobblestone has already been removed. You have to figure out of a way to break the for loop if cobblestone has already been removed

 

How?

^

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You can 'name' a loop as the following:

Code:java

YourLoopNameHere: for(...){
 
}

then, from inside of the for-loop, you can break it with:

Code:java

break YourLoopNameHere;

I hope this helps you

 

Cool, cool it works!

But I have a new bug now. If I have a stack of cobblestone layered out in my inventory like in the picture below
it will remove 16 cobblestone blocks not the 4 stacks of 16 which make a stack. Why is this? And how do I fix it?

Code:java

 
Take: for(int i = 0; i < 64; i ++) {
ItemStack item = inventory.getItem(i);
if (item != null && item.getType() == Material.COBBLESTONE) {
ItemStack newItem;
if (item.getAmount() <= 64) {
newItem = null;
} else {
newItem = item.clone();
newItem.setAmount(newItem.getAmount() - 64);
}
inventory.setItem(i, newItem);
break Take;
}
}

^If anyone knows how to fix it, feel free to tell.

Thanks in advance!!

^

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

If I am understanding your code correctly, it looks like you are breaking out of your for loop after you remove one stack of cobblestone, which is why only one stack is removed.

What exactly are you trying to do? Remove one stack of cobblestone if there is a stack of 64, and all others that aren't?

 

I do that because if I don't all stacks of cobblestone inside the inventory will be affected

.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.