Solved Help getting the player's name from a chatevent

Hello!

So I am trying to make a plugin that if a player who is online's full ign is mentioned in the chat that it will send the player who's name was mentioned a sound.

So I had something like this below, but obviously it doesn't work and Idk how to get it to...
Any help would be great thanks!

Code:java

public void onNameMention(PlayerChatEvent event) {
        Player player = event.getPlayer();
        if (event.getMessage().contains(Bukkit.getOnlinePlayers())) {
            Packet62NamedSoundEffect packet = new Packet62NamedSoundEffect("random.orb", player.getLocation().getBlockX(), player.getLocation().getBlockY(), player.getLocation().getBlockZ(), 1.0F, 0.5F);
            ((CraftPlayer) player).getHandle().playerConnection.sendPacket(packet);
        }
    }

Now after looking at it again, I am seeing a few issues, that I just don't know how to solve.
One would be, that the message can't contain the player list....
Also, that the sound packet currently goes to the player who said the name not the actual player who's name was said.

 

You need to get the online player list, and cycle through it using a for loop, each time checking to see if the message contains the player's name.

Example:

Code:java

for (Player p : Bukkit.getOnlinePlayers())
{
code here
}

 

Code:java

public void onNameMention(PlayerChatEvent event) {
        Player player = event.getPlayer();
        for (Player p : Bukkit.getOnlinePlayers()) {
            if (event.getMessage().equals(p)) {
                Packet62NamedSoundEffect packet = new Packet62NamedSoundEffect("random.orb", player.getLocation().getBlockX(), player.getLocation().getBlockY(), player.getLocation().getBlockZ(), 1.0F, 0.5F);
                ((CraftPlayer) player).getHandle().playerConnection.sendPacket(packet);
            }
        }
    }

Would this work?

 

Code:java

public void onNameMention(PlayerChatEvent event)
{
    for (Player p : Bukkit.getOnlinePlayers())
    {
        if (event.getMessage().contains(p.getName()))
        {
            Packet62NamedSoundEffect packet = new Packet62NamedSoundEffect("random.orb", p.getLocation().getBlockX(), p.getLocation().getBlockY(), p.getLocation().getBlockZ(), 1.0F, 0.5F);
            ((CraftPlayer) p).getHandle().playerConnection.sendPacket(packet);
        }
    }
}

 

Thanks you, ima go test it.

 

It cycles through every player online, checks if the message contains their name, and if so, sends the packet. If I am not mistaken, .contains() is case-sensitive, so it will only send the packet if the message contains the players exact name, uppercase letters and all.

 

That would be fine, however, it did not work...

 

Did it give an error?

 

Not a one... Heres what I've got:

Code:java

@EventHandler
public void onNameMention(PlayerChatEvent event) {
Player player = event.getPlayer();
for (Player p : Bukkit.getOnlinePlayers()) {
if (event.getMessage().contains(p.getName())){
Packet62NamedSoundEffect packet = new Packet62NamedSoundEffect("random.orb", player.getLocation().getBlockX(), player.getLocation().getBlockY(), player.getLocation().getBlockZ(), 1.0F, 0.5F);
((CraftPlayer) p).getHandle().playerConnection.sendPacket(packet);
}
}
}

EDIT: I SEE A MISTAKE I MADE! HOLD ON! IMA RECHECK

 

Try replacing the packet code with:

Code:java

p.getWorld().playEffect(p.getLocation(), Effect.POTION_BREAK, 5);

This will cause a potion break effect (red) where the mentioned player is standing. If it works, then your issue lies in the packet code. I am not good with packets however so if this is the case I won't be of much help.

 

No, you were right, thank you! I forgot to change the player.getworld, getlocation etc to p and it was still player.
It works now! Love it thanks!

EDIT: You just got three likes

 

Glad I could help

PS.
Thread Tools > Edit Thread > Solved

 

x17Andrew71x

Code:java

AsyncPlayerChatEvent

 

sgavster
Whys use that?
To get rid of the deprecation?
If so, does it make any real difference? Why is it better?

 

x17Andrew71x Look it up on the java docs. It's like bug fixes and other things

 

AsyncPlayerChatEvent
Async means Asyncronized. Its basically a syncronized method of checking the event, and will work much smoother with other plugins. It also eliminates bugs.

http://en.wikipedia.org/wiki/Asynchrony