Healing problems

I've been trying to make a plugin where you gain health by right clicking an apple. Here is the code I've done but it doesn't seem to work, can anyone help?

Code:java

package me.jackson30007.foodhealer;
 
import org.bukkit.Material;
import org.bukkit.entity.Damageable;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Foodhealer extends JavaPlugin implements Listener {
    public static Foodhealer instance;
    public static Foodhealer getinstance() {
        return instance;
    }
 
    public void onEnable() {
        instance = this;
        Foodhealer foodheal = new Foodhealer();
        getServer().getPluginManager().registerEvents(foodheal, this);
    }
 
    @EventHandler
 
    public void onAppleUse(PlayerInteractEvent e) {
 
    if (e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK) {
 
    if (e.getPlayer().getItemInHand() == new ItemStack(Material.APPLE)) {
 
    e.getPlayer().getInventory().removeItem(new ItemStack(Material.APPLE, 1));
    }
    if(((Damageable) e).getHealth() <= 16) {
      ((Damageable) e).setHealth(((Damageable) e).getHealth() + 4);
    }else{
        ((Damageable) e).setHealth(20);
            }
        }
    }
}

 

jackson30007 Perhaps you could change the way you register the events.

Code:java

Bukkit.getPluginManager().registerEvents(this, this);

And it seems you have closed the bracket too early in your PlayerInteractEvent, as well as you are not defining the player health.

Code:java

    @EventHandler
    public void onAppleUse (PlayerInteractEvent e) {
        Player p = e.getPlayer();
        if (e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK) {
            if (p.getItemInHand().getType() == Material.APPLE) {
                if (p.getHealth() == p.getMaxHealth()) return;
                if (p.getHealth() + 4 > p.getMaxHealth()) {
                    p.setHealth(p.getMaxHealth());
                } else {
                    p.setHealth(p.getHealth() + 4);
                }
                p.getInventory().removeItem(new ItemStack[] { new ItemStack(Material.APPLE, 1) });
            }
        }
    }

 

Thats how I first coded it but I kept getting the "The method getHealth() is ambiguous for the type Player" Error, so I changed the p.getHealth() to e.getHealth() and added the cast (damageable) to e.getHealth() but nothing works.

 

jackson30007 Oh, well have you seen this article? I think you would probably have to place the Bukkit API jar first in your referenced libraries, instead of using the craftbukkit.jar.

 

jackson30007 Instead of p.getHealth use:
Damageable damag = Player;
damag.getHealth();